From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YBOXE9Ki6V9fPgAA0tVLHw (envelope-from ) for ; Mon, 28 Dec 2020 09:18:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GAp0D9Ki6V//HwAAB5/wlQ (envelope-from ) for ; Mon, 28 Dec 2020 09:18:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A151E94030E for ; Mon, 28 Dec 2020 09:18:09 +0000 (UTC) Received: from localhost ([::1]:48974 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktofI-0003gb-Lt for larch@yhetil.org; Mon, 28 Dec 2020 04:18:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39086) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktofC-0003gH-5Y for guix-patches@gnu.org; Mon, 28 Dec 2020 04:18:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:50889) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ktofB-0000C4-Uc for guix-patches@gnu.org; Mon, 28 Dec 2020 04:18:01 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ktofB-0004mM-QI for guix-patches@gnu.org; Mon, 28 Dec 2020 04:18:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#45460] [PATCH 3/5] publish: Add support for zstd compression. Resent-From: Jonathan Brielmaier Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 28 Dec 2020 09:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45460 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 45460@debbugs.gnu.org Received: via spool by 45460-submit@debbugs.gnu.org id=B45460.160914708018363 (code B ref 45460); Mon, 28 Dec 2020 09:18:01 +0000 Received: (at 45460) by debbugs.gnu.org; 28 Dec 2020 09:18:00 +0000 Received: from localhost ([127.0.0.1]:34202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktofA-0004m6-Hp for submit@debbugs.gnu.org; Mon, 28 Dec 2020 04:18:00 -0500 Received: from mout.web.de ([212.227.17.11]:39427) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ktof8-0004lr-9x for 45460@debbugs.gnu.org; Mon, 28 Dec 2020 04:17:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1609147071; bh=awZDMYCZDLmC6rGORWBBKM6lqAl7uc6cg15XMd50QJ8=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=DPg7P/2ZIMO++hUsmgEV7zNAYkeMfuHnmyqTPq3F3HB/dlp6SY2qPOjqhc+AjMsIF bOpvyLH/+5OTeNzNe1b3tPUsVIecN6GjElLRgl75wnRSRqB6hMK3C0GV/6NjAvv3+P AlTAuraiy1WJv0HJsuQvQFqosybbn1oFggJ3mevs= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.178.74] ([5.146.192.224]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MWz8l-1kVP6c2zN3-00XMIy; Mon, 28 Dec 2020 10:17:51 +0100 References: <20201227143809.18554-1-ludo@gnu.org> <20201227143809.18554-3-ludo@gnu.org> From: Jonathan Brielmaier Message-ID: <0ccd6512-566f-3c5a-cd62-65a2d320d919@web.de> Date: Mon, 28 Dec 2020 10:17:50 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201227143809.18554-3-ludo@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:LPiN1RFj8d7iVrvqCVaYIdU6lFYSck3EdppylRjkVd3A0OoxJ53 mRW7VYnN6XsF8t1kM7vj1+BlaqObNjlNA/pCLCfGQxcJclPz8U9JbI3QcyCAysZgvW2UsP0 0BIoM29zQL5YYzkMTCc1GTlfMiac0aXFY/1ULxuD28X1A/lA5cHEP82KFkWRzFnxlXPDOoT /k7CsOIu951k1pvq80EyQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:m4OHQjKEG+o=:Y2P1ziUUVPO2UbA6I0ZYf4 pXBojsfPHjJJg5jfRquo4+0IpLBNr0Bcqr/NT8PQOg7yYndRRH7kxzBCpIkGm1c0SiFUOs4Pr jOmwb/1kfeiQ2vkUfz1vlbNY7WHf6SBaJbRymAHZ1S8CjgytHoiQqMTbxqkuB0k9D2mKSN+39 fxVedLqwgHJ35tljTg0fnPSctKGx8cqrAouwBr7/ka+INvOvLy+oVo/vaZ7umWfVULXA0vWPl Y1Dpw2ebV6lAyRxbby/c7CxPtQfOlbBsdYtVG6R7Y/Ua6T/QX9JJBXltRB7VXOoTuy/hIdePd qukCp1srBLNzG/5pXRgDWh+LPKRr5S9JHvTDsIjx9/5b/v6Fie31k66Ixxyq5HJHTr31MmEAz Yt4L0/vHhavS2xwekjd05QrUPgWiRSFKhHZw65ey9sDO8pJIiNOMNrAyeWVb8Y/QO8aJ9hyP1 Hz0HWmeSuqmGHYV9cfEVODWcjFh3oCgG84fkgwZ500vwCw3QnMGrRnDjcX9H6CQOQOya7dymo h/pX8yZIuz4dHmhT0uWIPLuAAW8oltySHdZX8X5cFX2Af8avvA8WJ6Vzp5GpVtOmiW2pEFHBH L8Fxdm4WlG99MwHJDN7YtZAPkEG5f/RneBBoXhaVZzZtLF8Bb8lywvRKuSbTLRDoFik+DPLy6 5bftFS1JwGmWHf8F9Pm8aDBhh8zgHebj8GcGO5uC/KUwxfJPdsR2zRMEOvtzLMH9mzoPZeUUr CWdwJSMoD02mOKATc2NWQVtxzYI6KaCADqwMEITrPqdevf0kJakdd+A55OOjsjEmh8U1uDGrV PuyG0TwJ7fQZF2GsWlxdaXnpAIuAXznjXjrtzNTja63FvTdMvnY/llP9yBA2uGkuz5xoJMaCM fwR2Yu10wmByEP7u7vay4IKnTqbM+oRBECK5yUvLg= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -1.22 Authentication-Results: aspmx1.migadu.com; dkim=fail (headers rsa verify failed) header.d=web.de header.s=dbaedf251592 header.b=DPg7P/2Z; dmarc=fail reason="SPF not aligned (relaxed)" header.from=web.de (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: A151E94030E X-Spam-Score: -1.22 X-Migadu-Scanner: scn1.migadu.com X-TUID: 2H8WdHNL+7Cr Nice thing, only one nitpick On 27.12.20 15:38, Ludovic Court=C3=A8s wrote: > * doc/guix.texi (Invoking guix publish): Document zstd compression. > --- > doc/guix.texi | 18 ++++++++++++------ > guix/scripts/publish.scm | 31 ++++++++++++++++++------------- > tests/publish.scm | 16 ++++++++++++++++ > 3 files changed, 46 insertions(+), 19 deletions(-) > > diff --git a/doc/guix.texi b/doc/guix.texi > index b12cb11bdf..ed38f2e37b 100644 > --- a/doc/guix.texi > +++ b/doc/guix.texi > @@ -12329,17 +12329,23 @@ server socket is open and the signing key has = been read. > @item --compression[=3D@var{method}[:@var{level}]] > @itemx -C [@var{method}[:@var{level}]] > Compress data using the given @var{method} and @var{level}. @var{meth= od} is > -one of @code{lzip} and @code{gzip}; when @var{method} is omitted, @code= {gzip} > -is used. > +one of @code{lzip}, @code{zstd}, and @code{gzip}; when @var{method} is > +omitted, @code{gzip} is used. > > When @var{level} is zero, disable compression. The range 1 to 9 corre= sponds > to different compression levels: 1 is the fastest, and 9 is the best > (CPU-intensive). The default is 3. > > -Usually, @code{lzip} compresses noticeably better than @code{gzip} for = a small > -increase in CPU usage; see > -@uref{https://nongnu.org/lzip/lzip_benchmark.html,benchmarks on the lzi= p Web > -page}. > +Usually, @code{lzip} compresses noticeably better than @code{gzip} for = a > +small increase in CPU usage; see > +@uref{https://nongnu.org/lzip/lzip_benchmark.html,benchmarks on the lzi= p > +Web page}. However, @code{lzip} achieves low decompression throughput > +(on the order of 50@tie{}MiB/s on modern hardware), which can be a > +bottleneck for someone who downloads over a fast network connection. > + > +The compression ratio of @code{zstd} is between that of @code{lzip} and > +that of @code{gzip}; its main advantage is a > +@uref{https://facebook.github.io/zstd/,high decompression speed}. > > Unless @option{--cache} is used, compression occurs on the fly and > the compressed streams are not It should be also documented at the `guix-publish-configuration` section in the manual. As I guess that a lot of publish server admins look there..= .