From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eXOu2-0003BF-10 for guix-patches@gnu.org; Fri, 05 Jan 2018 05:07:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eXOty-0001ug-SU for guix-patches@gnu.org; Fri, 05 Jan 2018 05:07:06 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:55912) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eXOty-0001tc-MH for guix-patches@gnu.org; Fri, 05 Jan 2018 05:07:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eXOty-000200-7Y for guix-patches@gnu.org; Fri, 05 Jan 2018 05:07:02 -0500 Subject: [bug#29951] [PATCH] WIP guix: Add wrap-script. Resent-Message-ID: References: <20180102204434.2716-1-rekado@elephly.net> <69141465-bdd7-4855-c5d0-a3750646273b@crazy-compilers.com> <87o9m84t2n.fsf@elephly.net> From: Hartmut Goebel Message-ID: <0b4f18c5-ff7d-f03f-e6c7-1866e28099e3@crazy-compilers.com> Date: Fri, 5 Jan 2018 11:06:35 +0100 MIME-Version: 1.0 In-Reply-To: <87o9m84t2n.fsf@elephly.net> Content-Type: multipart/alternative; boundary="------------37E86838AE7EDC0F9EB64E90" Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 29951@debbugs.gnu.org This is a multi-part message in MIME format. --------------37E86838AE7EDC0F9EB64E90 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Am 05.01.2018 um 09:19 schrieb Ricardo Wurmus: Thanks for your reply. >> Does this take care of proper quoting the string-values? > What string values do you refer to? We first generate an S-expression > (where we don’t need to take care of escaping things anyway) and then > format it as a string (with “format” and the “~s” format string), and > then we print that S-expression-as-a-string into a file. I mean the values of the environment variables to be set, whcih might contain double-quotes or backslashes. But I understand that these values are calculated within guile anyway and ~s takes care of proper quoting. So this is fine. Thanks for elaborating. -- Regards Hartmut Goebel | Hartmut Goebel | h.goebel@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible | --------------37E86838AE7EDC0F9EB64E90 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 8bit
Am 05.01.2018 um 09:19 schrieb Ricardo Wurmus:

Thanks for your reply.

Does this take care of proper quoting the string-values?

What string values do you refer to?  We first generate an S-expression
(where we don’t need to take care of escaping things anyway) and then
format it as a string (with “format” and the “~s” format string), and
then we print that S-expression-as-a-string into a file.

I mean the values of the environment variables to be set, whcih might contain double-quotes or backslashes.

But I understand that these values are calculated within guile anyway and ~s takes care of proper quoting. So this is fine. Thanks for elaborating.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |
--------------37E86838AE7EDC0F9EB64E90--