From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: rg@raghavgururajan.name, 65699@debbugs.gnu.org
Subject: [bug#65699] [PATCH gnome-team 5/7] gnu: nautilus: Update to 44.2.
Date: Tue, 05 Sep 2023 18:59:07 +0200 [thread overview]
Message-ID: <0ab782c04df789325072c888c6b1a8cc2f3d0706.camel@gmail.com> (raw)
In-Reply-To: <87il8pnvmj.fsf@gmail.com>
Am Montag, dem 04.09.2023 um 23:31 -0400 schrieb Maxim Cournoyer:
> Hi,
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>
> > * gnu/packages/gnome.scm (nautilus): Update to 44.2.
> > [#:phases]: Add ‘hardcode-tracker’.
> > Adjust ‘skip-gtk-update-icon-cache’ accordingly.
> > [inputs]: Remove gtk+ and libhandy.
> > Add gtk and libadwaita.
> > * gnu/packages/patches/nautilus-extension-search-path.patch: Adjust
> > accordingly.
> > ---
> > gnu/packages/gnome.scm | 24 ++++---
> > .../nautilus-extension-search-path.patch | 64 +++++++++++----
> > ----
> > 2 files changed, 52 insertions(+), 36 deletions(-)
> >
> > diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
> > index 0d52058eb4..d550b204c3 100644
> > --- a/gnu/packages/gnome.scm
> > +++ b/gnu/packages/gnome.scm
> > @@ -9619,7 +9619,7 @@ (define-public tracker-miners
> > (define-public nautilus
> > (package
> > (name "nautilus")
> > - (version "42.2")
> > + (version "44.2")
> > (source (origin
> > (method url-fetch)
> > (uri (string-append "mirror://gnome/sources/" name
> > "/"
> > @@ -9627,7 +9627,7 @@ (define-public nautilus
> > name "-" version ".tar.xz"))
> > (sha256
> > (base32
> > -
> > "1cncyiyh79w1id6a6s2f0rxmgwl65lp4ml4afa0z35jrnwp2s8cr"))
> > +
> > "1rfkh43iw4bqv36ccznl3lh9g0p9pa8xqyjk167qlvar4xchcji7"))
> > (patches
> > (search-patches "nautilus-extension-search-
> > path.patch"))))
> > (build-system meson-build-system)
> > @@ -9636,6 +9636,13 @@ (define-public nautilus
> > #:glib-or-gtk? #t
> > #:phases
> > #~(modify-phases %standard-phases
> > + (add-after 'unpack 'hardcode-tracker
> > + (lambda* (#:key inputs #:allow-other-keys)
> > + (substitute* "src/nautilus-tag-manager.c"
> > + (("\"tracker3\"")
> > + (string-append "\""
> > + (search-input-file inputs
> > "/bin/tracker3")
> > + "\"")))))
>
> The leading slash in search-input-file is unnecessary.
I prefer it and search-input-file is explicitly coded to go both ways.
> You can also use
> '(format #f "~s" (search-input-file inputs "bin/tracker3"))', which
> is shorter / more readable (?).
I see string-append preferred in the code base, but I can do either.
How strongly do you feel I ought to use format?
Cheers
next prev parent reply other threads:[~2023-09-05 17:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 12:01 [bug#65699] [PATCH gnome-team 0/7] Update Nautilus and Console Liliana Marie Prikler
2023-09-02 11:34 ` [bug#65699] [PATCH gnome-team 1/7] gnu: gnome-autoar: Update to 0.4.4 Liliana Marie Prikler
2023-09-02 11:34 ` [bug#65699] [PATCH gnome-team 2/7] gnu: tracker: Update to 3.5.3 Liliana Marie Prikler
2023-09-02 11:35 ` [bug#65699] [PATCH gnome-team 3/7] gnu: tracker-miners: Update to 3.5.2 Liliana Marie Prikler
2023-09-02 11:36 ` [bug#65699] [PATCH gnome-team 5/7] gnu: nautilus: Update to 44.2 Liliana Marie Prikler
2023-09-05 3:31 ` Maxim Cournoyer
2023-09-05 16:59 ` Liliana Marie Prikler [this message]
2023-09-06 1:06 ` Maxim Cournoyer
2023-09-05 3:33 ` Maxim Cournoyer
2023-09-02 11:37 ` [bug#65699] [PATCH gnome-team 4/7] gnu: libadwaita: Update to 1.3.4 Liliana Marie Prikler
2023-09-02 11:58 ` [bug#65699] [PATCH gnome-team 6/7] gnu: vte: Update to 0.72.2 Liliana Marie Prikler
2023-09-02 11:59 ` [bug#65699] [PATCH gnome-team 7/7] gnu: gnome-console: Update to 44.4 Liliana Marie Prikler
2023-09-05 3:34 ` Maxim Cournoyer
2023-09-05 16:57 ` Liliana Marie Prikler
2023-09-05 3:35 ` [bug#65699] [PATCH gnome-team 0/7] Update Nautilus and Console Maxim Cournoyer
2023-09-07 18:36 ` bug#65699: " Liliana Marie Prikler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ab782c04df789325072c888c6b1a8cc2f3d0706.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=65699@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).