From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8A/CLi06VGJrKQEAgWs5BA (envelope-from ) for ; Mon, 11 Apr 2022 16:24:45 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id EEuHJy06VGK9rQAAG6o9tA (envelope-from ) for ; Mon, 11 Apr 2022 16:24:45 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 99B9F8F12 for ; Mon, 11 Apr 2022 16:24:43 +0200 (CEST) Received: from localhost ([::1]:46268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nduyA-0004uw-OF for larch@yhetil.org; Mon, 11 Apr 2022 10:24:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59064) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nduqk-0006Uy-Bj for guix-patches@gnu.org; Mon, 11 Apr 2022 10:17:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51018) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nduqk-00014C-0w for guix-patches@gnu.org; Mon, 11 Apr 2022 10:17:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nduqj-00007A-Tx for guix-patches@gnu.org; Mon, 11 Apr 2022 10:17:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#54852] [PATCH] gnu: Add openjdk18. Resent-From: Julien Lepiller Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 11 Apr 2022 14:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54852 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Rostislav Svoboda , 54852@debbugs.gnu.org Received: via spool by 54852-submit@debbugs.gnu.org id=B54852.1649686601411 (code B ref 54852); Mon, 11 Apr 2022 14:17:01 +0000 Received: (at 54852) by debbugs.gnu.org; 11 Apr 2022 14:16:41 +0000 Received: from localhost ([127.0.0.1]:44915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nduqP-00006Z-8u for submit@debbugs.gnu.org; Mon, 11 Apr 2022 10:16:41 -0400 Received: from lepiller.eu ([89.234.186.109]:33124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nduqM-00006L-49 for 54852@debbugs.gnu.org; Mon, 11 Apr 2022 10:16:40 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id e9705004; Mon, 11 Apr 2022 14:16:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=LDGWtJ/ZL6rf QoJ/ko+ZZiMxeoJ74KeiFsECbJzClSE=; b=n6Ppt7gQqJG78oU6t2ZhTkLmQy3L z2FeQq/mxnRBYnIsrE4DU6v1/mvVK4YgnGkIB6dg9oTG3biguSQBupU7+naOh84l 4y8gElAS0I6FBnLRgCC1W+wIanfQ0zLS94GXXuG83xKy9ujkgBM+YO0Fxs/t7jBr nFh2yQiSgYo5GShbOL/greDZjwEs4Iu9ycPV6kobQyTRCpoQbu1DyYy2/jqpd6DS +v7SBB0Eef6YgY6W3HpV/RWYwQuADg6kn1Nrn/x6A7vIe/bBCFXtbep7nC0KKVwN S78MLxEweNA7i9sE5mL3so0KD/1uM9gpDdZNeV6rqOI6ROApKNSo+q7K6A== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id c2e59898 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 11 Apr 2022 14:16:32 +0000 (UTC) Date: Mon, 11 Apr 2022 16:15:46 +0200 From: Julien Lepiller User-Agent: K-9 Mail for Android In-Reply-To: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> References: <20220411125335.4047-1-Rostislav.Svoboda@gmail.com> Message-ID: <0A4C69EF-B0AA-4B99-AFC5-44C6602E7305@lepiller.eu> MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----1RCFYM5FSLGULW8ZSAHCN6SD0PGQA6 Content-Transfer-Encoding: 7bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1649687085; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=qbNknJXH3MoaJgxUAALzeiMIfzBxYI7k/FAPYxLQE9w=; b=ap4vqXoVBTvinsPaz1A7pn8OhL2GrNkJ8nMW7mQgCfDKe0Ioi1/vi5EsbFQgTbOm3cUkos DDpMcLbKchVkCrLyEdNsnk3F0CgPl4gI/r6L78Zt84D7Jmu/w6TcVcd5pHbby3POJ8b7N5 oXbF/PgbJqb00C2/yzJ1VxR58YO52+8PDCoDma56ALzgAEOvsveNKm04VTohgp0GWsx2sh VIu6MidSd5fAze2IAz0mYnJxMPChSUSrmz/GHhawGn/3cHkm4vYcdxmawK6tu9mQNZ2DYF OxQNzbpxZcCswwXxLQb7/kZa/W/JSkwjx9nepJmfJyb+jUOOUmX2TNcYnPHpLQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1649687085; a=rsa-sha256; cv=none; b=S+NYU4TfwRA3DdNFtTa8H0uc9DHYoci7OGvLiGQeaunKWQr6U/ZCzbasarOsxN/eh3PFyk fSu95VJnpus9D9lMFeGcPfku8NxtXoOeL89ajQmTsCIv5RC09cxv1Xo2uvS0DzqqKel18w 3fa6d7X8YpHItL8Ux+uNqteXxoKNQefQxqat+N6wf1ZY9L+fd1SR29fSKeHCc47FeV2oaX XAyatTZEKvuCqFcqkzR6VaP/qc7T76YBUv28p450bal6IF8of6OAAyUVMgPewMXdcusJWZ CESz66hkuc4xVfwPSOgy9SWWBALIuNGQxMPf7s1bPkrs33YAuHRE2RvWbl24VQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=n6Ppt7gQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.13 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=lepiller.eu header.s=dkim header.b=n6Ppt7gQ; dmarc=fail reason="SPF not aligned (relaxed)" header.from=lepiller.eu (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 99B9F8F12 X-Spam-Score: 5.13 X-Migadu-Scanner: scn0.migadu.com X-TUID: fvqLMCT87Pl9 ------1RCFYM5FSLGULW8ZSAHCN6SD0PGQA6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! The patch looks great, but I wonder why you need to change che phases to t= omething that looks like openjdk 17's phases? Am I missing something? Would= n't it work without any change to the arguments? I can't build and test because of my limited bandwidth=2E Hopefully anothe= r maintainer can rur the tests and maybe push if my issues aren't solved so= on=E2=80=A6 On April 11, 2022 2:53:35 PM GMT+02:00, Rostislav Svoboda wrote: >--- > gnu/packages/java=2Escm | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > >diff --git a/gnu/packages/java=2Escm b/gnu/packages/java=2Escm >index 6738b5dc35=2E=2E10c84d2973 100644 >--- a/gnu/packages/java=2Escm >+++ b/gnu/packages/java=2Escm >@@ -2263,6 +2263,39 @@ (define-public openjdk17 > (("^#!=2E*") "#! java BlockedCertsConverter SHA-256\n")= ))))))) > (home-page "https://openjdk=2Ejava=2Enet/projects/jdk/17"))) >=20 >+(define-public openjdk18 >+ (package >+ (inherit openjdk17) >+ (name "openjdk") >+ (version "18") >+ (source (origin >+ (method git-fetch) >+ (uri (git-reference >+ (url "https://github=2Ecom/openjdk/jdk18u") >+ (commit (string-append "jdk-" version "-ga")))) >+ (file-name (git-file-name name version)) >+ (sha256 >+ (base32 >+ "1bv6bdhkmwvn10l0xy8yi9xibds640hs5zsvx0jp7wrxa3qw4qy8"))= )) >+ (native-inputs >+ `(("autoconf" ,autoconf) >+ ("openjdk17:jdk" ,openjdk17 "jdk") >+ ("pkg-config" ,pkg-config) >+ ("unzip" ,unzip) >+ ("which" ,which) >+ ("zip" ,zip))) >+ (arguments >+ (substitute-keyword-arguments (package-arguments openjdk16) >+ ((#:phases phases) >+ `(modify-phases ,phases >+ (replace 'fix-java-shebangs >+ (lambda _ >+ ;; This file was "fixed" by patch-source-shebangs, but it= requires >+ ;; this exact first line=2E >+ (substitute* "make/data/blockedcertsconverter/blocked=2Ec= erts=2Epem" >+ (("^#!=2E*") "#! java BlockedCertsConverter SHA-256\n")= ))))))) >+ (home-page "https://openjdk=2Ejava=2Enet/projects/jdk/18"))) >+ > (define-public icedtea icedtea-8) >=20 > =0C> >--=20 >2=2E35=2E1 > > > > ------1RCFYM5FSLGULW8ZSAHCN6SD0PGQA6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi!

The patch looks great, but I wonder why= you need to change che phases to tomething that looks like openjdk 17's ph= ases? Am I missing something? Wouldn't it work without any change to the ar= guments?

I can't build and test because of my limited bandwidth=2E H= opefully another maintainer can rur the tests and maybe push if my issues a= ren't solved soon=E2=80=A6

On April 11, 2= 022 2:53:35 PM GMT+02:00, Rostislav Svoboda <rostislav=2Esvoboda@gmail= =2Ecom> wrote:
gnu/packages/java=2Escm | 33 +++++= ++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)

di= ff --git a/gnu/packages/java=2Escm b/gnu/packages/java=2Escm
index 6738b= 5dc35=2E=2E10c84d2973 100644
--- a/gnu/packages/java=2Escm
+++ b/gnu/= packages/java=2Escm
@@ -2263,6 +2263,39 @@ (define-public openjdk17
= (("^#!=2E*") "#! java BlockedCertsConverter SHA-256\n"))))= ))))
(home-page "https://openjdk=2Ejava=2Enet/projects/jdk/17")))
+(define-public openjdk18
+ (package
+ (inherit openjdk17)=
+ (name "openjdk")
+ (version "18")
+ (source (origin+ (method git-fetch)
+ (uri (git-reference+ (url "https://github=2Ecom/openjdk/jdk18u")
+ = (commit (string-append "jdk-" version "-ga"))))
+ = (file-name (git-file-name name version))
+ (sha256+ (base32
+ "1bv6bdhkmwvn10l0xy8yi9xibds64= 0hs5zsvx0jp7wrxa3qw4qy8"))))
+ (native-inputs
+ `(("autoconf" = ,autoconf)
+ ("openjdk17:jdk" ,openjdk17 "jdk")
+ ("pkg-c= onfig" ,pkg-config)
+ ("unzip" ,unzip)
+ ("which" ,which)=
+ ("zip" ,zip)))
+ (arguments
+ (substitute-keyword-= arguments (package-arguments openjdk16)
+ ((#:phases phases)
+ = `(modify-phases ,phases
+ (replace 'fix-java-shebangs+ (lambda _
+ ;; This file was "fixed" by pa= tch-source-shebangs, but it requires
+ ;; this exact first= line=2E
+ (substitute* "make/data/blockedcertsconverter/b= locked=2Ecerts=2Epem"
+ (("^#!=2E*") "#! java BlockedCer= tsConverter SHA-256\n"))))))))
+ (home-page "https://openjdk=2Ejava= =2Enet/projects/jdk/18")))
+
(define-public icedtea icedtea-8)
<= br> =0C
--
2=2E35=2E1



------1RCFYM5FSLGULW8ZSAHCN6SD0PGQA6--