From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cIG8OCafkWCXJgAAgWs5BA (envelope-from ) for ; Tue, 04 May 2021 21:23:18 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CFI/NCafkWCnBgAAbx9fmQ (envelope-from ) for ; Tue, 04 May 2021 19:23:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 67ABB1A11E for ; Tue, 4 May 2021 21:23:18 +0200 (CEST) Received: from localhost ([::1]:33284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1le0dZ-0002mN-Iu for larch@yhetil.org; Tue, 04 May 2021 15:23:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48474) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1le0dK-0002eV-4t for guix-patches@gnu.org; Tue, 04 May 2021 15:23:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:43385) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1le0dJ-0003Ht-Th for guix-patches@gnu.org; Tue, 04 May 2021 15:23:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1le0dJ-0007Ow-MD for guix-patches@gnu.org; Tue, 04 May 2021 15:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48224] [PATCH 2/2] gnu: guix: Phases refer to #:system and #:target. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 04 May 2021 19:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48224 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 48224@debbugs.gnu.org Received: via spool by 48224-submit@debbugs.gnu.org id=B48224.162015615128442 (code B ref 48224); Tue, 04 May 2021 19:23:01 +0000 Received: (at 48224) by debbugs.gnu.org; 4 May 2021 19:22:31 +0000 Received: from localhost ([127.0.0.1]:54929 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le0co-0007Og-SE for submit@debbugs.gnu.org; Tue, 04 May 2021 15:22:31 -0400 Received: from michel.telenet-ops.be ([195.130.137.88]:60124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1le0cl-0007OZ-FQ for 48224@debbugs.gnu.org; Tue, 04 May 2021 15:22:29 -0400 Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d]) by michel.telenet-ops.be with bizsmtp id 0jNQ2500H0mfAB406jNRZk; Tue, 04 May 2021 21:22:26 +0200 Message-ID: <09cee506693a26af13b7fbc318f7a09528161bbc.camel@telenet.be> From: Maxime Devos Date: Tue, 04 May 2021 21:21:24 +0200 In-Reply-To: <20210504133958.11011-2-ludo@gnu.org> References: <20210504133958.11011-1-ludo@gnu.org> <20210504133958.11011-2-ludo@gnu.org> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-vyd+lAXi5P8IDrMI97jE" User-Agent: Evolution 3.34.2 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21; t=1620156146; bh=9PYFJlTyH/uVFhQXjFIY1EPai2pBFP8+oyH4sb1bavU=; h=Subject:From:To:Date:In-Reply-To:References; b=CdHLGzQ6dpZs4f4nP0lQTznCo6aEDUBc+phbnZBwKzTUHeszqnHTGlHpdpLz1bzW3 K+NGEc9e7CZyG74pYg6irGMSIHK2VfDI10NDwIll737pLadyC558jvFKIlzY5r6NJa J5DiWJduaYmMa2c4FW5d7phuKCL8tFkx9r/HQ2bBcTHsJ3Tu0swjOu3wOCrukjXyvq w3YtcdBUz5RbUOzTH9U3RywkCdeOMXogSh5fujhW4Pr5j+8BjsQKRQAe1aHs45ILl9 030ubcmIVDCpWhxSK6oC6x3aLTCRuUpFEK//NkgKxvyLyjUM8XLEyB3rnpjyjzIMBY zBYN0Nxzeu/Nw== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1620156198; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=9PYFJlTyH/uVFhQXjFIY1EPai2pBFP8+oyH4sb1bavU=; b=QJ1foh+2/uOOhN6fKXfItfy2cZX9mhW2m3Umop8Sp2CLp94EDhicUTWgRIsiKHDcEwTaL9 jYLFF6b60dK8+7p3Z5ut2QW8TFqGZwSiUu8yfh9DZB46ndaDr4FgrdOzsaBmZa0Un2ye/R iJdlIm9u9z0m49Mz14b8dbEgeNzMx/xmZleCzSeZLB8meom/Pk58U5QWKMhuMIFUHB6z51 LOlR6POM3hjomscAQZJ0H2cAY+++TNzGmWjizHNEmxTCF+sz49OpROAoVdrGP7GVV33ev/ eX/VrsVpY5iigLT4qNmp6zQe5j07X9hey16UbwCWfuP0L6mjsqIWAM20hZyS+A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1620156198; a=rsa-sha256; cv=none; b=XFP1sRRq8l4U1SqOptug0E77mB2mx31QneP2hOK0PQqQI93u1AMbUeOGv+ozrV+W9eOytE MQeiSRn+Q0jq/bcOzP1xltEAa5DY+L4xORzL85//6rzspE3Aml+BTTA0SRDkNYZoxOND+f dGc2Yex/jKr1PoMFGLRp9uV/Tp+DdVKCbDKAet7q0NmvQId+y8TI2I70Z2/lvMCSJLZk+n I5Up6m9O8+rY1YOGEqZRsXHdGQhEsQ24kWbGjc5QIPdO5xsrEUnzl4h8lVnNv7l6o1DfW/ 33O0WUGrEdNZrB2fraLrFf7zScmKJ3xA3zmrILNUv8craRsjB6b4o58dq22vMg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=CdHLGzQ6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.96 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=telenet.be header.s=r21 header.b=CdHLGzQ6; dmarc=fail reason="SPF not aligned (relaxed)" header.from=telenet.be (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 67ABB1A11E X-Spam-Score: -1.96 X-Migadu-Scanner: scn0.migadu.com X-TUID: RXc4AMDyHLab --=-vyd+lAXi5P8IDrMI97jE Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable > The second patch is stylistic: it avoids missing phases, which I > find more readable. I don't see any missing phases. (I read this as =E2=80=98The second patch i= s stylistic: it avoids making the existence of a phase dependent on %current-target-system.=E2=80=99) > - (guile ,@(if (%current-target-system) > - '((assoc-ref native-inputs = "guile")) > - '((assoc-ref inputs "guile"= )))) > + (guile (if target > + (assoc-ref native-inputs "gui= le") > + (assoc-ref inputs "guile"))) Something I tend to do is (assoc-ref (or native-inputs inputs) "guile") Do you have any particular preference? > (deps (list gcrypt json sqlite gnutls g= it > bs ssh zlib lzlib zstd guil= e-lib)) > - (deps* ,@(if (%current-target-system) > - '(deps) > - '((cons avahi deps)))) > + (deps* (if target deps (cons avahi deps)= )) Why not simply ;; avahi is #f (not in 'inputs') when cross-compiling. ;; Remove it. (deps* (delete #f avahi)) ? Then, when guile-avahi becomes cross-compilable at some point, we only need to adjust 'propagated-inputs' and not anything else. Also, was this code (deps* ,@(if (%current-target-system) '(deps) ...)) nee= ded in the first place? guile2.2-guix inherits its phases from guix, and guile2.2= -guix does not have a guile-zlib or guile-lzlib input. Greetings, Maxime. --=-vyd+lAXi5P8IDrMI97jE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iI0EABYKADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYJGetxccbWF4aW1lZGV2 b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7lKCAQDII0Euh3ERQWLQkV5IwF9598e9 7EFyt3bCCrCOSwfdwQD+L08KkO2TPoYUOc9FQzDcEBWyjskAmMYJP2Ld35e+qQI= =feig -----END PGP SIGNATURE----- --=-vyd+lAXi5P8IDrMI97jE--