From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UL5VLb2WhmBnKwEAgWs5BA (envelope-from ) for ; Mon, 26 Apr 2021 12:32:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id 6IHvKL2WhmDmFQAAB5/wlQ (envelope-from ) for ; Mon, 26 Apr 2021 10:32:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1707026D5D for ; Mon, 26 Apr 2021 12:32:29 +0200 (CEST) Received: from localhost ([::1]:41474 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1layXT-0005W8-Pp for larch@yhetil.org; Mon, 26 Apr 2021 06:32:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1layX4-0005VH-Tu for guix-patches@gnu.org; Mon, 26 Apr 2021 06:32:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33193) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1layX4-0002sQ-Lo for guix-patches@gnu.org; Mon, 26 Apr 2021 06:32:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1layX4-0004WG-Es for guix-patches@gnu.org; Mon, 26 Apr 2021 06:32:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#48028] [PATCH wip-gnome v3 04/10] gnu: libsoup: Simplify adjustment of tests. Resent-From: Raghav Gururajan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 26 Apr 2021 10:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 48028 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Leo Prikler , 48028@debbugs.gnu.org Received: via spool by 48028-submit@debbugs.gnu.org id=B48028.161943308717309 (code B ref 48028); Mon, 26 Apr 2021 10:32:02 +0000 Received: (at 48028) by debbugs.gnu.org; 26 Apr 2021 10:31:27 +0000 Received: from localhost ([127.0.0.1]:44733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1layWV-0004V7-61 for submit@debbugs.gnu.org; Mon, 26 Apr 2021 06:31:27 -0400 Received: from out1.migadu.com ([91.121.223.63]:43331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1layWS-0004Ux-KB for 48028@debbugs.gnu.org; Mon, 26 Apr 2021 06:31:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raghavgururajan.name; s=key1; t=1619433084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cwvszQEpNnVXGmynhQdUBHi8o1PLHFPnTIBSxNQWBiI=; b=OkXW5j9hnojT7BeJ0n21L2lmbyzq/cMjOVH/ZClnLL2R1AES+lsF2Mn/bFLvLj0mFU7yjX JvnLd09BtQkpVJDlD3BNM0yEgHU16YsoVAZUjyerkXM0U/5Zf2kFC/6hphGKt8A7Ma4ut/ eqqK4dyd7NmYmAgA6YdAvGCi85nBw5HroKuoB6vMwP9/GQUGhMTHnilmr/t0PKCC/Vzllr dvuRLaQfCKdd7qYlu6qt/gjGlUXaoiThl1Ep1rO55JxHIS3DshvRgF6WV1F23QoFbsNYpW K2SQskacuOCquRvMmlRcjniAsgjqmi+OOHhL9/xSbeca1ivvITtl18TIAtN51A== References: <20210426092215.31032-1-rg@raghavgururajan.name> <20210426092215.31032-4-rg@raghavgururajan.name> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. Message-ID: <0981a7c6-f10a-29e8-d369-d1d2f5d9ff1a@raghavgururajan.name> Date: Mon, 26 Apr 2021 06:31:22 -0400 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6qOwWbkrl9fqDxwzCpVjfH9CON0Dyi02c" X-Migadu-Auth-User: rg@raghavgururajan.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" Reply-to: Raghav Gururajan X-ACL-Warn: , Raghav Gururajan via Guix-patches From: Raghav Gururajan via Guix-patches via X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619433149; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=cwvszQEpNnVXGmynhQdUBHi8o1PLHFPnTIBSxNQWBiI=; b=XjvV8jbPNtZEoZJii1I/v8JVOJ+zYI6t0tojF+auANOZQNpg46A/EpBBlQG9OkkUVXSuHC Mr9g2d5Z+JvW1VoGnFt7GBwVH0PbRO6yy/0aurtsdpXbpuG4kUXmlI7BL6qIyIiT8myD8o TQXfAIbWGpVkr9SDgGOp7Ip4eJ+IQUkyTf0TzFTPmZK+HJB9vJ+zv0sP1R8Ewq4OSK49kJ NMNHFVFJzNEYzuRrfR9NeESYkBmCxhpxwmQvA4i9oOXM9FDzo3/k82q6kDVoOtETRLLcgO V1uukEYs7ynhIEL+Yz+FaiuI1kDCStpgpj1VTxSTm0xYF5CLc9vIusWttbEaJA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1619433149; a=rsa-sha256; cv=none; b=kDHHPVW+UsOcnnuojLgwkZhxJImlYMVyUWikl3qr4pNniDMSi0DkOG2YARGra9/eYy4Ki1 RF+p14uWmOn+urfBBdO2g4XVKIuUbprYR1xaeICgT5SSOoFdB99PtVsyMXWKJ7dUoYCazK XUHSBS/5aGto/P1t9XGymSe4c9OM11iNmmWY+vNlLfi2ujpAiJZO5yZo520opTFL782xiR 1U4cCPVYXl5HReWXvIRZaBr72noLpfuMa0MkQGKCsOWPtZRkFfmaoRa74bnbBBKaxiggkx Dvw3aoMPLG8J2EaH4RmEWjcttoRbZmpeitPzo1NQ4oarpSfwaCca1IEf/3H6bw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b=OkXW5j9h; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -4.95 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=raghavgururajan.name header.s=key1 header.b=OkXW5j9h; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 1707026D5D X-Spam-Score: -4.95 X-Migadu-Scanner: scn0.migadu.com X-TUID: 0DY0e1tg4XL9 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6qOwWbkrl9fqDxwzCpVjfH9CON0Dyi02c Content-Type: multipart/mixed; boundary="d1wiQ8t9jl9QcXXFsNDcx5c9GYCTsXEuC"; protected-headers="v1" From: Raghav Gururajan To: Leo Prikler , 48028@debbugs.gnu.org Message-ID: <0981a7c6-f10a-29e8-d369-d1d2f5d9ff1a@raghavgururajan.name> Subject: Re: [PATCH wip-gnome v3 04/10] gnu: libsoup: Simplify adjustment of tests. References: <20210426092215.31032-1-rg@raghavgururajan.name> <20210426092215.31032-4-rg@raghavgururajan.name> In-Reply-To: --d1wiQ8t9jl9QcXXFsNDcx5c9GYCTsXEuC Content-Type: multipart/mixed; boundary="------------C4B1AAA5E04C7782A3A7E0B7" Content-Language: en-US This is a multi-part message in MIME format. --------------C4B1AAA5E04C7782A3A7E0B7 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Leo! > I'm sorry, but after a closer look, I will have to reject this patch. > This does far more than just disable a few failing tests, it disables > all tests, that happen to lie in a file with a failing one. Please > stick to disabling patches in the C files, or if the entire C file > fails just disable that one in meson (but try to see if you can disable= > it in C as well). No worries! Thanks for the review. In v4, I have only disabled ssl-test via meson.build, as any of the=20 tests included in ssl-test.c fails. Regards, RG. --------------C4B1AAA5E04C7782A3A7E0B7 Content-Type: application/pgp-keys; name="OpenPGP_0x5F5816647F8BE551.asc" Content-Transfer-Encoding: quoted-printable Content-Description: OpenPGP public key Content-Disposition: attachment; filename="OpenPGP_0x5F5816647F8BE551.asc" -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX2ZCJBYJKwYBBAHaRw8BAQdAdiUK33kml2dYjrWidlr4/v0pmjpUv7hOsBN/oSl5wx7NL= 1Jh Z2hhdiBHdXJ1cmFqYW4gKFJHKSA8cmdAcmFnaGF2Z3VydXJhamFuLm5hbWU+wpMEExYIADsCG= wMF CwkIBwIGFQoJCAsCBBYCAwECHgECF4AWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCX28v0AIZA= QAK CRBfWBZkf4vlUQf2AQD63gsdJzk0w6Gy0AzpJtMa63mbVRAh4xfnxsRNu6SbGQD/UDytGjwnQ= 4nK YsGdoCcA7LM64EkknDvI3ZmlqG7Xuw/NPVJhZ2hhdiBHdXJ1cmFqYW4gKEVkdWNhdGlvbikgP= GVk dWNhdGlvbkByYWdoYXZndXJ1cmFqYW4ubmFtZT7CkAQTFggAOBYhBM0tXqqpjMs32pHWsF9YF= mR/ i+VRBQJgE0xGAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEF9YFmR/i+VRQcQBALNRe= 1V/ 5DKN8ZxyVQlzt4TdGUyNom7xJ6r23ANtcygxAQDBjw6NLXV3aYGDMVVmQPbdAnFiB/x1rpJsA= wB/ 1BSBDc05UmFnaGF2IEd1cnVyYWphbiAoRmluYW5jZSkgPGZpbmFuY2VAcmFnaGF2Z3VydXJha= mFu Lm5hbWU+wpAEExYIADgWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYBNMbwIbAwULCQgHAgYVC= gkI CwIEFgIDAQIeAQIXgAAKCRBfWBZkf4vlUWnLAP914hb0IzSCiaj+XrcEBaIt/Q+KjRn2fj5A7= V6Z ucJJqwEA64eks7xjLBS3mpTpaGwdDtluJcR7G8XZJJdbdK2YyQ/NN1JhZ2hhdiBHdXJ1cmFqY= W4g KEhlYWx0aCkgPGhlYWx0aEByYWdoYXZndXJ1cmFqYW4ubmFtZT7CkAQTFggAOBYhBM0tXqqpj= Ms3 2pHWsF9YFmR/i+VRBQJgE0yhAhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEF9YFmR/i= +VR xdcA/3YxFzlKKHrTguDxE1tBWD31BUYlXWl351j6MB/U+tWdAPwJB8QD8janaddv3U5ZGzswf= hQv GGzx6SLcX0E253uNC80/UmFnaGF2IEd1cnVyYWphbiAoT2NjdXBhdGlvbikgPG9jY3VwYXRpb= 25A cmFnaGF2Z3VydXJhamFuLm5hbWU+wpAEExYIADgWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCY= BNM ugIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBfWBZkf4vlUSrlAP0VJw8frvWHAGd6l= Zdy x1v+relUGB4DToqDgIMBQyG58gD+NU5t4h0IY6YaiQ+FPyJzdV62k15d9IDvTMYPvcWIpQPNP= 1Jh Z2hhdiBHdXJ1cmFqYW4gKFJlY3JlYXRpb24pIDxyZWNyZWF0aW9uQHJhZ2hhdmd1cnVyYWphb= i5u YW1lPsKQBBMWCAA4FiEEzS1eqqmMyzfakdawX1gWZH+L5VEFAmATTNkCGwMFCwkIBwIGFQoJC= AsC BBYCAwECHgECF4AACgkQX1gWZH+L5VHhbQD/b6jXWdQfxi+xzrs1+A0lvnihfUgQ0H/r5U2bO= w9d FIkA/0nCh0VJKX+YrySJhWugL7e8ItqwKADh0v05vO6qtlkAzTdSYWdoYXYgR3VydXJhamFuI= ChT b2NpYWwpIDxzb2NpYWxAcmFnaGF2Z3VydXJhamFuLm5hbWU+wpAEExYIADgWIQTNLV6qqYzLN= 9qR 1rBfWBZkf4vlUQUCYBNM8AIbAwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAKCRBfWBZkf4vlU= dtv AQCKMxBdxwMUJdyigGWqrTuJUaLVL2dgvqGa0k39nsQA8gD+PH3LsQAaJ98xREKxYXMAszNnJ= RJR xYa9trfixyQbrw7NNVJhZ2hhdiBHdXJ1cmFqYW4gKFRyYWRlKSA8dHJhZGVAcmFnaGF2Z3Vyd= XJh amFuLm5hbWU+wpAEExYIADgWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYBNNHQIbAwULCQgHA= gYV CgkICwIEFgIDAQIeAQIXgAAKCRBfWBZkf4vlUQ+9AP0S/6S5PLshS/vz7ezRO2HokruaRiDhg= w0t yRM3LAefSQEA7rEBw9sSUsDgRILGKUi1ZzQq5AJ0F77KOXyurVqnywXOOARfZkIkEgorBgEEA= ZdV AQUBAQdAZgiqc2NhH/myrCCan9x7gKI6QBPZ/1b+Bz/f3n95ozkDAQgHwngEGBYIACAWIQTNL= V6q qYzLN9qR1rBfWBZkf4vlUQUCX2ZCJAIbDAAKCRBfWBZkf4vlUV/OAQD+tMNgmddPSchLpaDPp= sdD hpvra2uTonNUmnfbTvPgpQD/dG72NCT8hBUVqtzxwQmBrXY/nPEUxctYuvu3unUmzQU=3D =3DMROf -----END PGP PUBLIC KEY BLOCK----- --------------C4B1AAA5E04C7782A3A7E0B7-- --d1wiQ8t9jl9QcXXFsNDcx5c9GYCTsXEuC-- --6qOwWbkrl9fqDxwzCpVjfH9CON0Dyi02c Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTNLV6qqYzLN9qR1rBfWBZkf4vlUQUCYIaWegUDAAAAAAAKCRBfWBZkf4vlUUaa AQCCB/iAObcUbx/zZoSONUzHd6kWhOrLeQtGLT5gICBvmgEA7Om1G3Ly+hg626tW3VvnhVVr7XGu hU7+l1PJDz1xags= =+2It -----END PGP SIGNATURE----- --6qOwWbkrl9fqDxwzCpVjfH9CON0Dyi02c--