unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Filip Łajszczak" <filip@lajszczak.dev>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 66960@debbugs.gnu.org
Subject: [bug#66960] [PATCH] gnu: Add guile-algorithms
Date: Sat, 25 Nov 2023 19:09:18 +0000	[thread overview]
Message-ID: <0960428c-cbc7-4486-8831-8bf0de341363@lajszczak.dev> (raw)
In-Reply-To: <87a5r1wvcz.fsf@gnu.org>


[-- Attachment #1.1.1: Type: text/plain, Size: 974 bytes --]

On 11/25/23 18:17, Mathieu Othacehe wrote:
> 
> Hello,
> 
>> +          (sha256
>> +            (base32
>> +             "0sqnica53kpxc8lmsf9aqzf3wcfjnxq4sxg0j9ka4fjh0id931qc"))))
> 
> It looks like the hash is now:
> 0r4fgq0p8lwma4cmdjb1xy2r40wkb7rg5b0cri2cab698fmb97al.
> 
> Does it mean that the release package was updated?

It should not have been as the tag was on the same commit, but it is now 
as I moved it to include small docs change. I do not totally understand.

> 
>> +     "Guile port of @url{https://docs.racket-lang.org/algorithms/index.html,
>> +racket-algorithms}, a package containing many useful algorithms borrowed from many
>> +other programming languages).")
> 
> You can remove both "many".
> 

Yep, make sense. It was just copied from the description of the original 
racket package, but it is better less bombastic.

> Thanks,
> 
> Mathieu

Thanks for your review. Amended patch to follow.

All the best,
Filip

[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 3207 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]

  reply	other threads:[~2023-11-25 19:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-05 21:07 [bug#66960] [PATCH] gnu: Add guile-algorithms Filip Lajszczak
2023-11-25 18:17 ` Mathieu Othacehe
2023-11-25 19:09   ` Filip Łajszczak [this message]
2023-11-25 19:12 ` [bug#66960] [PATCH v2] " Filip Lajszczak
2023-11-26 13:36   ` bug#66960: " Mathieu Othacehe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0960428c-cbc7-4486-8831-8bf0de341363@lajszczak.dev \
    --to=filip@lajszczak.dev \
    --cc=66960@debbugs.gnu.org \
    --cc=othacehe@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).