[bug#40285] gnu: packages: java: antlr3: Make antlr3-3.3 public

[bug#40285] gnu: packages: java: antlr3: Make antlr3-3.3 public

[Raghav Gururajan]

[-- Attachment #1: Type: text/plain, Size: 106 bytes --]

Hello Guix!

Please find the attached patch to make the "antlr3-3.3" variable public.

Regards,
RG.

[-- Attachment #2: antlr3-3.3.patch --]
[-- Type: application/octet-stream, Size: 747 bytes --]

From be47a8520cddcee72ba9be531bbe922118f027d2 Mon Sep 17 00:00:00 2001
From: Raghav Gururajan <raghavgururajan@disroot.org>
Date: Sun, 29 Mar 2020 21:45:10 -0400
Subject: [PATCH 15/15] gnu: packages: java: antlr3: Make antlr3-3.3 public

* gnu/packages/java.scm (antlr3): Make antlr3-3.3 public.
---
 gnu/packages/java.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 400ef8795e..37108f56c0 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -7162,7 +7162,7 @@ tree walking, and translation.")
     (inputs
      `(("junit" ,java-junit)))))
 
-(define antlr3-3.3
+(define-public antlr3-3.3
   (package
     (inherit antlr3)
     (name "antlr3")
-- 
2.26.0

bug#40285: gnu: packages: java: antlr3: Make antlr3-3.3 public

[Maxim Cournoyer]

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to make the "antlr3-3.3" variable public.
>
> Regards,
> RG.
>
> From be47a8520cddcee72ba9be531bbe922118f027d2 Mon Sep 17 00:00:00 2001
> From: Raghav Gururajan <raghavgururajan@disroot.org>
> Date: Sun, 29 Mar 2020 21:45:10 -0400
> Subject: [PATCH 15/15] gnu: packages: java: antlr3: Make antlr3-3.3 public
>
> * gnu/packages/java.scm (antlr3): Make antlr3-3.3 public.
> ---
>  gnu/packages/java.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
> index 400ef8795e..37108f56c0 100644
> --- a/gnu/packages/java.scm
> +++ b/gnu/packages/java.scm
> @@ -7162,7 +7162,7 @@ tree walking, and translation.")
>      (inputs
>       `(("junit" ,java-junit)))))
>  
> -(define antlr3-3.3
> +(define-public antlr3-3.3
>    (package
>      (inherit antlr3)
>      (name "antlr3")

I added a bit more context to the commit message, fixed the gnu: antlr3:
prefix and pushed as commit 011f941279.

Thank you!

Maxim

[bug#40285] gnu: packages: java: antlr3: Make antlr3-3.3 public

[Maxim Cournoyer]

Hello Raghav!

"Raghav Gururajan" <raghavgururajan@disroot.org> writes:

> Hello Guix!
>
> Please find the attached patch to make the "antlr3-3.3" variable public.
>
> Regards,
> RG.

(I thought I had sent this already but it seems not -- sending it just
for the record, even though I've already merged this change to master).

It would have been easier for us reviewers to add the changes related to
the packaging of Linphone in the same patch series (appearing before the
packages that need this), so as to have the context and understand the
rational of making this change.

I've marked those as blocking 40307 (linphone), so OK for this time, but
keep in mind for next time :-).

Maxim