unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Jean Pierre De Jesus DIAZ <me@jeandudey.tech>, 57043@debbugs.gnu.org
Subject: [bug#57043] [PATCH] gnu: rust-freetype-sys-0.13: Unbundle freetype2.
Date: Sun, 7 Aug 2022 23:59:26 +0200	[thread overview]
Message-ID: <07ad189f-3042-2354-cc85-333f34bba966@telenet.be> (raw)
In-Reply-To: <HGgZmDLEAonfFN-y6zfOKMo8NKy1RXvOfRvKz_NhjsFPW6NMdGToBoJpBnJ5Rh8b6eRsJjw7UpVAxlhZeJww-6VXMmYswdYS2QXvB1fdEBE=@jeandudey.tech>


[-- Attachment #1.1.1: Type: text/plain, Size: 836 bytes --]


On 07-08-2022 20:39, Jean Pierre De Jesus DIAZ via Guix-patches via wrote:
> Hello,
>
> This patch removes the bundled freetype2 library on `rust-freetype-sys-0.13'.
>
> Also removes unneeded build dependencies (`pkg-config' and `cmake').

I've noticed this in antioxidant (and fixed it there locally) but didn't 
report it yet.

Anyway, this can be done more simple -- all that I needed to do was 
deleting the freetype2 subdirectory (in a snippet) and adding 'freetype' 
to inputs.  Patching the build script or build.rs was not necessary.

Additionally, I noticed that in the modified build.rs, only 
rustc-link-lib (-l) is set, but not rustc-link-search (-L). Antioxidant 
needs the latter to be set, otherwise dependents will fail to link 
because of not finding the freetype library.

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  reply	other threads:[~2022-08-07 22:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-07 18:39 [bug#57043] [PATCH] gnu: rust-freetype-sys-0.13: Unbundle freetype2 Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-07 21:59 ` Maxime Devos [this message]
2022-08-08 14:37 ` Jean Pierre De Jesus DIAZ via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=07ad189f-3042-2354-cc85-333f34bba966@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=57043@debbugs.gnu.org \
    --cc=me@jeandudey.tech \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).