From: Vivien Kraus via Guix-patches via <guix-patches@gnu.org>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 56505-done@debbugs.gnu.org
Subject: [bug#56505] [PATCHES] Mingw configuration for openssl
Date: Fri, 05 Aug 2022 09:58:56 +0200 [thread overview]
Message-ID: <07478ef69ed48a60979eb06923fd4ecafddcce42.camel@planete-kraus.eu> (raw)
In-Reply-To: <87edxvk66j.fsf_-_@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
Hi,
Le vendredi 05 août 2022 à 00:14 +0200, Ludovic Courtès a écrit :
> ‘guix build openssl --target=x86_64-w64-mingw32’ works and the funny
> part is that .dll files end up in bin/, but I think that’s intended
> on
> Windows?
That’s right. Windows does not have shared objects, and DLLs are not.
You cannot use the compiler to link to a DLL as far as I understand, so
you wouldn’t put them in lib. What you have in lib are the so-called
"import libraries" (.dll.a). These are static libraries that pretend to
provide the functionality, but in fact open the DLL at run-time to
fetch the library implementation from the DLL. So DLLs are kind of
resources.
Anyway, you see that in lib/ you have all the .dll.a files… Oops… I may
have forgotten to check this… This is not a huge problem, because all
outputs would be available when building a dependent package, but it’s
still not right I think.
Now, the .dll.a files are smaller than the static libraries, but not
that small. I don’t know why exactly.
Should I open a new issue with this patch, or is it somehow possible to
continue the discussion here?
Best regards,
Vivien
[-- Attachment #2: 0001-gnu-openssl-Keep-.dll.a-files-in-main-output.patch --]
[-- Type: text/x-patch, Size: 1419 bytes --]
From 1ee8daf446ca874ff4e5daa65d6f4034df51838e Mon Sep 17 00:00:00 2001
From: Vivien Kraus <vivien@planete-kraus.eu>
Date: Fri, 5 Aug 2022 09:52:21 +0200
Subject: [PATCH] gnu: openssl: Keep .dll.a files in main output.
* gnu/packages/tls.scm (openssl) [phase move-static-libraries]: Do not move
.dll.a files to the static output when targetting mingw.
---
gnu/packages/tls.scm | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/tls.scm b/gnu/packages/tls.scm
index 1e527ecce2..4ee75ace3d 100644
--- a/gnu/packages/tls.scm
+++ b/gnu/packages/tls.scm
@@ -507,7 +507,13 @@ (define-public openssl
(for-each (lambda (file)
(install-file file slib)
(delete-file file))
- (find-files lib "\\.a$")))))
+ (find-files
+ lib
+ #$(if (target-mingw?)
+ '(lambda (filename _)
+ (and (string-suffix? ".a" filename)
+ (not (string-suffix? ".dll.a" filename))))
+ "\\.a$"))))))
(add-after 'install 'move-extra-documentation
(lambda _
;; Move man pages and full HTML documentation to "doc".
base-commit: cc4c02e346a71ccef897e2d9f04fa2df2529a269
--
2.37.1
next prev parent reply other threads:[~2022-08-05 8:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 23:55 [bug#56505] [PATCHES] Mingw configuration for openssl Vivien Kraus via Guix-patches via
2022-07-19 18:37 ` [bug#56505] Use the target predicates from (guix utils) Vivien Kraus via Guix-patches via
2022-08-04 22:14 ` bug#56505: [PATCHES] Mingw configuration for openssl Ludovic Courtès
2022-08-05 7:58 ` Vivien Kraus via Guix-patches via [this message]
2022-08-05 9:34 ` [bug#56505] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=07478ef69ed48a60979eb06923fd4ecafddcce42.camel@planete-kraus.eu \
--to=guix-patches@gnu.org \
--cc=56505-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).