From: Julien Lepiller <julien@lepiller.eu>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 44032@debbugs.gnu.org
Subject: [bug#44032] [PATCH] gnu: ocaml: Update to 4.11.1
Date: Mon, 19 Oct 2020 11:14:32 -0400 [thread overview]
Message-ID: <0736C245-79D4-4A6F-B79E-0D51A45F67DC@lepiller.eu> (raw)
In-Reply-To: <CAJ3okZ0nEaJ5G636GAU2qer3ewj5Vi-UT=7myt+SEWZjV5S3EQ@mail.gmail.com>
Le 19 octobre 2020 10:24:23 GMT-04:00, zimoun <zimon.toutoune@gmail.com> a écrit :
>On Mon, 19 Oct 2020 at 16:11, Julien Lepiller <julien@lepiller.eu>
>wrote:
>
>> >> +(define-public ocaml4.09-csexp
>> >> + (package
>> >> + (inherit ocaml-csexp)
>> >> + (name "ocaml4.09-csexp")
>> >> + (arguments
>> >> + `(#:ocaml ,ocaml-4.09
>> >> + #:findlib ,ocaml4.09-findlib
>> >> + ,@(substitute-keyword-arguments (package-arguments
>> >ocaml-csexp)
>> >> + ((#:dune _) (package-with-ocaml4.09
>dune-bootstrap)))))
>> >> + (propagated-inputs
>> >> + `(("ocaml-result" ,(package-with-ocaml4.09
>ocaml-result))))))
>> >
>> >You do not use the one you define below. Why? Other said, do you
>> >really need 'ocaml4.09.result' defined below?
>>
>> Actually, the properties ensure that I actually use the one below :)
>
>I am not sure. You are recreating a package based on 'ocaml-result'
>and not using the package 'ocaml4.09-result'. Or I miss something
>about the symbols.
package-with-ocaml4.09 first reads the properties field of its arguments, and if it has an ocaml4.09-variant,it uses it. Otherwise it creates a new package that uses ocaml 4.09, ocaml4.09-findlib and ocaml4.09-dune.
If you remove the property in ocaml-result, you'll see that building (package-with-ocaml4.09 result) ends up in a loop: it wants ocaml4.09-dune, but is itself a dependency of ocaml4.09-dune.
>
>
>> >> +(define-public ocaml4.09-result
>> >> + (package
>> >> + (inherit ocaml-result)
>> >> + (arguments
>> >> + `(#:test-target "."
>> >> + #:dune ,(package-with-ocaml4.09 dune-bootstrap)
>> >> + #:ocaml ,ocaml-4.09
>> >> + #:findlib ,ocaml4.09-findlib))))
>> >
>> >Since the name is not changed after inheritance, this package is
>> >ambiguous. And possibly do not compile.
>>
>> Ah right, thanks!
>
>Moreover, my point is: you are using
>
> once:
> (properties `((ocaml4.09-variant . ,(delay ocaml4.09-result))))
>and once:
> `(("ocaml-result" ,(package-with-ocaml4.09 ocaml-result))))))
>
>and it seems easier to only use one form. Other said, maybe you do
>not need the new 'ocaml4.09-result' and '(package-with-ocaml4.09
>ocaml-result)' is enough.
OK, I'll use the variant I define everywhere if it makes things easier to understand later.
>
>
>> >> - `(#:phases
>> >> + `(#:tests? #f; no tests
>> >
>> >Why? Because the tests are run during the build? If yes, does it
>make
>> >sense to move the comment there?
>>
>> No, the comment might have come from a previous version or just
>copied by mistake. There is really no test in this package (unless
>there's something weird going on with oasis scripts).
>
>Maybe reword the comment: "no test provided by the package"or
>something like that.
>
>
>All the best,
>simon
next prev parent reply other threads:[~2020-10-19 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 15:14 [bug#44032] [PATCH] gnu: ocaml: Update to 4.11.1 Julien Lepiller
2020-10-16 19:21 ` Brett Gilio
2020-10-19 13:31 ` zimoun
2020-10-19 14:11 ` Julien Lepiller
2020-10-19 14:24 ` zimoun
2020-10-19 15:14 ` Julien Lepiller [this message]
2020-11-10 15:07 ` bug#44032: " Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0736C245-79D4-4A6F-B79E-0D51A45F67DC@lepiller.eu \
--to=julien@lepiller.eu \
--cc=44032@debbugs.gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).