From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id KUlcAUccwmGNDAEAgWs5BA (envelope-from ) for ; Tue, 21 Dec 2021 19:26:15 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id +PucN0YcwmGHEgAAbx9fmQ (envelope-from ) for ; Tue, 21 Dec 2021 18:26:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A53B13F9D for ; Tue, 21 Dec 2021 19:26:14 +0100 (CET) Received: from localhost ([::1]:35490 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mzjq1-0003wF-T1 for larch@yhetil.org; Tue, 21 Dec 2021 13:26:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49734) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mzjps-0003w4-Bi for guix-patches@gnu.org; Tue, 21 Dec 2021 13:26:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44081) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mzjpq-0003hT-7f for guix-patches@gnu.org; Tue, 21 Dec 2021 13:26:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mzjpq-0000wr-5D for guix-patches@gnu.org; Tue, 21 Dec 2021 13:26:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#51838] [PATCH v5 07/45] guix: node-build-system: Add #:absent-dependencies argument. Resent-From: Philip McGrath Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Dec 2021 18:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51838 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Liliana Marie Prikler , Timothy Sample Cc: 51838@debbugs.gnu.org, Pierre Langlois , Jelle Licht Received: via spool by 51838-submit@debbugs.gnu.org id=B51838.16401111603637 (code B ref 51838); Tue, 21 Dec 2021 18:26:02 +0000 Received: (at 51838) by debbugs.gnu.org; 21 Dec 2021 18:26:00 +0000 Received: from localhost ([127.0.0.1]:55627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjpn-0000wa-Mm for submit@debbugs.gnu.org; Tue, 21 Dec 2021 13:25:59 -0500 Received: from mail-ua1-f48.google.com ([209.85.222.48]:44563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mzjpl-0000wL-AL for 51838@debbugs.gnu.org; Tue, 21 Dec 2021 13:25:58 -0500 Received: by mail-ua1-f48.google.com with SMTP id p2so25225327uad.11 for <51838@debbugs.gnu.org>; Tue, 21 Dec 2021 10:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philipmcgrath.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=dTmxBA++B6pklG7XMmC47sG7fKk2wKOPh3jETtwazuM=; b=kJaszOn+IHTONT6GXLIEwCWBVHLgad/jtoJXljIRRV/abM+8R4hF9PvKlEnODtvSnc Ydo7OLqJ368PK3/Vm6oE3Bd69Tf3XTWJkMLzASplM3YCstKRt0p6GYbrQYiaZNc+iJXt 3v/Uu8fZEQTk/qRiQ4Ia7VIe0N7fVbdd6G93FZQJ1VPrtt9ZnC7S3i5CMd2sLBY9NaKT EM/q+IaJz5ub30Ytw+yyms1R8hrg93gJ4iSVzFJcMeYBj3ZNwbsa6g30fdibZgNE3cpN H/mZ4FvI9vDBk+deJ8NpTukBdlDEBd8tpjsTvJMwWB0Xk4B5TlSeFDzqVAv3HpqUb4EW 4SuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dTmxBA++B6pklG7XMmC47sG7fKk2wKOPh3jETtwazuM=; b=E9JhPFndwgVHes0AnIoyqbBGXp+D4+Mks4Ke/K22x6gh66DQ16jtL23fwPttYuxbwn XoaKTucEf8gCdLdPnTpA/rkSeNA2vvBctArrTug4rGVzfE/XhTYyH3UX5ud7h5xE4jZu lhrBg0DLjT9rr8/7JcvEWkOQrctXIC7pMWFSz7ZSxfTBl86iiDe9/rYTdNOxy8G+5aKh S0Vm53LCr3Pic+Dh4ujGtvqzx9E2zb+CFCbrJszq4I2eL5CNT9eV3TPRv3cai88PTg8N InZazVJKwVH0myOpW/TSHDEYVdbTKvvfNjJVN+cH3Ar4XZ4O6W6eCDtCD8rHfN1PYKhn nC5A== X-Gm-Message-State: AOAM5304ZuHssb6Z8f6EBdIlJhbeonB+S3nP6Zv/ZznnzwT5rX8i4sHk sN7Ednosbx5aat6IDt4YC2+o5A== X-Google-Smtp-Source: ABdhPJxjUbZP/ND1SWuBjvK3x7juPwrEirZ8726rt3K5Yxl+fi5LASYO9F+30kPhhK8mlEQ3BZZWoA== X-Received: by 2002:ab0:449:: with SMTP id 67mr2012683uav.46.1640111151849; Tue, 21 Dec 2021 10:25:51 -0800 (PST) Received: from [192.168.45.37] (c-73-125-89-242.hsd1.fl.comcast.net. [73.125.89.242]) by smtp.gmail.com with ESMTPSA id m187sm1663948vke.8.2021.12.21.10.25.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Dec 2021 10:25:51 -0800 (PST) Message-ID: <06bf9af2-5c6c-54c1-1e2e-a652791a6747@philipmcgrath.com> Date: Tue, 21 Dec 2021 13:25:50 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.1 Content-Language: en-US References: <20211213060107.129223-1-philip@philipmcgrath.com> <20211217020325.520821-1-philip@philipmcgrath.com> <20211217020325.520821-8-philip@philipmcgrath.com> <87k0g36xp3.fsf@ngyro.com> <871r2a7hme.fsf@ngyro.com> <815f327e36ecd24066179586997947ecd8f31150.camel@gmail.com> <33696592-8a3a-8260-bf27-652cf78727a6@philipmcgrath.com> <2c803ea8f5c5c16c892f5528f63a4c7e98470c5b.camel@gmail.com> <314a0ea4-a851-6642-0a59-d4c61d65c242@philipmcgrath.com> <35164d79ab6ae1c0595d27f023376cf98ab1a39d.camel@gmail.com> <9533cfc8-b822-edc0-67ac-7e2c9aeacb09@philipmcgrath.com> <87r1a7118r.fsf@ngyro.com> <41461d4f-5e7d-d9be-51c4-7a58c4f7570f@philipmcgrath.com> From: Philip McGrath In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1640111174; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=dTmxBA++B6pklG7XMmC47sG7fKk2wKOPh3jETtwazuM=; b=kBTb5aDlOA820kwHGKLEPxeH9m3M9tPjIt0LI6AkNuuRHfBLNpgy8lkDBTQr9oJvdkvZTM gp+z6u2RNvWyMOZ34XVynwFi9XDs9ZBZO74FZmo5yGKncm8DxaiNTnSbAj3abqnSEpUKqG HE8FVDI7/zojlvRkmWH3vfbY4IOEoGs2E3MDLI1wL0rAa6jY89CA1f6B5HH/nUEhSL4uxj ZaF+rpdD9YeXkwiYwB+l/59rOLBfv17dijOboE6OTOwYjyFHRF9pEQh+uRS6DidVn8P57e AhLk5bu7V5yS/pltwvp0JteivGN9/5AFU7ZbfW/r+ur310QBXcRM80nRjarH+w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1640111174; a=rsa-sha256; cv=none; b=ITpETa6jSntOyuF9XU6d7qQnjZSIIjahP4C31GkSotuvv2JRBqJCL3MwOC/M53E6Ds7ekE HQdKMQUE1ktdefZBCjg/K8zgx0CNOUrJv5YHeFHmt9XaQrciiA1NjhQ9O/22t2lOeOVHQM KS1uazAaY1G78wBezXcsVucRiZTYe59epa7XzbHPJleTcOdfJMAjw7Dzb+jU0Q/HJX2knH lNCtpo4xJbMQ6o40/MsRod1VPE65gJ2PU/D+0YWTlG6OBxhDw05Pc8tqQ0W2oZTJnzAlzr h960tgN6e2it+T0BEEIfYkFRvZSQxv9/pXjLeEUQxRrM1LZxobw3xJAGmPdRmg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=kJaszOn+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -1.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=philipmcgrath.com header.s=google header.b=kJaszOn+; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: A53B13F9D X-Spam-Score: -1.83 X-Migadu-Scanner: scn0.migadu.com X-TUID: TsnR12JYV7jq Hi, On 12/21/21 00:20, Liliana Marie Prikler wrote: > Hi, > > excuse my brevity, but I'll be off to work soon. > > Am Montag, dem 20.12.2021 um 22:59 -0500 schrieb Philip McGrath: >> My reservation regarding: >> >>> >>> (add-after 'patch-dependencies 'drop-junk >>>    (lambda _ >>>      (with-atomic-json-replacement "package.json" >>>        (lambda (json) (delete-dependencies json '("node-tap")))))) >>> >> >> is that `with-atomic-json-replacement` would make (guix build json)'s >> representation a part of node-build-system's API, which it currently >> is not. For the reasons I detailed in my last email, I think that >> would open up a larger can of worms than it might seem. > That might be a valid concern, but I'd point to the "we don't > gratuitously change API" shield. Plus if we do, we'd replace our > current JSON by Guile-JSON. If that has a different internal > representation that would awfully break things, please do tell. Here are, to the best of my understanding, the differences in representation among (guix build json) and the three versions of guile-json packaged in Guix. (For guile-json, this is based on my relatively-quick reading of the docs, not any direct experience.) An extra complication is that some part of Guix's code staging seems to incorrectly turn #nil into '(). I will see if I can narrow that down and file a bug report. (guix build json): • object -> (Pairof '@ (Listof (Pairof String Json))) • array -> (Listof Json) • null -> #nil • string -> String guile-json-4: • object -> (Listof (Pairof (U Symbol Number String) Json)) • array -> (Vectorof Json) • null -> 'null ;; configurable by keyword argument • string -> (U Symbol String) guile-json-3: • object -> (Listof (Pairof (U Symbol Number String) Json)) • array -> (Vectorof Json) • null -> #nil • string -> (U Symbol String) guile-json-1: • object -> (U (HashTable (U Symbol String) Json) (Listof (Pairof (U Symbol String) Json))) • array -> (Listof Json) • null -> #nil • string -> (U Symbol String) -Philip