From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yL2YCe+rX2D0MQEAgWs5BA (envelope-from ) for ; Sat, 27 Mar 2021 23:04:31 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qGx4BO+rX2C8KgAAB5/wlQ (envelope-from ) for ; Sat, 27 Mar 2021 22:04:31 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8077324140 for ; Sat, 27 Mar 2021 23:04:30 +0100 (CET) Received: from localhost ([::1]:59854 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lQH2j-00075z-F5 for larch@yhetil.org; Sat, 27 Mar 2021 18:04:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49944) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lQH2J-00075g-9b for guix-patches@gnu.org; Sat, 27 Mar 2021 18:04:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:33564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lQH2I-0001cO-Ba for guix-patches@gnu.org; Sat, 27 Mar 2021 18:04:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lQH2I-0002fF-5p for guix-patches@gnu.org; Sat, 27 Mar 2021 18:04:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#44543] [PATCH] gnu: raspberry-pi: Add helpers for config.txt file generation. Resent-From: Stefan Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 27 Mar 2021 22:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44543 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: =?UTF-8?Q?L=C3=A9o?= Le Bouter Cc: Danny Milosavljevic , 44543@debbugs.gnu.org, Mathieu Othacehe Received: via spool by 44543-submit@debbugs.gnu.org id=B44543.161688260710195 (code B ref 44543); Sat, 27 Mar 2021 22:04:02 +0000 Received: (at 44543) by debbugs.gnu.org; 27 Mar 2021 22:03:27 +0000 Received: from localhost ([127.0.0.1]:45110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQH1i-0002eM-Uw for submit@debbugs.gnu.org; Sat, 27 Mar 2021 18:03:27 -0400 Received: from smtpout2.vodafonemail.de ([145.253.239.133]:33898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lQH1f-0002e9-RF for 44543@debbugs.gnu.org; Sat, 27 Mar 2021 18:03:26 -0400 Received: from smtp.vodafone.de (smtpa04.fra-mediabeam.com [10.2.0.35]) by smtpout2.vodafonemail.de (Postfix) with ESMTP id 6CF0C120CEF; Sat, 27 Mar 2021 23:03:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vodafonemail.de; s=vfde-smtpout-mb-15sep; t=1616882598; bh=vWs2JAuIUQGRE8PW4hZHSk7ZXRoAmeIwmmKRuA4IPQ0=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=NPedW1hXvEu+ft0NqosZ5xYamHBerX/M5/NPMOoYJI4f9vSoSnMFkHdKZ5Gmo6bN4 P1f1EbAFEOc7WX59SgB7W1u71bqKcR3MXusE2qzGblyDIu9tFFp4YYIMq2d5hGmwza sxgdagdAVrhzovhHHQiiwpBM+hTh2oEwt6+h/XJA= Received: from macbook-pro.kuh-wiese.my-router.de (ipservice-092-218-117-078.092.218.pools.vodafone-ip.de [92.218.117.78]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.vodafone.de (Postfix) with ESMTPSA id C0BFD14017C; Sat, 27 Mar 2021 22:03:15 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) From: Stefan In-Reply-To: <832c926ec211cab21f63ed9578c67662db7426cf.camel@zaclys.net> Date: Sat, 27 Mar 2021 23:03:15 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: <067A8489-6150-4632-878C-BB239B1674FD@vodafonemail.de> References: <20201116103231.2c151d33@scratchpost.org> <6C52CE60-8585-4FC4-BCBC-B901CB75B35F@vodafonemail.de> <20201116150108.26a2daa7@scratchpost.org> <422D2441-7132-4983-9EFF-E6C87120CCCB@vodafonemail.de> <9537F85E-03CA-4784-85BD-0637C7A16F31@vodafonemail.de> <832c926ec211cab21f63ed9578c67662db7426cf.camel@zaclys.net> X-Mailer: Apple Mail (2.3124) X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate: clean X-purgate-size: 2903 X-purgate-ID: 155817::1616882596-00004492-1A99838C/0/0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616882670; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=vWs2JAuIUQGRE8PW4hZHSk7ZXRoAmeIwmmKRuA4IPQ0=; b=DhtQPZ5BoAVxEJYYwznN8NcVaVkvwsrnikjR0oFBQTT7j8g+NHUtdUK8zJ0X2707amlrFP stUcU3lQmjDZISBFIW4aK49t0A3FXSYvCqGSuuYOU+vYpXCuJtGrCvCDDXVx6t2/ICtg33 ATesk2cwDyrhqQismzrru/byiJ3A+lQlT8MlQfPs36iqdWzFnV5G0+RwSmea/wMZkanEuz 4/S7EchAdyiBfQxU0/rU+HJFeYJl7hbBHVvfXDyNMYss1E62F3A+bOnMTljssUEFJSK87k 5aM1hsWjeYYmN0EBTikX9PkNJIVCG3WZB2dFODyBbukJKy0yeV/pERhl2dQvsA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616882670; a=rsa-sha256; cv=none; b=fmrUiqv/AcMtgRcpKRHZhnzDBOpWla8gXrM630ppTNhfnUlLS18buisJ1fnVVFsZwJDa/o qAZ1nXIMwsyEpF7YgX7HsOfuNmzNajB6D7HJWhTF8/LIT6A629aZIi1s1dRDU56j11zVwD Bjhr4hBzGTU0YhVKKJCP5Vz5wjgceQHn0Nf/KEt4IsomqMoqLcqdDPNxKcMXp4xk8e/bMm dsV08NJ69WswRWLkpsxqrPnsCnktz5acXJEfScwCWifsCc8dddHqO+cd7oUgQYbhs2Rxbs nv8VBiCUf8RUmZbbcH3zIGmwWKIiQ9j2wHtOPXxw5nAw9oJGkz2L6jilOEFNDw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=vodafonemail.de header.s=vfde-smtpout-mb-15sep header.b=NPedW1hX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -0.92 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=vodafonemail.de header.s=vfde-smtpout-mb-15sep header.b=NPedW1hX; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 8077324140 X-Spam-Score: -0.92 X-Migadu-Scanner: scn0.migadu.com X-TUID: bIi0ipTFF9Yf Hi L=C3=A9o! > I would prefer if you opened one single bug with all the changes so I > can test the whole thing, right now I don't feel at ease reviewing > things like this. I see. I=E2=80=99m doing little steps, sending patches for the parts = which I think are ready. > How can I be sure what you are submitting is the > right abstraction for your future work? True. In this case you only have the bootloader examples that I gave. This patch is just a building block to generate some config.txt in a = modular and comfortable way. There is a bootloader installer copying any = listed file-like-object. Who knows, in future there might be a TianoCore bootloader, then a = similar patch might be required to provide a = raspi-tianocore-bootloader-txt. > Are you sure that abstraction > will be right for your future patches? Yes. There are basically three decisions to take for a Guix System: 32 = or 64 bit, which device tree (depends on the linux kernel), which = bootloader. Beyond this anything is a custom setting.=20 > If anything needs to be changed > I feel like one big patchset about Raspberry Pi 3B+ support will be > easier to review (at least for me). I see, this is not yet testable for you out of the box to boot a system. What is testable right now is an incomplete bootloader. At least it is = possible to inspect what files will be generated by this patch and = copied into /boot. It must even be buildable for x86_64. (bootloader (bootloader-configuration (target "/boot") (bootloader (efi-bootloader-chain (list raspi-config-txt raspi-bcm27-dtb-txt raspi-u-boot-bootloader-txt) grub-efi-netboot-bootloader #:installer (chain-efi-bootloader-installer (install-grub-efi-netboot = "efi/boot"))))) Bye Stefan P.S. If you change your mind and want to test that bootloader, then you = should know that GRUB depends on qemu and unfortunately qemu is failing = its test on aarch64 since some months. Then this patch may help you get = going.=20 diff --git a/gnu/packages/virtualization.scm = b/gnu/packages/virtualization.scm index 2262aa6197..3732320df8 100644 --- a/gnu/packages/virtualization.scm +++ b/gnu/packages/virtualization.scm @@ -161,8 +161,9 @@ (arguments `(;; FIXME: Disable tests on i686 to work around ;; . - #:tests? ,(or (%current-target-system) - (not (string=3D? "i686-linux" (%current-system)))) + #:tests? ,(and (not (target-aarch64?)) + (or (%current-target-system) + (not (string=3D? "i686-linux" = (%current-system))))) =20 #:configure-flags (list "--enable-usb-redir" "--enable-opengl" "--enable-docs"