unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Marius Bakke <mbakke@fastmail.com>, dannym@scratchpost.org
Cc: 30748@debbugs.gnu.org
Subject: [bug#30748] [PATCH] gnu: Add nsd.
Date: Tue, 13 Mar 2018 03:06:59 +0100	[thread overview]
Message-ID: <060e32877fe59a249a93fc0751976ddc@tobias.gr> (raw)
In-Reply-To: <87lgf0jnlj.fsf@fastmail.com>

Marius,
Danny,

So...

On 2018-03-10 10:18, Marius Bakke wrote:
> Tobias Geerinckx-Rice <me@tobias.gr> writes:
> 
>> * gnu/packages/dns.scm (nsd): New public variable.
> 
> [...]
> 
>> +         (add-before 'configure 'patch-installation-paths
>> +           (lambda* (#:key outputs #:allow-other-keys)
>> +             (let* ((out (assoc-ref outputs "out"))
>> +                    (doc (string-append out "/share/doc/" ,name "-" 
>> ,version)))
>> +               (substitute* "Makefile.in"
>> +                 (((string-append ".*\\$\\(DESTDIR\\)\\$\\("
>> +                                  "(config|pid|xfr|db)dir"
>> +                                  "\\).*"))
>> +                  "")

It's just a Makefile being very stupid. How boring :-(

It tries to create run-time systemy things like `dirname $pidfile` (from 
#:configure-flags), which it has no business doing, so we ask it not to 
by politely shooting it in the head.

> Can you add a comment about what's going on here?

Sure. If anyone has a cleaner fix or regex to match I'll gladly take it, 
but I'm done staring at metamake. Otherwise a comment paraphrasing the 
above will have to do.

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.

  parent reply	other threads:[~2018-03-13  2:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08  8:20 [bug#30748] [PATCH] gnu: Add nsd Tobias Geerinckx-Rice
2018-03-10  9:18 ` Marius Bakke
2018-03-12 21:03   ` Danny Milosavljevic
2018-03-12 21:35     ` Tobias Geerinckx-Rice
2018-03-13  2:06   ` Tobias Geerinckx-Rice [this message]
2018-10-04 19:38 ` bug#30748: " Tobias Geerinckx-Rice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=060e32877fe59a249a93fc0751976ddc@tobias.gr \
    --to=me@tobias.gr \
    --cc=30748@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).