From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:1008:1e59::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id cA9YNztSoGVRngAAkFu2QA (envelope-from ) for ; Thu, 11 Jan 2024 21:40:27 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id AHt7MTtSoGV2KAEA62LTzQ (envelope-from ) for ; Thu, 11 Jan 2024 21:40:27 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=PSFH6qAV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1705005627; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=suYstArobkyqS5pXH0Hb7rUuKE/QeXEAMbCmEwuTWrw=; b=PHrJigy10qY79WP7n7Cc6ZQ9QNqW9Gig3uRn+qOdSl5nofbQHCcvZ/mBkS/9vWt+T0bHe4 +HuCZcmedvcrHY+SXNhoRcbT2zSaL9Ozg1gaw+bgACmFW0b83PmHZ/youeHGn8uZNTqFjA 3BK4TxRjBJ8772Pnk5Y1ibELDaiovkhv9YHWzv41jWv8L/xiKp7L6L1JQFhK/axL5wwP82 pj9ouNlIbSIu4s+trqWM4ChdhW22eac+nEuCGZ1J60SDR55IH0wVNlz79BGr9v30NhsUdV CF8HZZJDPJlq4URRS5pktOIzk2wn5DaFWS2Z/2OebeiGdMql4WAk5Gh47pf05A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=autistici.org header.s=stigmate header.b=PSFH6qAV; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=gnu.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1705005627; a=rsa-sha256; cv=none; b=TT9fanUXlq9EbFIV8Wyw+77/enJNY+6uhC63/xIx26e/kmii2Lxmp83T34AABm48tqdt5J qs31an5H97Qz6yuXgY2ir6FxEeA7KVb12EwYPDYmoxELcdgmiQuTZhvU8jPwmQ+aZQpRer NsDhVIQ8WVroHhc9/HZkGuU2dReA8ExW0U6q6Oi4Lbj6fZe8zrVi+y2Z4aHdqoSV+AL67y Uirxe24V8+9eeeQQkkgFt2jA/WtYph8qEH+DntWu2bPrXoi5eSya4chvricb8vBmnnh3XH EjMoiGP90VYI0Pa2qMGqsf9LuLedN0MfEGoz3m0v4HVB8igBbquotvp+nJE/fg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B784439C78 for ; Thu, 11 Jan 2024 21:40:27 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rO1qQ-0004Yp-Oh; Thu, 11 Jan 2024 15:40:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rO1qO-0004YG-S8 for guix-patches@gnu.org; Thu, 11 Jan 2024 15:40:04 -0500 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rO1qO-0005gS-JX for guix-patches@gnu.org; Thu, 11 Jan 2024 15:40:04 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rO1qL-0002iE-R9 for guix-patches@gnu.org; Thu, 11 Jan 2024 15:40:01 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#67613] Introduce unit tests for oci-container-service-type. Resent-From: paul Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 11 Jan 2024 20:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67613 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 67613@debbugs.gnu.org Received: via spool by 67613-submit@debbugs.gnu.org id=B67613.170500555210356 (code B ref 67613); Thu, 11 Jan 2024 20:40:01 +0000 Received: (at 67613) by debbugs.gnu.org; 11 Jan 2024 20:39:12 +0000 Received: from localhost ([127.0.0.1]:34032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO1pY-0002gy-86 for submit@debbugs.gnu.org; Thu, 11 Jan 2024 15:39:12 -0500 Received: from confino.investici.org ([93.190.126.19]:36917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rO1pU-0002gm-OI for 67613@debbugs.gnu.org; Thu, 11 Jan 2024 15:39:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=autistici.org; s=stigmate; t=1705005549; bh=suYstArobkyqS5pXH0Hb7rUuKE/QeXEAMbCmEwuTWrw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=PSFH6qAV+KSBinoeHMP6gr0sFM4CzJFvTfLkrt9K7hWw8PaSS1z0YZp9sTDoWUFO7 sFnyOuzoTIsBn7TQUlBorFAaf5WRi7fz0jsOHu1LCVtBjKc1+zH5eLEaHRWKlgLlpd ghgkP8OrG+cDi8ynb+D8LnBfI1TQLSVtheVm94Ns= Received: from mx1.investici.org (unknown [127.0.0.1]) by confino.investici.org (Postfix) with ESMTP id 4T9xNF1MLyz112x; Thu, 11 Jan 2024 20:39:09 +0000 (UTC) Received: from [93.190.126.19] (mx1.investici.org [93.190.126.19]) (Authenticated sender: goodoldpaul@autistici.org) by localhost (Postfix) with ESMTPSA id 4T9xNF0lCYz10w5; Thu, 11 Jan 2024 20:39:09 +0000 (UTC) Message-ID: <05d4f2f7-01ff-65d1-107f-f71b8e103de0@autistici.org> Date: Thu, 11 Jan 2024 21:39:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US References: <10a8cae4-a5a2-a2e0-fa64-95650ae2e703@autistici.org> <20231203215630.28144-1-goodoldpaul@autistici.org> <87lea13f3e.fsf_-_@gnu.org> <87wmtgtyy4.fsf@gnu.org> In-Reply-To: <87wmtgtyy4.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: paul X-ACL-Warn: , paul via Guix-patches From: paul via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -7.27 X-Spam-Score: -7.27 X-Migadu-Queue-Id: B784439C78 X-Migadu-Scanner: mx11.migadu.com X-TUID: 47GLmXMPUmSh Hi Ludo’ , I should have created a suitable system test for the oci-container-service-type. Thanks to a nice input from @graywolf@emacs.ch on mastodon, and actually to be able to run the test since the vm doesn't have internet access and can't pull OCI images, I implemented a new oci-image record that can be given some lowerable value that can be lowered to an OCI tarballed image and passed to the image field of the oci-container-configuration record. I'd like to point out two things: - It's the first time I use Guix internal API to build derivations, I took most of my implementation from other places around Guix and I hope is sound but I may have missed something. I'd like your feedback about it. - I was tempted to make the image field of the oci-container-configuration record directly only accept oci-image records (hence making the value field of oci-image optional) but that would break existing configurations. I'm not sure about the contract we have for configuration records API, should I wait 1.5.0 for this change? I'm sending an updated patchset, thank you for all your help and efforts. giacomo