unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: "Tobias Geerinckx-Rice" <me@tobias.gr>
To: Pierre Neidhardt <ambrevar@gmail.com>, 31488@debbugs.gnu.org
Subject: [bug#31488] [PATCH] gnu: git: Add "credential-netrc" output.
Date: Fri, 18 May 2018 12:50:53 +0000	[thread overview]
Message-ID: <05bf126b898739e7f24a31d6e0778853@tobias.gr> (raw)
In-Reply-To: <20180518092207.2457-1-ambrevar@gmail.com>

Pierre,

[Forgive my MUA's disdain for whitespace. I'm working on it.]

May 18, 2018 11:22 AM, "Pierre Neidhardt" <ambrevar@gmail.com> wrote:
> @@ -217,6 +218,8 @@ as well as the classic centralized workflow.")
> (("/bin/sh") (which "sh"))
> (("/usr/bin/perl") (which "perl"))
> (("/usr/bin/python") (which "python")))
> + (substitute* "contrib/credential/netrc/git-credential-netrc"
> + (("/usr/bin/perl") (which "perl")))
> #t))
> (add-after 'configure 'add-PM.stamp
> (lambda _

This phase is (still) called ‘patch-makefiles’. Could you tweak the name or move this to its own phase?

I've a preference for the latter, since it can then probably be moved before 'install-credential-netrc below to keep things together, but it's a slight one.

All that typed: is this even needed? It doesn't seem to be. The only mention of perl is the shebang, and those are already handled by the build system.

> @@ -271,6 +274,13 @@ as well as the classic centralized workflow.")
> (copy-file "contrib/completion/git-completion.bash"
> (string-append completions "/git"))
> #t)))
> + (add-after 'install 'install-credential-netrc
> + (lambda* (#:key outputs #:allow-other-keys)
> + (let* ((netrc (assoc-ref outputs "credential-netrc"))
> + (bin (string-append netrc "/bin")))
> + (mkdir-p bin)

INSTALL-FILE already implies MKDIR-P. That's one of its main features over COPY-FILE.

> + (install-file "contrib/credential/netrc/git-credential-netrc" bin)
> + #t)))
> (add-after 'install 'split
> (lambda* (#:key inputs outputs #:allow-other-keys)
> ;; Split the binaries to the various outputs.

I'll let others comment on the multiple outputs. I'm their resident fetishist, but not sufficiently informed to judge the ‘clutter’ vs. 48 KiB argument.

Sorry to reduce your work to a potential one-liner. The rest looks good to me. ;-)

Thanks!

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.

  reply	other threads:[~2018-05-18 12:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-18  9:22 [bug#31488] [PATCH] gnu: git: Add "credential-netrc" output Pierre Neidhardt
2018-05-18 12:50 ` Tobias Geerinckx-Rice [this message]
2018-05-18 13:24   ` Pierre Neidhardt
2018-05-18 13:25   ` Pierre Neidhardt
2018-06-16 16:19     ` Pierre Neidhardt
2018-05-18 13:05 ` Tobias Geerinckx-Rice
2018-06-22  9:48 ` bug#31488: " Gábor Boskovits

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05bf126b898739e7f24a31d6e0778853@tobias.gr \
    --to=me@tobias.gr \
    --cc=31488@debbugs.gnu.org \
    --cc=ambrevar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).