From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 4EzJMS3GqmAnRQEAgWs5BA (envelope-from ) for ; Sun, 23 May 2021 23:16:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id IDWCLS3GqmDZRQAA1q6Kng (envelope-from ) for ; Sun, 23 May 2021 21:16:29 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6F3A3120DC for ; Sun, 23 May 2021 23:16:29 +0200 (CEST) Received: from localhost ([::1]:34276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lkvSW-0001Rk-Hs for larch@yhetil.org; Sun, 23 May 2021 17:16:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57866) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lkvS7-0001JO-FM for guix-patches@gnu.org; Sun, 23 May 2021 17:16:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58546) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lkvS6-0008Pb-JN for guix-patches@gnu.org; Sun, 23 May 2021 17:16:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lkvS6-0007vJ-Es for guix-patches@gnu.org; Sun, 23 May 2021 17:16:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#46616] [PATCH] gnu: Add python-tldr. Resent-From: Vinicius Monego Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 23 May 2021 21:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46616 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tanguy Le Carrour Cc: 46616@debbugs.gnu.org Received: via spool by 46616-submit@debbugs.gnu.org id=B46616.162180454930428 (code B ref 46616); Sun, 23 May 2021 21:16:02 +0000 Received: (at 46616) by debbugs.gnu.org; 23 May 2021 21:15:49 +0000 Received: from localhost ([127.0.0.1]:41859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkvRt-0007ui-6y for submit@debbugs.gnu.org; Sun, 23 May 2021 17:15:49 -0400 Received: from mout02.posteo.de ([185.67.36.66]:33829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lkvRq-0007uT-EE for 46616@debbugs.gnu.org; Sun, 23 May 2021 17:15:48 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 16DEA2400E5 for <46616@debbugs.gnu.org>; Sun, 23 May 2021 23:15:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1621804540; bh=buBbN8bbYtTTsa+OOgHphv69gbiPZ4YidKe08ngwbYQ=; h=Subject:From:To:Cc:Date:From; b=brykV88gjKyReaSj6yQZmp2rPYorDbE2JIRvo1DWsaFZnMoq4mKY9iYklZmH7jNIG YPcyz1Nobon9vzuOu+JUREN7/ZyWx0NxUGvc5tni2b1E+ywj1k1kxOTsb9zXaBsmXP Qg5XFbvUZLVQniWAeWiTXJulSk+EWBp8lH9vW6aRer01pIdLDcxP38g8/6eeEusn6Z pssjh8+0puTOIakUoOWZMNP/x2MZphTDvqNMkzpJUNNh+dr1ZCzXkC2KM04ZWV+B4j hSnLCK/t8pI0O313LuCbpna87dB66ri06dxkCMbi0mm67YWjOpdkGhR4QjBHGJsmf2 fvFyjh0I6UAzQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4FpCmp2ZW5z9rxR; Sun, 23 May 2021 23:15:38 +0200 (CEST) Message-ID: <05b49dc60b6a7c24ffd269293b9f9536abda14f2.camel@posteo.net> From: Vinicius Monego Date: Sun, 23 May 2021 21:15:30 +0000 In-Reply-To: <20210218140620.15816-1-tanguy@bioneland.org> References: <20210218140620.15816-1-tanguy@bioneland.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621804589; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=buBbN8bbYtTTsa+OOgHphv69gbiPZ4YidKe08ngwbYQ=; b=qrudbRc1SSuktiT3WoqlfargpIatR+hbP6NURf5AJ3stE84YOTuP74p+Mjn/RaoPNr6fiZ YWOhFdHTgeQGuvxIw9yRW3njfpaVbo9xP8cEKyp8nlL9fcmpLGW7HB4Em5CFSuqDE2jW6v 3opbMgIKp2+k1NrgF+dUROquSbbxFoJssqFWBdR3VJ0XH5DpOyfCZZgS8PJT6SIo/tW82I GqBg259gA3lxdwDrq7wSpRwYwozve4ZUy2+Q8g3lqxK4+fWIdiUYzRtn5N1kSBj7sE64VR y/AG6iw/p140NabtHw2ZccgKickMuEMHLU8EqvJhJxZf7k9oGW6rYyt7UCBPUg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621804589; a=rsa-sha256; cv=none; b=K096aicAFy79fWzdRhL1TVp9oo/3xT+npnuWKm/g4arje5Q48taZYDguhLWwREf6iBNWbb t/p/VVgSTXb2ZpgV8BFrb9jvabId1O6e6KQXpepRIhzp3buap7yzqJIq84H9Pst6clz7Oh 4V0vXoIG8qZHRT1PIscnjM+LK6wJZP36SGnEtMOBdONwmMyIPy3bj51J2NitEZI29PZuTQ gZzlRSoho3mh/85e8d/eztQSqcW4D4ZoMPrppS0J4on1I5JMUohi3bHSV50NCqdhYJcI0k mpaytZu4Y0/fuDncIyVWvDeCylxJLlb/t+KbQO0MYMHpzEgdjdTBJdAXhzWYSQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=brykV88g; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=posteo.net header.s=2017 header.b=brykV88g; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: 6F3A3120DC X-Spam-Score: -1.34 X-Migadu-Scanner: scn1.migadu.com X-TUID: ey2/QG/MFx+4 Hi, Em qui, 2021-02-18 às 15:06 +0100, Tanguy Le Carrour escreveu: > * gnu/packages/python-xyz.scm (python-tldr): New variable. > --- >  gnu/packages/python-xyz.scm | 28 +++++++++++++++++++++++++++- [...] > +(define-public python-tldr > +  (package > +    (name "python-tldr") I noticed that this program is a command line tool. It should be named 'tldr' only and be moved to another file. Perhaps to man.scm? > +    (source > +      (origin > +        (method url-fetch) > +        (uri (pypi-uri "tldr" version)) > +        (sha256 > +         (base32 > +          "00h43xjrzrayy1gysvmql5kfabk2d8xraih68d41616brdvb1xvf")))) > +    (build-system python-build-system) > +    (native-inputs > +     `(("python-pytest" ,python-pytest) > +       ("python-pytest-runner" ,python-pytest-runner))) The tests for this one are not distributed in the PyPI release. Could you source from the homepage instead? There is one test that tries to open a network connection, it will have to be skipped. > +    (propagated-inputs > +     `(("python-argcomplete" ,python-argcomplete) > +       ("python-colorama" ,python-colorama) > +       ("python-termcolor" ,python-termcolor))) If it is only a command line tool, inputs should be normal inputs here. > +    (description "This package provides the `tldr' command allowing > users > +to view `tldr' pages from a shell.  The `tldr' pages are a community > effort > +to simplify the man pages with practical examples.") The linter made this complaint for the description: "use @code or similar ornament instead of quotes". LGTM otherwise. Could you make these changes and send a v2 with version 1.2.1? Vinicius