unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Leo Prikler <leo.prikler@student.tugraz.at>
To: Xinglu Chen <public@yoctocell.xyz>, 49090@debbugs.gnu.org
Subject: [bug#49090] [PATCH] gnu: Add blastem.
Date: Fri, 18 Jun 2021 21:15:31 +0200	[thread overview]
Message-ID: <05ad84f8282a8046aa5ce81699806d835b7af908.camel@student.tugraz.at> (raw)
In-Reply-To: <87sg1f586a.fsf@yoctocell.xyz>

Am Freitag, den 18.06.2021, 20:39 +0200 schrieb Xinglu Chen:
> On Fri, Jun 18 2021, Leo Prikler wrote:
> 
> > +(define-public blastem
> > +  (package
> > +    (name "blastem")
> > +    (version "0.6.2")
> > +    (source (origin
> > +              (method hg-fetch)
> > +              (uri (hg-reference
> > +                    (url "https://www.retrodev.com/repos/blastem")
> > +                    (changeset (string-append "v" version))))
> > +              (file-name (string-append name "-" version "-
> > checkout"))
> 
> Nit: (guix hg-download) provides a ‘hg-file-name’ procedure, so you
> can just use (hg-file-name name version).
Good to know, I simply used the hg-reference... expansion from
etc/snippets, so that should probably be updated.
> 
> > +              (sha256
> > +               (base32
> > +                "08ycfisivh9rb9vmijlrpdryaw8spd81ck48960p15cnf8h25
> > 35q"))
> > +              (modules '((guix build utils)))
> > +              (snippet
> > +               '(begin
> > +                  ;; TODO: Separately package and unbundle nuklear
> > +                  (delete-file-recursively "zlib")))))
> 
> Why is the zlib directory removed?  Or perhaps, why do they bundle
> their own Zlib?
The have their own PNG implementation, which appears different from
libpng.  So zlib exists as a dependency of that, but it's also
#included elsewhere.





  reply	other threads:[~2021-06-18 19:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18 14:59 [bug#49090] [PATCH] gnu: Add blastem Leo Prikler
2021-06-18 18:39 ` Xinglu Chen
2021-06-18 19:15   ` Leo Prikler [this message]
2021-06-19  8:30     ` Xinglu Chen
2021-06-26 20:48     ` Ludovic Courtès
2021-06-27  9:28       ` bug#49090: " Leo Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05ad84f8282a8046aa5ce81699806d835b7af908.camel@student.tugraz.at \
    --to=leo.prikler@student.tugraz.at \
    --cc=49090@debbugs.gnu.org \
    --cc=public@yoctocell.xyz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).