From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50479)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eajnR-0003F5-Mp
	for guix-patches@gnu.org; Sun, 14 Jan 2018 10:02:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eajnO-00019L-Ln
	for guix-patches@gnu.org; Sun, 14 Jan 2018 10:02:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48241)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eajnO-00018p-Be
	for guix-patches@gnu.org; Sun, 14 Jan 2018 10:02:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eajnN-0003RF-TB
	for guix-patches@gnu.org; Sun, 14 Jan 2018 10:02:01 -0500
Subject: [bug#29891] [PATCH] gnu: java-classpathx-servletapi: Update to
	3.0-r1244.
Resent-Message-ID: <handler.29891.B29891.151594210813196@debbugs.gnu.org>
References: <20180109105517.29578-1-boskovits@gmail.com>
	<CAE4v=phyc2osUtk5-+oHVeJ0+p3fo0FQ6oA+=-jyyBLg2OryOg@mail.gmail.com>
From: Tobias Geerinckx-Rice <me@tobias.gr>
Message-ID: <052c85c4-0370-35d3-17dd-66d5f2667592@tobias.gr>
Date: Sun, 14 Jan 2018 16:04:42 +0100
MIME-Version: 1.0
In-Reply-To: <CAE4v=phyc2osUtk5-+oHVeJ0+p3fo0FQ6oA+=-jyyBLg2OryOg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: boskovits@gmail.com, 29891@debbugs.gnu.org

Gábor,

Gábor Boskovits wrote on 09/01/18 at 11:56:
> Reworded commit message.

Sorry to be a drive-by nit-picker, but this commit message is still much
longer than needed:

> 2018-01-09 11:55 GMT+01:00 Gábor Boskovits <boskovits@gmail.com
> <mailto:boskovits@gmail.com>>:
> 
>     * gnu/packages/java.scm (java-classpathx-servletapi): Update to
>     3.0-r1244.
>     [source]: Change to svn-fetch from upstream. (This version is only
>     available from there)

That parenthesis should be far more useful to future generations as a
comment in the code.

>     [arguments]: Switch to a java8 compiler, remove comment about not
>     working with java8,

The first half implies the second: I'd not mention the comment.

>     add phase chdir to compensate for the different layout of the
>     upstream repository.

Also very verbose (just “Add ‘chdir’ phase.”?) but OK :-)

Kind regards,

T G-R