From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: gemmaro <gemmaro.dev@gmail.com>, 63206@debbugs.gnu.org
Subject: [bug#63206] [PATCH] gnu: gnushogi: Fix build.
Date: Thu, 04 May 2023 06:28:55 +0200 [thread overview]
Message-ID: <04aaff831d814d4288e945a5e37245d920a5a7a6.camel@gmail.com> (raw)
In-Reply-To: <483665ed2ac988be7e19c67fe28b9f9e5acf2a9e.1682952374.git.gemmaro.dev@gmail.com>
Hi gemmaro,
Am Montag, dem 01.05.2023 um 23:47 +0900 schrieb gemmaro:
> Hello,
>
> This patch fixes GNU Shogi build.
>
> Since the build is now successful, the actual gnushogi executable and
> documents are installed in addition to the COPYING file.
>
> Thanks,
> gemmaro.
When embedding letteresque communications in a commit, these should go
below the --- line before the diffstat, where git will happily ignore
them.
> * gnu/packages/games.scm (gnushogi): Set linker flag to build
> program.
> ---
> gnu/packages/games.scm | 42 +++++++++++++++++++++++++---------------
> --
> 1 file changed, 25 insertions(+), 17 deletions(-)
>
> diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
> index 3391c141e42..a36e2fe55bf 100644
> --- a/gnu/packages/games.scm
> +++ b/gnu/packages/games.scm
> @@ -76,6 +76,7 @@
> ;;; Copyright © 2022 Hendursaga <hendursaga@aol.com>
> ;;; Copyright © 2022 Parnikkapore <poomklao@yahoo.com>
> ;;; Copyright © 2023 Zheng Junjie <873216071@qq.com>
> +;;; Copyright © 2023 gemmaro <gemmaro.dev@gmail.com>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -2012,24 +2013,31 @@ (define-public gnubik
> (license license:gpl3+)))
>
> (define-public gnushogi
> - (package
> - (name "gnushogi")
> - (version "1.4.2")
> - (source
> - (origin
> - (method url-fetch)
> - (uri (string-append "mirror://gnu/gnushogi/gnushogi-"
> - version ".tar.gz"))
> - (sha256
> - (base32
> - "0a9bsl2nbnb138lq0h14jfc5xvz7hpb2bcsj4mjn6g1hcsl4ik0y"))))
> - (arguments `(#:tests? #f)) ;; No check target.
> - (build-system gnu-build-system)
> - (home-page "https://www.gnu.org/software/gnushogi/")
> - (synopsis "The game of Shogi (Japanese chess)")
> - (description "GNU Shogi is a program that plays the game Shogi
> (Japanese
> + (let ((ver "1.4.2")
> + (revision "2"))
There is no need to bump the revision, since the source remains
unchanged. We also prefer not to let-bind the base version.
> + (package
> + (name "gnushogi")
> + (version (string-append ver "-" revision))
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://gnu/gnushogi/gnushogi-
> " ver
> + ".tar.gz"))
> + (sha256
> + (base32
> +
> "0a9bsl2nbnb138lq0h14jfc5xvz7hpb2bcsj4mjn6g1hcsl4ik0y"))))
> + (arguments
> + `(#:phases (modify-phases %standard-phases
> + (add-before 'configure 'set-linker-flag
> + (lambda _
> + (setenv "LDFLAGS" "-z muldefs"))))
Since we're using gnu-build-system, can this by chance be achieved via
#:configure-flags or #:make-flags?
> + #:tests? #f)) ;No check target.
> + (build-system gnu-build-system)
> + (home-page "https://www.gnu.org/software/gnushogi/")
> + (synopsis "The game of Shogi (Japanese chess)")
> + (description
> + "GNU Shogi is a program that plays the game Shogi (Japanese
> Chess). It is similar to standard chess but this variant is far
> more complicated.")
> - (license license:gpl3+)))
> + (license license:gpl3+))))
Cheers
next prev parent reply other threads:[~2023-05-04 4:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-01 14:47 [bug#63206] [PATCH] gnu: gnushogi: Fix build gemmaro
2023-05-03 2:46 ` gemmaro
2023-05-04 4:28 ` Liliana Marie Prikler [this message]
2023-05-04 9:01 ` [bug#63206] [PATCH v2] " gemmaro
2023-06-11 11:13 ` [bug#63206] [PATCH v3] " gemmaro
2023-06-14 21:20 ` bug#63206: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04aaff831d814d4288e945a5e37245d920a5a7a6.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=63206@debbugs.gnu.org \
--cc=gemmaro.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).