From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UMPzFjYMa2CL+QAAgWs5BA (envelope-from ) for ; Mon, 05 Apr 2021 15:10:14 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id YDrhEDYMa2B/SgAA1q6Kng (envelope-from ) for ; Mon, 05 Apr 2021 13:10:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ACEB01D158 for ; Mon, 5 Apr 2021 15:10:13 +0200 (CEST) Received: from localhost ([::1]:56648 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lTOzc-0006Nm-Qt for larch@yhetil.org; Mon, 05 Apr 2021 09:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lTOzS-0006NR-PY for guix-patches@gnu.org; Mon, 05 Apr 2021 09:10:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lTOzS-0003GU-IU for guix-patches@gnu.org; Mon, 05 Apr 2021 09:10:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lTOzS-0003mL-AH for guix-patches@gnu.org; Mon, 05 Apr 2021 09:10:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#47540] [PATCH] gnu: Add prips. Resent-From: david larsson Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 05 Apr 2021 13:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47540 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxime Devos Cc: 47540@debbugs.gnu.org Received: via spool by 47540-submit@debbugs.gnu.org id=B47540.161762818214488 (code B ref 47540); Mon, 05 Apr 2021 13:10:02 +0000 Received: (at 47540) by debbugs.gnu.org; 5 Apr 2021 13:09:42 +0000 Received: from localhost ([127.0.0.1]:37283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTOz7-0003lc-O5 for submit@debbugs.gnu.org; Mon, 05 Apr 2021 09:09:42 -0400 Received: from server0.selfhosted.xyz ([217.64.149.7]:51162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lTOz4-0003lH-OS for 47540@debbugs.gnu.org; Mon, 05 Apr 2021 09:09:40 -0400 Received: from server0.selfhosted.xyz (localhost [127.0.0.1]) by server0.selfhosted.xyz (Postfix) with ESMTP id F11521CE6DAD; Mon, 5 Apr 2021 15:09:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=selfhosted.xyz; s=dkim; t=1617628170; bh=l1/a2yrJbZTExZYihAa00sYfy+nleHmrKsTq57sc97k=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LsB2HHTes364PqftWOOwZxQ0BPQiAtAL0dWeKT+r0WFCkQ/xBi8a1IiSvQH/v878v SGVkYjfkF1wmtGpZPPGHAOh+5bmVOOgCVoUtd+tsE/vO7InvWOfQ9xq+fIg0Cm0E+N doXh2vah0qJE2gYT/XHq950oEj5A6i15LCh/547+qf84qVXZxB9hvmAxMtyxgmtRTM KRD8EJs7N0R5S5R2EbVHIY6IjHhASUoxF0+baEwjG33/vkjH1lrQE2+JLx+Vj4/qfV 2BRWtsGwmmqFbMpzeV0BJQOxCr7HibMXriwPDZIIoeU/0yP0bqmgF9XTgUz3XC4a1y qYpYnG3GUKWrw== X-Fuglu-Suspect: 91ff8ee08b3746949a4f8a92afa0503b X-Fuglu-Spamstatus: NO Received: from webmail.selfhosted.xyz (office.selfhosted.xyz [192.168.1.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: mail@selfhosted.xyz) by server0.selfhosted.xyz (Postfix) with ESMTPSA; Mon, 5 Apr 2021 15:09:23 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 05 Apr 2021 15:09:23 +0200 From: david larsson In-Reply-To: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> References: <94325c646a58888160ed6548dc5f646629e8374d.camel@telenet.be> Message-ID: <04a8eb1efe98cd5ada24e870b39a3671@selfhosted.xyz> X-Sender: david.larsson@selfhosted.xyz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1617628214; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=l1/a2yrJbZTExZYihAa00sYfy+nleHmrKsTq57sc97k=; b=KFqIa3Pck+Zt9UYUlvdRgmlVWj741BzhZgShRWF7nmNJd0YW7RVsQjRC8MdT6VBjEHzq+g aFVe46mlaOVZRgto4h88BWRQ6Ht90iMqxsu3pGqfvQ8ImwZzUHFCV4elJv2Rn7Z3lFV2Gt Bw4il5vMeFZjCJu8S2gsck+lHdbwOZFvUh9UwylncBuspYTR5TNDeoG5DaIA78skxGikEf 588wf7ipDk9ivOiGlQiS94S2eGCO7giTilFdszgQvXSB5HbX+8Jiq8CisNMgZ0E8UBVsAP XGWf5fGS2PZx/02vU/Tqp9l6q2OaJbN0Et6E+EWHheqVLIonSXmI2H+aiQbG/w== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1617628214; a=rsa-sha256; cv=none; b=VrI49XLI741yUn87NHwO+jyXgYkpEEIqhX0TWnLsWmMOFzTl7k98wgOJ5iPCnAJAQLlVPN lE+0NF1tL6qBOXjQ9qb9+YvQ/iVjSqPEccD2HhjyYR01IrEm14oTgB9loZzjzEmS2m4rQ8 PIHwI9dtzGqzW+4B4WBJRcYMcRdu0OzS4UrEfO16l9HgHo7zU/IBgxOPZBcjS1XlFBC8GK +xkf+tFKRjwbidAOAj0vqOOlF+QSks5ivbvJ0IJFItNF0qXdOCh713tBmXo595Ps8tklH6 SQ3/oyS+udECZP/8ysJqIlYU4WJXI3q+C3r26pjzxvAOPtIgHtMjFXMg0gkfzA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=selfhosted.xyz header.s=dkim header.b=LsB2HHTe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=selfhosted.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Spam-Score: -1.34 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=selfhosted.xyz header.s=dkim header.b=LsB2HHTe; dmarc=fail reason="SPF not aligned (relaxed)" header.from=selfhosted.xyz (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Migadu-Queue-Id: ACEB01D158 X-Spam-Score: -1.34 X-Migadu-Scanner: scn0.migadu.com X-TUID: +9Is0LDFfmGD On 2021-04-01 21:44, Maxime Devos wrote: >> + (arguments >> + '(#:make-flags (list "CC=gcc") > > As "CC=gcc" is a constant, I would write '("CC=gcc") here, > though admittedly this is largely a matter of taste. > Another problem: when cross-compiling, "gcc" will be a > compiler for the build system, not the host system (assuming > I got the terminology right). Instead, write > > `(#:make-flags (list (string-append "CC" ,(cc-for-target))) > ...) > > (The quasiquote ` is important.) Fixed. >> + #:phases (modify-phases >> + %standard-phases > > %standard-phases shouldn't be on a separate line here. Fixed. > >> + (delete 'configure) >> + (delete 'check) > > Prips has some tests, so don't delete this phase. I tried to fix but this fails. > >> + (replace 'install >> + (lambda _ >> + (let* >> + ((bin-dir (string-append %output "/bin")) >> + (bin-file (string-append bin-dir >> "/prips"))) > > The ((bin-dir ...)) should be on the same line as 'let*'. > >> + (mkdir-p bin-dir) >> + (copy-file "prips" bin-file) >> + (chmod bin-file #o700))))))) > > Why are you making bin/prips writable? Shouldn't this be > (chmod bin-file #o600) instead? I don't know for sure why that happened, but it's fixed to #o600 now. >> + (synopsis "Tool that prints the IP addresses in a given range") >> + (description "Prips can be used to print all of the IP addresses >> in >> + a given range. This allows the enhancement of tools only work > > ‘Enhancement’ is rather vague and leaning towards marketing-speak. > I do not have an alternative suggestion however. This was an exact quote from website or something. >> + (license license:gpl2))) > > I looked at the source code and it seems prips is actually gpl2+. Fixed. > Greetings, > Maxime. Thanks for your review! This is what it looks like now, and failing the check phase: (define-public prips (package (name "prips") (version "1.1.1") (source (origin (method url-fetch) (uri (string-append "https://devel.ringlet.net/files/sys/" name "/" name "-" version ".tar.xz")) (sha256 (base32 "1a33vbl4w603mk6mm5r3vhk87fy3dfk5wdpch0yd3ncbkg3fmvqn")))) (build-system gnu-build-system) (arguments `(#:make-flags (list (string-append "CC=" ,(cc-for-target))) #:phases (modify-phases %standard-phases (delete 'configure) ;(delete 'check) (replace 'install (lambda _ (let* ((bin-dir (string-append %output "/bin")) (bin-file (string-append bin-dir "/prips"))) (mkdir-p bin-dir) (copy-file "prips" bin-file) (chmod bin-file #o600))))))) (synopsis "Tool that prints the IP addresses in a given range") (description "Prips can be used to print all of the IP addresses in a given range. This allows the enhancement of tools only work on one host at a time (e.g. whois).") (home-page "https://devel.ringlet.net/sysutils/prips/") (license license:gpl2+))) The logs: --------------- starting phase `check' make: *** No rule to make target 'check'. Stop. Test suite failed, dumping logs. command "make" "check" "-j" "2" "CC=gcc" failed with status 2 Best regards, David ---------------