unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: guix-patches--- via <guix-patches@gnu.org>
To: 73190@debbugs.gnu.org
Cc: "Nguyễn Gia Phong" <mcsinyx@disroot.org>,
	"Andreas Enge" <andreas@enge.fr>,
	"Ludovic Courtès" <ludo@gnu.org>
Subject: [bug#73190] [PATCH v2 2/3] gnu: make-libiberty: Build with -fPIC.
Date: Thu, 19 Sep 2024 16:38:38 +0900	[thread overview]
Message-ID: <046637012d1dd689b9ffe105a4c33f3eaa14ada7.1726731518.git.mcsinyx@disroot.org> (raw)
In-Reply-To: <ffbecfffc0f116a3225d69cd1ba40eadf38446d4.1726731518.git.mcsinyx@disroot.org>

Since iberty is a static library, linking a PIC-enabled target to it
requires it to also have been built with PIC.  (The target is Dyninst
in this case.)

This `-fPIC' flag is appended to the default CFLAGS of `-O2 -g'.

* gnu/packages/gcc.scm (make-libiberty)[arguments]:
  Adjust make-flags to add -fPIC to CFLAGS.

Change-Id: I155045d05f4434cb68be933a95b7bc9fdec98818
---
 gnu/packages/gcc.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/gcc.scm b/gnu/packages/gcc.scm
index 164c8d782ca3..7fceb4be963f 100644
--- a/gnu/packages/gcc.scm
+++ b/gnu/packages/gcc.scm
@@ -1065,6 +1065,7 @@ (define (make-libiberty gcc)
     (name "libiberty")
     (arguments
      `(#:out-of-source? #t
+       #:make-flags '("CFLAGS=-O2 -g -fPIC")
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'chdir
-- 
2.46.0





  reply	other threads:[~2024-09-19  7:41 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-12  2:25 [bug#73190] [PATCH 0/3] gnu: dyninst: Update to 13.0.0 guix-patches--- via
2024-09-12  2:28 ` [bug#73190] [PATCH 1/3] gnu: make-libiberty: Install the header demangle.h guix-patches--- via
2024-09-12  2:28 ` [bug#73190] [PATCH 2/3] gnu: make-libiberty: Build with -fPIC guix-patches--- via
2024-09-12 17:00   ` Ludovic Courtès
2024-09-12  2:28 ` [bug#73190] [PATCH 3/3] gnu: dyninst: Update to 13.0.0 guix-patches--- via
2024-09-19  7:38 ` [bug#73190] [PATCH v2 1/3] gnu: make-libiberty: Install the header demangle.h guix-patches--- via
2024-09-19  7:38   ` guix-patches--- via [this message]
2024-09-19  7:38   ` [bug#73190] [PATCH v2 3/3] gnu: dyninst: Update to 13.0.0 guix-patches--- via
2024-09-19 12:56     ` bug#73190: " Ludovic Courtès
2024-09-20  0:43       ` [bug#73190] " guix-patches--- via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=046637012d1dd689b9ffe105a4c33f3eaa14ada7.1726731518.git.mcsinyx@disroot.org \
    --to=guix-patches@gnu.org \
    --cc=73190@debbugs.gnu.org \
    --cc=andreas@enge.fr \
    --cc=ludo@gnu.org \
    --cc=mcsinyx@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).