From: Liliana Marie Prikler <liliana.prikler@gmail.com>
To: "Sören Tempel" <soeren@soeren-tempel.net>
Cc: julien@lepiller.eu, 71925@debbugs.gnu.org
Subject: [bug#71925] [PATCH 2/2] gnu: klee: Build with klee-uclibc support.
Date: Sun, 07 Jul 2024 14:51:02 +0200 [thread overview]
Message-ID: <03ef8e192f61f68529f3ce252f8564e4d16adf22.camel@gmail.com> (raw)
In-Reply-To: <2XB2CJ5QYV5K9.2OYVJ6R77DM9T@8pit.net>
Am Sonntag, dem 07.07.2024 um 13:24 +0200 schrieb Sören Tempel:
> Hi Liliana,
>
> Thanks a lot for the quick feedback, responses below.
>
> Liliana Marie Prikler <liliana.prikler@gmail.com> wrote:
> > The leading colon is pointless here, since you're doing an "="
> > assign.
>
> Good catch! I can fix this in a patch revision.
>
> > More importantly, can we make this a search path?
>
> I don't think so as it's not a colon separated search path, it can
> only point to a single directory; hence, I assumed that wrap-program
> is more appropriate here.
Fair enough.
> > Can we use search-input-file for this and dirname our way up?
>
> The input file that we are looking for here is called libc.a, I am
> not
> sure what the benefit of using search-input-file is, but I personally
> think something along the lines of `(dirname (search-input-file
> %build-inputs "/lib/libc.a"))` is less readable then `#$klee-uclibc`
> but I can definitely change this if you want me to :)
>
> > Is this only distributed as an .a file or could we make a .so out
> > of it?
>
> This is only distributed as a .a, not as a shared object. In fact,
> KLEE also doesn't not link against this library at all and instead
> converts it to an LLVM .bca file (shipped in
> /lib/klee/runtime/klee-uclibc.bca)
> during build. This file is then used directly by KLEE's symbolic LLVM
> interpreter to execute code utilizing libc functions. Hence, klee-
> uclibc is also not a propagated input for the klee package.
>
> Let me know if I should send a revision, would love to get this
> merged.
Can we make it so that it uses the file directly instead of inferring
the name? Then we could install klee-uclibc to, say
"/lib/klee/uclibc.a" and reference it in this build by said file name.
Cheers
next prev parent reply other threads:[~2024-07-07 13:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-03 19:03 [bug#71925] [PATCH 0/2] Add klee-uclibc soeren
2024-07-03 19:09 ` [bug#71925] [PATCH 1/2] gnu: " soeren
2024-07-06 18:50 ` Liliana Marie Prikler
2024-07-03 19:09 ` [bug#71925] [PATCH 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-06 18:49 ` Liliana Marie Prikler
2024-07-07 11:24 ` Sören Tempel
2024-07-07 12:51 ` Liliana Marie Prikler [this message]
2024-07-07 16:50 ` Sören Tempel
2024-07-07 16:53 ` Liliana Marie Prikler
2024-07-07 17:28 ` Sören Tempel
2024-07-07 18:27 ` Liliana Marie Prikler
2024-07-07 19:18 ` Sören Tempel
2024-07-07 17:26 ` [bug#71925] [PATCH v2 1/2] gnu: Add klee-uclibc soeren
2024-07-07 17:26 ` [bug#71925] [PATCH v2 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-07 19:19 ` [bug#71925] [PATCH v3 1/2] gnu: Add klee-uclibc soeren
2024-07-07 19:19 ` [bug#71925] [PATCH v3 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-08 7:44 ` [bug#71925] [PATCH v4 1/2] gnu: Add klee-uclibc soeren
2024-07-08 7:44 ` [bug#71925] [PATCH v4 2/2] gnu: klee: Build with klee-uclibc support soeren
2024-07-08 8:47 ` [bug#71925] [PATCH 0/2] Add klee-uclibc Sören Tempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ef8e192f61f68529f3ce252f8564e4d16adf22.camel@gmail.com \
--to=liliana.prikler@gmail.com \
--cc=71925@debbugs.gnu.org \
--cc=julien@lepiller.eu \
--cc=soeren@soeren-tempel.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).