From: Raghav Gururajan via Guix-patches via <guix-patches@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 48394-done@debbugs.gnu.org
Subject: bug#48394: [PATCH] gnu: Add cawbird.
Date: Fri, 14 May 2021 00:21:16 -0400 [thread overview]
Message-ID: <03968187-e896-0e98-b2d0-d1f94065ab59@raghavgururajan.name> (raw)
In-Reply-To: <87sg2q6l0g.fsf_-_@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]
Hi Maxim,
> I found that weird to put the secret key only base64-encoded here, but
> that seems to be how it is intended for the "default key":
> https://github.com/IBBoard/cawbird/commit/9f0f3201ce866a8ad06f8ec4642790182642bb72.
> Weird also that it wants it at build time rather than at run time, but
> hey.
ikr. There is an alternative option for per-user key and secret as
mentioned here (https://github.com/IBBoard/cawbird#preparation), but
that would uniquely identify each user.
> Perhaps: "Cawbird is a Twitter client that uses the GTK+ toolkit." ?
>
>> +the main twitter features.")
> ^
> Twitter
>
> I'd expand a bit on what some of these main features might be (text
> messages, sharing photos, ?).
>
> I haven't tested, but after my above comments, if it passes 'guix lint',
> builds and runs, LGTM.
Made the suggested changes and pushed as
100281dd200d0a59958fb17dc6de75d3913e2b7a.
Thanks!
Regards,
RG.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
prev parent reply other threads:[~2021-05-14 4:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 4:31 [bug#48394] [PATCH] gnu: Add cawbird Raghav Gururajan via Guix-patches via
2021-05-13 22:08 ` [bug#48394] [PATCH v2] " Raghav Gururajan via Guix-patches via
2021-05-14 3:40 ` [bug#48394] [PATCH] " Maxim Cournoyer
2021-05-14 4:21 ` Raghav Gururajan via Guix-patches via [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03968187-e896-0e98-b2d0-d1f94065ab59@raghavgururajan.name \
--to=guix-patches@gnu.org \
--cc=48394-done@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
--cc=rg@raghavgururajan.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).