From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id aNFsLKm48GMoKQEAbAwnHQ (envelope-from ) for ; Sat, 18 Feb 2023 12:38:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id aKo0LKm48GNWdQEAauVa8A (envelope-from ) for ; Sat, 18 Feb 2023 12:38:17 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1D30A9A8A for ; Sat, 18 Feb 2023 12:38:17 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTLXZ-0001Om-9B; Sat, 18 Feb 2023 06:38:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTLXX-0001OY-AT for guix-patches@gnu.org; Sat, 18 Feb 2023 06:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTLXW-0000RU-RR for guix-patches@gnu.org; Sat, 18 Feb 2023 06:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTLXW-00011y-Ic for guix-patches@gnu.org; Sat, 18 Feb 2023 06:38:02 -0500 X-Loop: help-debbugs@gnu.org Subject: [bug#59355] [PATCH] gnu: Add dataparksearch. Resent-From: Adam Faiz Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 18 Feb 2023 11:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59355 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tobias Geerinckx-Rice Cc: 59355@debbugs.gnu.org Received: via spool by 59355-submit@debbugs.gnu.org id=B59355.16767202593931 (code B ref 59355); Sat, 18 Feb 2023 11:38:02 +0000 Received: (at 59355) by debbugs.gnu.org; 18 Feb 2023 11:37:39 +0000 Received: from localhost ([127.0.0.1]:42655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTLX8-00011K-GA for submit@debbugs.gnu.org; Sat, 18 Feb 2023 06:37:38 -0500 Received: from knopi.disroot.org ([178.21.23.139]:57942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTLX5-000118-4x for 59355@debbugs.gnu.org; Sat, 18 Feb 2023 06:37:37 -0500 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B47D644543; Sat, 18 Feb 2023 12:37:33 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XqTj8HpgKge0; Sat, 18 Feb 2023 12:37:32 +0100 (CET) Message-ID: <036888fe-5347-755f-1ae3-121197d828c2@disroot.org> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1676720252; bh=UA+GF2xNfplLjgUqMwC4ZrmcEH6Vr+g1Oljbl9jCy7Q=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=KFyjRoGa9PS7Og9gB7x9LGRKVPku6IfoF5W/+Ev6UJ7r42bd1Efi7M/iAfrBtPbfJ X/AGkVP1fOi0igBf7VGsqfE+3GLHcsBzUgcVjCMbADG+zDoUFMjaoUnsGiG1HXLtzy h+qTQzoQWH3ZORrqzFKQnXi3cEXkD89ipU+BaNVjaQUMPOCFxARgQlR9Cc3pW9WNHb 3Qch5Qt8VvDdlQ3vdCl74ViYE66LJ4St2h5qvzMge95ELSJ4jLClePVwErS1T/SMKf zE+mpUzpN4HPtxZkWlVrMIV738ROsP6vjLAxF5GjJ4JHymLMWIkdyqI7I44ZfRuy0t dy17q0k+Ay6Ag== Date: Sat, 18 Feb 2023 19:37:27 +0800 MIME-Version: 1.0 References: <9ff6c39e-933b-d16e-3e3f-ad62c4a09f54@disroot.org> <87y1ovbvfd.fsf@nckx> Content-Language: en-US In-Reply-To: <87y1ovbvfd.fsf@nckx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Adam Faiz X-ACL-Warn: , Adam Faiz via Guix-patches From: Adam Faiz via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676720297; a=rsa-sha256; cv=none; b=brBWH1MJn8KELK91+hLGfzZHYaAp10pXOZM63Hw/8wWTxS2h5gEZmJfBA7lWT2w0EpFAQw +qnEhMgcUUylqME6R4TInDycWfTDMEpVs7XntB27ywVseSkbwB+BXngTj5TgR4khlKcTes OswcGvFik2yuf6o01aQ8qfUn6HgCLWpxAtXWy3vVAlkP23zkkhphbQORl67r/hlRKiVXel 9eMXhUTbhC3iKBsjgtq3P154/zsfqMwP17/w+RTiwH1SdjCTUdugJ8xKTZOEeo5Tur4wGN L9kzKXDRJSuGkPOArwfxj4bSniC+XTLAJJpYiZmqDEUNLF0SSyAis7436t4/1Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=KFyjRoGa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676720297; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=mLuKVG3DfuYjXQXWELncpeE2ngxBYeltE/IuyUXmMfc=; b=i5rS2cav1DCZjm5ymRz3Kdwc9Fza73YnDigU9WAkyfBD5SM7b/J2OaJmU0J3l2v5v4QUOr x/OhoFcDUbTag6xnAGqDfsIsqv1TFmmXIocyAkmkn5VJNn38JEqKcvY5FPzEMT7RDHeyq7 KzkQwWzOVn8JK0m+Vzcey/0xRi0yoZ2CShEIYK1QZR8RTVjZY3vtYBIPopT9+jUMtnsyB1 UYw1Nc+2nX7VanUE4Ds8RP0hRZ4TWIq+EgLkhSqJDCbdkeMlBuO/2DAH0KaYttA1iO74qB Nuex16sKuTsSVU1tnkTi8XqJBDdqboaliVpVeNxhHa9ZTFtKz0PW7ws4y+/cZw== X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=disroot.org header.s=mail header.b=KFyjRoGa; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -2.13 X-Spam-Score: -2.13 X-Migadu-Queue-Id: 1D30A9A8A X-TUID: k2qc+ZNP7wyp On 2/18/23 08:13, Tobias Geerinckx-Rice wrote: > Hi Adam, > > Adam Faiz via Guix-patches via 写道： >> * gnu/packages/search.scm (dataparksearch): New variable. > > Thanks!  I've applied the patch locally but stopped short of pushing.  I > have several questions and [notes]: > >> +(define-public dataparksearch >> +  (package >> +    (name "dataparksearch") >> +    (version "4.54-2016-12-03") > > I don't think this tag is anything special compared to other commits. > Is it? > > There are many more recent commits, up to 2022.  If the argument is > ‘4.53 is ancient’ (it is!), should we just package the latest commit? > Would the latest release (4.53) instead still be useful today? Not really, I think it's best to package the latest commit. >> +    (source (origin >> +              (method git-fetch) >> +              (uri (git-reference >> +                    (url "https://github.com/Maxime2/dataparksearch") >> +                    (commit version))) >> +              (sha256 >> +               (base32 >> "1g5kxw2d8jbc1h9yyy0xpnd3gkscj5a32k6hk3brvdwcbsnjbgyg")) >> +              (modules '((guix build utils))) >> +              (snippet >> +               #~(begin >> +                   (for-each delete-file-recursively '("config.sub" >> + "config.guess" >> + "configure" > > [All checked into Git.  Nice.  This snippet is ‘ugly’ because it > addresses an ugly problem.  I think I'll keep it but add an apologetic > comment.] Sure. >> + "Makefile.in" >> + "missing" >> + "depcomp" >> + "ltmain.sh" >> + "compile" >> +                                                       )))) > > [We don't dangle brackets like this but keep them on the previous line.] I dangled the brackets because I can't keep track of the brackets when I was working on the package. It's about time I try out paredit or some solution that colours each bracket. >> +              (file-name (git-file-name name version)))) >> +    (build-system gnu-build-system) >> +    (native-inputs >> +     (list pkg-config automake autoconf libtool openjade)) >> +    (inputs >> +     (list mbedtls-apache zlib postgresql aspell c-ares libextractor > [For consistency with other packages, I've moved the …inputs below the > arguments field.] Alright, my logic was to specify the inputs used before running the build commands since that's the normal flow for a packager. > >> +     (list #:configure-flags >> +           #~(list "--disable-syslog" > > Is this not useful?  If not, could you provide a short comment > explaining why? It's useful for people who use syslog, but syslog itself is suboptimal for its purpose. More info can be found here: http://skarnet.org/software/s6/s6-log.html#diesyslogdiedie Since the Shepherd (and other init systems) can keep the log output of the services it supervises, I was hoping that could be used instead. >> +                   "--with-gnu-ld" > > And here? That's unnecessary, I just wanted to try it out for fun. > >> +               (add-before 'bootstrap 'fix-configure >> +                 (lambda _ >> +                   (substitute* "configure.ac" >> +                     (("MY_DIRS=\"/usr/local/include") >> +                      (string-append "MY_DIRS=\"" >> #$(this-package-input "aspell") "/include")) >> +                     (("MY_DIRS=\"/usr/lib") >> +                      (string-append "MY_DIRS=\"" >> #$(this-package-input "aspell") "/lib")))))))) > > Why not use --with-aspell=… as you did for Postgres? It's not available in 4.53, which is another reason why the latest commit should be used. >> +    (license license:gpl3+))) > > Why GPL3+? It was a mistake. > [I was unable to get this package to build reproducibly, although I > tried only disabling #:parallel-build?.] I'll send an updated patch which fixes the issues you mentioned. > Kind regards, > > T G-R