Subject: [PATCH] Fix DumpRenderTree linking. DumpRenderTree compiles OK, but fails on a linking stage with the bellow error. I found the very same fix for openjfx-8 FreeBSD ports as well. Let's ignore undefined references for now. CMakeFiles/DumpRenderTreeJava.dir/__/TestRunner.cpp.o:TestRunner.cpp:function TestRunner::runUIScript(OpaqueJSContext const*, OpaqueJSString*, OpaqueJSValue const*): error: undefined reference to 'WTF::String::String(unsigned short const*, unsigned int)' CMakeFiles/DumpRenderTreeJava.dir/__/__/TestRunnerShared/UIScriptContext/UIScriptContext.cpp.o:UIScriptContext.cpp:function WTR::UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback(): error: undefined reference to 'WTF::String::String(unsigned short const*, unsigned int)' collect2: error: ld returned 1 exit status --- .../src/main/native/Tools/DumpRenderTree/java/CMakeLists.txt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/modules/web/src/main/native/Tools/DumpRenderTree/java/CMakeLists.txt b/modules/web/src/main/native/Tools/DumpRenderTree/java/CMakeLists.txt index e2ce5ef..2ad3db7 100644 --- a/modules/web/src/main/native/Tools/DumpRenderTree/java/CMakeLists.txt +++ b/modules/web/src/main/native/Tools/DumpRenderTree/java/CMakeLists.txt @@ -72,9 +72,5 @@ add_library(DumpRenderTreeJava SHARED ${DumpRenderTree_SOURCES}) add_definitions(-DWEBCORE_EXPORT=WTF_IMPORT -DWEBCORE_TESTSUPPORT_EXPORT=WTF_IMPORT) add_dependencies(DumpRenderTreeJava DumpRenderTreeBindings) -if (UNIX AND NOT APPLE) - set_target_properties(DumpRenderTreeJava PROPERTIES LINK_FLAGS "-Wl,--no-undefined") -endif () - set_target_properties(DumpRenderTreeJava PROPERTIES OUTPUT_NAME "DumpRenderTreeJava") target_link_libraries(DumpRenderTreeJava ${DumpRenderTree_LIBRARIES}) -- 2.26.2