unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Bruno Victal <mirai@makinata.eu>
To: Ethan Blanton <elb@kb8ojh.net>
Cc: 61023@debbugs.gnu.org
Subject: [bug#61023] [PATCH] package the jed editor
Date: Mon, 23 Jan 2023 14:19:44 +0000	[thread overview]
Message-ID: <01a75079-fa31-ab16-1dbf-9211082026c3@makinata.eu> (raw)
In-Reply-To: <Y83rjpZ/5n3Hvi0E@colt.lan>

Hi,

On 2023-01-23 02:06, Ethan Blanton via Guix-patches via wrote:
> +   (build-system gnu-build-system)
> +   (arguments (list #:configure-flags
> +                    #~(list (string-append "--with-slang="
> +                                           #$(this-package-input "slang")))
> +                    #:tests? #f))
You should comment the reason for disabling the tests.


Additionally, the commit should be in ChangeLog format [1], you can look
at the Guix commit logs to see what they look like.


[1]: https://www.gnu.org/prep/standards/standards.html#Change-Logs


Cheers,
Bruno





  reply	other threads:[~2023-01-23 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23  2:06 [bug#61023] [PATCH] package the jed editor Ethan Blanton via Guix-patches via
2023-01-23 14:19 ` Bruno Victal [this message]
2023-01-23 15:07   ` [bug#61023] [PATCH] gnu: Add " Ethan Blanton via Guix-patches via
2023-01-27 15:50     ` bug#61023: [PATCH] package " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01a75079-fa31-ab16-1dbf-9211082026c3@makinata.eu \
    --to=mirai@makinata.eu \
    --cc=61023@debbugs.gnu.org \
    --cc=elb@kb8ojh.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).