From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id mGlOCkhaDWevHwAA62LTzQ:P1 (envelope-from ) for ; Mon, 14 Oct 2024 17:52:08 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id mGlOCkhaDWevHwAA62LTzQ (envelope-from ) for ; Mon, 14 Oct 2024 19:52:08 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=gkxW9bS+; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="RaQ7j1e/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728928328; a=rsa-sha256; cv=none; b=AnH0Z13EdUEb0hP8C55ZLNqBsLLumiE8Cdydk5OVaUUU8dM4XAPvjBQoUZLpTZaN7zhK7c TuSCkh3h3JBApWECvWBHv2IfBoJURLeYf7pJB/ci9Y0awVirFDNYzpCo2XUsyTloZ2Le4B zJHTkKflZunYVgz7ArG0ylXS7Xx2PxMePYa7PWdUQ/Fa4hmXI1GzJ/DBxcq2Ov5BtLT8yX VgUlwJ7nuoL9+MvqHy2CYApaBVDZ6kbaeVIJJw8PIl00XbBcyqbDt3gNL6tzrQv64FxE/O +/1SdHpdFSJsHdSa2ixBE7a4f2sHPkco05FEoJ+x92mAQ+RrJNThzp+Qu9h8Ng== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=gkxW9bS+; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b="RaQ7j1e/"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728928328; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=LDf00oRTKrY7T+oZW3KhjdNBvWUbTZ18VyNxiHADh9Q=; b=KVF8ghbffIpiPJ1ttGEMvvTjyH/tGy9zghkTqkz5DJsPLU/tbY/LFga81+VhsqrLGnMELR fAfaDwvF/+mO9Df88z7oH5e+VQuDynU4DwbkG/u1cj9sCbk1jeORKDmi/QaypZEdMeOnDh PFl1LliIbMeSsdLXjGuAi9SoDg4+nYWRrGu9BHzQKnFXtKnQjXy3frwiAcPgEWVonxlyzs Ou2liWUn01kP4KMARy6kZhf3psAwic962tVrqU/1APf3Z0CJX/BdK24Fv+raxG1WOXdewr PzvrpCcjGrgWc7V9cRYisjXlu2eB1dr2lq9wCFlzU0EnmVMwbRiQdy3nFwXLIA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id E47C63DE8 for ; Mon, 14 Oct 2024 19:52:07 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0PER-0006rQ-Om; Mon, 14 Oct 2024 13:51:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0PEQ-0006r5-3U for guix-patches@gnu.org; Mon, 14 Oct 2024 13:51:46 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0PEP-0001yP-RS for guix-patches@gnu.org; Mon, 14 Oct 2024 13:51:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=LDf00oRTKrY7T+oZW3KhjdNBvWUbTZ18VyNxiHADh9Q=; b=gkxW9bS+D6UPmJrdDvQIv+4ccWPoi8vwvsYDHDdGq7IsXEop6j4XhcQS6Jcow0eJk62rTnxnl+iybfGDIVdLlxCUerT38tSbue291XNc/bJ9o9DTQ9I0YR25TkFTVb1GT+xWrBf6lnRZyrw6ZERE4WrY1mBuqY65hAnl+InXekq0gaCdPCOmGoI0lydfR+qeRi4XCGs1oBQWxd/4JAg2owBfS2xhV6sXKgWywALe1UImZFSoZJ+IJJCZ7eMKtv07Tj7EJCGSYm9uSBRnbNlV1O3vu+ELu/zryfEreisfqQ2I/QRoLcPfHDrbcNC19Y1ATJcNrN6vL9+kWDRVD37tkg==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0PEg-000522-Rc for guix-patches@gnu.org; Mon, 14 Oct 2024 13:52:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#73804] [PATCH] gnu: qqc2-desktop-style: Add kcolorscheme as an input. Resent-From: aurtzy Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 14 Oct 2024 17:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73804 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 73804@debbugs.gnu.org Cc: aurtzy X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.172892826119149 (code B ref -1); Mon, 14 Oct 2024 17:52:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Oct 2024 17:51:01 +0000 Received: from localhost ([127.0.0.1]:44031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0PDg-0004yg-Ou for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:51:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:41520) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0PDf-0004yX-1B for submit@debbugs.gnu.org; Mon, 14 Oct 2024 13:50:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0PDM-0006PP-Vx for guix-patches@gnu.org; Mon, 14 Oct 2024 13:50:41 -0400 Received: from mail-io1-xd31.google.com ([2607:f8b0:4864:20::d31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0PDK-0001ri-3X for guix-patches@gnu.org; Mon, 14 Oct 2024 13:50:40 -0400 Received: by mail-io1-xd31.google.com with SMTP id ca18e2360f4ac-835496c8d6fso267210539f.0 for ; Mon, 14 Oct 2024 10:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728928234; x=1729533034; darn=gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=LDf00oRTKrY7T+oZW3KhjdNBvWUbTZ18VyNxiHADh9Q=; b=RaQ7j1e/eN3nvJ6lsG7frLdFm0glR6FMYj0cl2SqPicZThsO4+VNqT02i+KngNlrhN uGiBWqXiNObUvbfOcMMMeYUS03aUZNCqVkvddE35pEGR7buDylnDdhYCIMEmkSAqqD84 QlGqNvGDWDqjC4Nags5QbiMiMbkk6TUg1L6ebYrUpr35BO33XCm8RRVGmlM0xFuytKc2 OaZQ0zYweREKPillqyPSEymBKykfS8FYIpWdA/ZLRjB0TypQ4VXfrm0zT2svcCMwFFtU ZrGCATBd8bif2y6+5co7wzhDtPMpicv/x47xi8J2gxia96UcuuMi+YHiuXhkNpQV51Ws IyzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728928234; x=1729533034; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LDf00oRTKrY7T+oZW3KhjdNBvWUbTZ18VyNxiHADh9Q=; b=kQnLu46NJRbFMllVtS4DRHL0cDUjPtbCg2dmsfmNpL3Vidk8cHKgfc9//xBDoRwdII pk1S11eQHBiTuXqHf6cWYLyHnq9Z8Qkub+l1NwknPogqqXAX0yKZfCvOL6Ujarp6qI0y obIxsiysXOYKdfPDXWTWrtnxWW9k78pDslgGQiPLGyaMKkM2p5AjphxkqcmV8rqn9J0y dzBLfFjSoqNu6YL73AHuFzUyxmgiY6H1sd0/cnZCwrvZPVosYAI8krmi2Xz0dGsOMVS6 uraN1dMKyq58dPHwk0cNl8GJUl1xkOhL9J+GiAL1YdgFDEvI+PpqRdDF2HeejE0dOLEG DWCA== X-Gm-Message-State: AOJu0YxlkMQLjp22duEqIeUOFuFQOKCP2dfvlFtCGjko/h71+GHCJJ4O FRrvBIdtrdN7mlk5U8j8HbhIBNUhhtZWpm/qvcNse74zY44wjoky6mZhJg== X-Google-Smtp-Source: AGHT+IGKvqxAN4UQ5GMUOeeAUbXyHWhtxL15YKgRm92Q/OxatDssR1FSfIFZ2CinGkMOHnc1LUq1/A== X-Received: by 2002:a05:6602:3426:b0:82c:ee6d:a7ee with SMTP id ca18e2360f4ac-83a64cb6568mr499418339f.2.1728928233909; Mon, 14 Oct 2024 10:50:33 -0700 (PDT) Received: from localhost.localdomain ([2600:4808:a053:7600::e413]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4dbe7c2c951sm3323212173.28.2024.10.14.10.50.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Oct 2024 10:50:32 -0700 (PDT) From: aurtzy Date: Mon, 14 Oct 2024 13:46:19 -0400 Message-ID: <01818e2901e02eeb4aba79cfbb1031886a3fb6a7.1728927759.git.aurtzy@gmail.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::d31; envelope-from=aurtzy@gmail.com; helo=mail-io1-xd31.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -0.27 X-Spam-Score: -0.27 X-Migadu-Queue-Id: E47C63DE8 X-Migadu-Scanner: mx12.migadu.com X-TUID: SWbU7lQix6jC This remedies an issue where applications like systemsettings and plasma-discover do not completely respect theming (e.g. when dark theme is enabled), with the following notable error message: kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" * gnu/packages/kde-frameworks.scm (qqc2-desktop-style)[inputs]: Add kcolorscheme to fix a theming issue. [arguments]<#:tests?>: Disable failing tests introduced by adding the kcolorscheme input. Change-Id: Ic34da2a2fc788737e543eb3cd2b23edf85a736a4 --- Hi! According to 'guix refresh --list-dependents qqc2-desktop-style', there are 18 dependent packages. I haven't noticed any visible regressions with this change running Plasma, and I can confirm theming in at least systemsettings and plasma-discover is fixed by the change. However, adding kcolorscheme as an input causes the check phase to fail (log included at the end). This appears to be due to tests that are enabled when kcolorscheme is added, one of which fails. The D-Bus error message is present in the current and patched version. I've tried setting the HOME and XDG_CACHE_HOME environment variables as it's done in other Qt/KDE packages, which has some effect on the tests but still results in failure. The Nix packages seem to reveal a partially circular dependency between qqc2-desktop-style and kirigami [1] [2]; I wonder if this is related to the issue? Here's the check phase log: --8<---------------cut here---------------start------------->8--- D-Bus library appears to be incorrectly set up: see the manual page for dbus-uuidgen to correct this issue. (Failed to open "/var/lib/dbus/machine-id": No such file or directory; Failed to open "/etc/machine-id": No such file or directory) Test project /tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/build Start 1: animationspeedmodifiertest 1/2 Test #1: animationspeedmodifiertest .......***Failed 0.11 sec ********* Start testing of IntegrationTest ********* Config: Using QtTest library 6.6.3, Qt 6.6.3 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 11.4.0), unknown unknown QWARN : IntegrationTest::initTestCase() kf.kirigami.platform: Failed to find a Kirigami platform plugin for style "org.kde.desktop" PASS : IntegrationTest::initTestCase() QWARN : IntegrationTest::testAnimationSpeedModifier_kconfig() kf.config.core: Couldn't create a new file: "/homeless-shelter/.qttest/config/kdeglobals" . Error: "No such file or directory" FAIL! : IntegrationTest::testAnimationSpeedModifier_kconfig() 'kdeGroup.sync()' returned FALSE. () Loc: [/tmp/guix-build-qqc2-desktop-style-6.5.0.drv-0/qqc2-desktop-style-6.5.0/kirigami-plasmadesktop-integration/autotests/animationspeedmodifiertest.cpp(69)] PASS : IntegrationTest::cleanupTestCase() Totals: 2 passed, 1 failed, 0 skipped, 0 blacklisted, 26ms ********* Finished testing of IntegrationTest ********* Fontconfig error: No writable cache directories Fontconfig error: No writable cache directories Start 2: TextFieldContextMenuTest 2/2 Test #2: TextFieldContextMenuTest ......... Passed 3.12 sec 50% tests passed, 1 tests failed out of 2 Total Test time (real) = 3.23 sec The following tests FAILED: 1 - animationspeedmodifiertest (Failed) --8<---------------cut here---------------end--------------->8--- [1] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/kirigami/default.nix [2] https://github.com/NixOS/nixpkgs/blob/master/pkgs/kde/frameworks/qqc2-desktop-style/default.nix Cheers, aurtzy gnu/packages/kde-frameworks.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm index 974fd1c4dd..e7c8eef775 100644 --- a/gnu/packages/kde-frameworks.scm +++ b/gnu/packages/kde-frameworks.scm @@ -1971,6 +1971,7 @@ (define-public qqc2-desktop-style (build-system qt-build-system) (arguments (list + #:tests? #f ; FIXME: 1/2 tests fail. #:qtbase qtbase #:phases #~(modify-phases %standard-phases (replace 'check @@ -1982,6 +1983,7 @@ (define-public qqc2-desktop-style (list extra-cmake-modules dbus pkg-config qttools)) (inputs (list kauth + kcolorscheme kconfig ; optional kcoreaddons kiconthemes ; optional base-commit: 5a77f79764ccc01eb545e55027d0147e64a81952 -- 2.46.0