From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id iNMII5y5GWTXpQAASxT56A (envelope-from ) for ; Tue, 21 Mar 2023 15:05:16 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 8NKrIpy5GWTzhwAAauVa8A (envelope-from ) for ; Tue, 21 Mar 2023 15:05:16 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 273FFFC24 for ; Tue, 21 Mar 2023 15:05:16 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pecbt-0005oc-DK; Tue, 21 Mar 2023 10:05:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pecbq-0005mI-ND for guix-patches@gnu.org; Tue, 21 Mar 2023 10:05:06 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pecbl-0003LE-Ve for guix-patches@gnu.org; Tue, 21 Mar 2023 10:05:06 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pecbl-0002OB-Qw for guix-patches@gnu.org; Tue, 21 Mar 2023 10:05:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#62282] [PATCH] gnu: gerbil: Upgrade to 0.17.0. Resent-From: Bruno Victal Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 21 Mar 2023 14:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62282 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: "J. Sims" Cc: "glv@posteo.net" , "jgart@dismail.de" , 62282@debbugs.gnu.org Received: via spool by 62282-submit@debbugs.gnu.org id=B62282.16794074739141 (code B ref 62282); Tue, 21 Mar 2023 14:05:01 +0000 Received: (at 62282) by debbugs.gnu.org; 21 Mar 2023 14:04:33 +0000 Received: from localhost ([127.0.0.1]:60036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecbJ-0002NM-Bn for submit@debbugs.gnu.org; Tue, 21 Mar 2023 10:04:33 -0400 Received: from smtpm4.myservices.hosting ([185.26.105.235]:45128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pecbH-0002NE-Lp for 62282@debbugs.gnu.org; Tue, 21 Mar 2023 10:04:32 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm4.myservices.hosting (Postfix) with ESMTP id CBAC520CFD; Tue, 21 Mar 2023 15:04:29 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id BAD218009E; Tue, 21 Mar 2023 14:57:41 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id e0f7KcmzljTy; Tue, 21 Mar 2023 14:57:41 +0100 (CET) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 291F6800A1; Tue, 21 Mar 2023 14:57:41 +0100 (CET) Message-ID: <0121a7d5-ed7a-9272-1c67-4182d979dd0d@makinata.eu> Date: Tue, 21 Mar 2023 13:57:36 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: From: Bruno Victal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1679407516; a=rsa-sha256; cv=none; b=VscCEarQc4cOsztlVHEZZ6bk7V8JNTG9IRpQTHC5iSom6Zd7RZ5ExOOKM9TUnFeClFYDuQ oCZUx//KgdlwhBcxmyRa5PNtne4/Ja7k9AvHoDp9sCZB0+6x7d5WQpU42snX7fa2yoQ/tb jan90bkZ5qJOP3ikNk5l9tsGzoKr9Bb2CDrXAZ0lAgAZttzRDNdcLBwO3CgYDmxgpqVK+F wgkB7BKDooff1Iu6XkfzCx8Bpcsh8ZyrbmqjIEF3vUUfVbDwF8UtLjeWzQMpYVk1P4PyYL nGFZTqL1raIlq7DiGfhFlj25GHh7PYiQ8mZGa++QZ398oUhGpSODtuSau6XgRg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1679407516; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=yjE/QCQOj6av7wj9ROILO9acUy8lt6GrlYLzq0KKor0=; b=mKDdv5GGEXClFbBE7P7AMU3kcSB4TXWcICy5HZhFJ3wtGTIZYfUaBtQn68TSt8xQmJ0tZr GRS3LxYBXE2bQpiQ8k+4BlXs36D5GWRGddslCeGvt9xGBSaE/xs+NWWxPD5IavDr9aJKZ3 qdu4GIoWRcNu+prWbFEltGJ+W+CP2hkI1bURxu7AFiuU2Ketokum+6hpkosg6RmsC0XgeB p/r7hcxrG0B1gyQv0Mf4vnhhP0Eahl/y+FrW2++XsBmhOL2lZH4qWUKQWlMr5diVPLUmiL YpQXDFd/nacujbnZcSobNcN5ArijfGaD8KaFOp4XzFflUK9oX+JaYJeU8OOfDQ== X-Migadu-Spam-Score: -3.25 X-Spam-Score: -3.25 X-Migadu-Queue-Id: 273FFFC24 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" X-Migadu-Scanner: scn1.migadu.com X-TUID: NEm44yZJ0HrG Hi Juli, On 2023-03-19 23:06, J. Sims via Guix-patches via wrote: > Hello, > > Attached is a patch to upgrade Gerbil to the latest version. In addition, it fixes a few issues: > > * switch build code to use g-expressions > * use the `#:tests?' argument of `arguments' instead of deleting the `check' phase > * run `guix style' > * fix issue with missing version file during build > > Honestly, I'm not sure I fixed the latter issue in the most idiomatic way. I simply printed the appropriate s-expression to the appropriate file using Guile's `format'. If anyone has advice for a cleaner/more robust way to handle that, please let me know. > > Note that I initially tried to fix the version file issue by ignoring the build instructions in the Gerbil guide and instead using the autotools build infrastructure whose artifacts can be seen in the top-level directory of the Gerbil repository. This ran into a different issue, and in the process of diagnosing it, I realized that the build infrastructure in question was written specifically for the previous version. There being no good reason to solve that problem over this one, and realizing that proper versioning would complicate the use of that system even more than solving the missing version file issue, I elected to pursue the route I did. > > This is far too much information for a git commit message, but I did feel it worth mentioning somewhere. You should split these changes into separate commits. Take a look at or search the git history for “G-Expression” for some inspiration in how to split them. Cheers, Bruno