unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Bruno Victal <mirai@makinata.eu>
To: "J. Sims" <jtsims@protonmail.com>
Cc: "glv@posteo.net" <glv@posteo.net>,
	"jgart@dismail.de" <jgart@dismail.de>,
	62282@debbugs.gnu.org
Subject: [bug#62282] [PATCH] gnu: gerbil: Upgrade to 0.17.0.
Date: Tue, 21 Mar 2023 13:57:36 +0000	[thread overview]
Message-ID: <0121a7d5-ed7a-9272-1c67-4182d979dd0d@makinata.eu> (raw)
In-Reply-To: <pNKW-ofctVMCSivZsLfj0vL5GcFzDJc-tOXgxg85Ug4eT7J5qMfVSezsuu_3BKEHl8Kcg8UMCpdq4gROMB7UJbPq866f_wYJ1bE0b0FrX54=@protonmail.com>

Hi Juli,

On 2023-03-19 23:06, J. Sims via Guix-patches via wrote:
> Hello,
> 
> Attached is a patch to upgrade Gerbil to the latest version. In addition, it fixes a few issues:
> 
> * switch build code to use g-expressions
> * use the `#:tests?' argument of `arguments' instead of deleting the `check' phase
> * run `guix style'
> * fix issue with missing version file during build
> 
> Honestly, I'm not sure I fixed the latter issue in the most idiomatic way. I simply printed the appropriate s-expression to the appropriate file using Guile's `format'. If anyone has advice for a cleaner/more robust way to handle that, please let me know.
> 
> Note that I initially tried to fix the version file issue by ignoring the build instructions in the Gerbil guide and instead using the autotools build infrastructure whose artifacts can be seen in the top-level directory of the Gerbil repository. This ran into a different issue, and in the process of diagnosing it, I realized that the build infrastructure in question was written specifically for the previous version. There being no good reason to solve that problem over this one, and realizing that proper versioning would complicate the use of that system even more than solving the missing version file issue, I elected to pursue the route I did.
> 
> This is far too much information for a git commit message, but I did feel it worth mentioning somewhere.

You should split these changes into separate commits.

Take a look at <https://issues.guix.gnu.org/61845> or search the git history for “G-Expression”
for some inspiration in how to split them.


Cheers,
Bruno




  reply	other threads:[~2023-03-21 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-19 23:06 [bug#62282] [PATCH] gnu: gerbil: Upgrade to 0.17.0 J. Sims via Guix-patches via
2023-03-21 13:57 ` Bruno Victal [this message]
2023-03-30  2:12   ` J. Sims via Guix-patches via
2023-04-08 22:01     ` bug#62282: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0121a7d5-ed7a-9272-1c67-4182d979dd0d@makinata.eu \
    --to=mirai@makinata.eu \
    --cc=62282@debbugs.gnu.org \
    --cc=glv@posteo.net \
    --cc=jgart@dismail.de \
    --cc=jtsims@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).