[bug#42960] Add New Package: ronn-ng

[bug#42960] Add New Package: ronn-ng

[Prafulla Giri]

[-- Attachment #1.1: Type: text/plain, Size: 84 bytes --]

Esteemed Maintainers,

Attached patch contains a definition of ronn-ng.

Thank you!

[-- Attachment #1.2: Type: text/html, Size: 168 bytes --]

[-- Attachment #2: 0001-gnu-Add-ronn-ng.patch --]
[-- Type: text/x-patch, Size: 3013 bytes --]

From 66f628c7b67e86aadda9c898385d7f1fe5a2a637 Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Thu, 20 Aug 2020 21:29:29 +0545
Subject: [PATCH] gnu: Add ronn-ng

* gnu/packages/groff.scm (ronn-ng): New public variable.
---
 gnu/packages/groff.scm | 51 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 51 insertions(+)

diff --git a/gnu/packages/groff.scm b/gnu/packages/groff.scm
index 222b4cb6dc..b5460c8b44 100644
--- a/gnu/packages/groff.scm
+++ b/gnu/packages/groff.scm
@@ -30,7 +30,9 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system ruby)
   #:use-module (gnu packages)
+  #:use-module (gnu packages ruby)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages netpbm)
@@ -208,3 +210,52 @@ is usually the formatter of \"man\" documentation pages.")
        "Roffit is a program that reads an nroff file and outputs an HTML file.
 It is typically used to display man pages on a web site.")
       (license expat))))
+
+(define-public ronn-ng
+  (package
+    (name "ronn-ng")
+    (version "0.9.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "ronn-ng" version))
+       (sha256
+        (base32
+         "1slxfg57cabmh98fw507z4ka6lwq1pvbrqwppflxw6700pi8ykfh"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after
+             'extract-gemspec 'fix-gemspec-mustache
+           (lambda _
+             (substitute* "ronn-ng.gemspec"
+               (("(<mustache>.freeze.*~>).*(\".*$)" all start end)
+                (string-append start " 1.0" end)))
+             #t))
+         (add-after
+             'wrap 'wrap-program
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((prog (string-append (assoc-ref %outputs "out") "/bin/ronn")))
+               (begin (display %build-inputs)(newline))
+               (wrap-program prog
+                 `("PATH" ":" suffix ,(map
+                                       (lambda (exp_inpt)
+                                         (string-append
+                                          (assoc-ref %build-inputs exp_inpt)
+                                          "/bin"))
+                                       '("ruby-kramdown"
+                                         "ruby-mustache"
+                                         "ruby-nokogiri")))))
+             #t)) )))
+    (inputs
+     `(("ruby-kramdown" ,ruby-kramdown)
+       ("ruby-mustache" ,ruby-mustache)
+       ("ruby-nokogiri" ,ruby-nokogiri)))
+    (synopsis
+     "Build manuals in HTML and Unix man page format from Markdown")
+    (description
+     "Ronn-NG is an updated fork of ronn.
+It builds manuals in HTML and Unix man page format from Markdown.")
+    (home-page "https://github.com/apjanke/ronn-ng")
+    (license expat)))
-- 
2.28.0

[bug#42960] Add New Package: ronn-ng

[Julien Lepiller]

[-- Attachment #1: Type: text/plain, Size: 958 bytes --]

So I can't try your patch right now, nor cite it in my answer to show you, sorry.

From what I see, here are a few comments. Can you fix them and send us an updated patch? I'll push as soon as I'm back home this evening.

You should add a copyright line for yourself (unless you already have one, I haven't checked the existing file).

The rest is related to whitespace and so. You shouldn't use a newline right after add-after. Look at other packages to see how it's done. You've left a (begin …) that you probably used for debugging. There's a space in the closing parenthesis at the end of tge arguments. The discripcion is weirdly formatted: use two spaces after the period, and continue on the same line, breaking just before 80 characters.

Thank you!

On 2020年8月20日 11:50:31 GMT-04:00, Prafulla Giri <pratheblackdiamond@gmail.com> wrote:
>Esteemed Maintainers,
>
>Attached patch contains a definition of ronn-ng.
>
>Thank you!

[-- Attachment #2: Type: text/html, Size: 1271 bytes --]

[bug#42960] Add New Package: ronn-ng

[Prafulla Giri]

[-- Attachment #1.1: Type: text/plain, Size: 1357 bytes --]

Hey there,

Thank you very much for the feedback. I have made changes accordingly. ( I
did not want to add the copyright line because I'm still stuck with my 6th
grade email address, but oh well. :D )

Attached is an updated patch.

Thank you!

On Thu, Aug 20, 2020 at 10:55 PM Julien Lepiller <julien@lepiller.eu> wrote:

> So I can't try your patch right now, nor cite it in my answer to show you,
> sorry.
>
> From what I see, here are a few comments. Can you fix them and send us an
> updated patch? I'll push as soon as I'm back home this evening.
>
> You should add a copyright line for yourself (unless you already have one,
> I haven't checked the existing file).
>
> The rest is related to whitespace and so. You shouldn't use a newline
> right after add-after. Look at other packages to see how it's done. You've
> left a (begin …) that you probably used for debugging. There's a space in
> the closing parenthesis at the end of tge arguments. The discripcion is
> weirdly formatted: use two spaces after the period, and continue on the
> same line, breaking just before 80 characters.
>
> Thank you!
>
> On 2020年8月20日 11:50:31 GMT-04:00, Prafulla Giri <
> pratheblackdiamond@gmail.com> wrote:
>>
>> Esteemed Maintainers,
>>
>> Attached patch contains a definition of ronn-ng.
>>
>> Thank you!
>>
>

[-- Attachment #1.2: Type: text/html, Size: 2025 bytes --]

[-- Attachment #2: 0001-gnu-Add-ronn-ng.patch --]
[-- Type: text/x-patch, Size: 3239 bytes --]

From 98e759230c8df624ea2cab2968a5d4f4b865169b Mon Sep 17 00:00:00 2001
From: Prafulla Giri <pratheblackdiamond@gmail.com>
Date: Thu, 20 Aug 2020 21:29:29 +0545
Subject: [PATCH] gnu: Add ronn-ng

* gnu/packages/groff.scm (ronn-ng): New public variable.
---
 gnu/packages/groff.scm | 49 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/gnu/packages/groff.scm b/gnu/packages/groff.scm
index 222b4cb6dc..3a44497594 100644
--- a/gnu/packages/groff.scm
+++ b/gnu/packages/groff.scm
@@ -7,6 +7,7 @@
 ;;; Copyright © 2019 Eric Bavier <bavier@member.fsf.org>
 ;;; Copyright © 2019 Mathieu Othacehe <m.othacehe@gmail.com>
 ;;; Copyright © 2020 Michael Rohleder <mike@rohleder.de>
+;;; Copyright © 2020 Prafulla Giri <pratheblackdiamond@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -30,7 +31,9 @@
   #:use-module (guix download)
   #:use-module (guix git-download)
   #:use-module (guix build-system gnu)
+  #:use-module (guix build-system ruby)
   #:use-module (gnu packages)
+  #:use-module (gnu packages ruby)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages ghostscript)
   #:use-module (gnu packages netpbm)
@@ -208,3 +211,49 @@ is usually the formatter of \"man\" documentation pages.")
        "Roffit is a program that reads an nroff file and outputs an HTML file.
 It is typically used to display man pages on a web site.")
       (license expat))))
+
+(define-public ronn-ng
+  (package
+    (name "ronn-ng")
+    (version "0.9.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (rubygems-uri "ronn-ng" version))
+       (sha256
+        (base32
+         "1slxfg57cabmh98fw507z4ka6lwq1pvbrqwppflxw6700pi8ykfh"))))
+    (build-system ruby-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'extract-gemspec 'fix-gemspec-mustache
+           (lambda _
+             (substitute* "ronn-ng.gemspec"
+               (("(<mustache>.freeze.*~>).*(\".*$)" all start end)
+                (string-append start " 1.0" end)))
+             #t))
+         (add-after 'wrap 'wrap-program
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let ((prog (string-append (assoc-ref %outputs "out") "/bin/ronn")))
+               (wrap-program prog
+                 `("PATH" ":" suffix ,(map
+                                       (lambda (exp_inpt)
+                                         (string-append
+                                          (assoc-ref %build-inputs exp_inpt)
+                                          "/bin"))
+                                       '("ruby-kramdown"
+                                         "ruby-mustache"
+                                         "ruby-nokogiri")))))
+             #t)))))
+    (inputs
+     `(("ruby-kramdown" ,ruby-kramdown)
+       ("ruby-mustache" ,ruby-mustache)
+       ("ruby-nokogiri" ,ruby-nokogiri)))
+    (synopsis
+     "Build manuals in HTML and Unix man page format from Markdown")
+    (description
+     "Ronn-NG is an updated fork of ronn.  It builds manuals in HTML and Unix
+man page format from Markdown.")
+    (home-page "https://github.com/apjanke/ronn-ng")
+    (license expat)))
-- 
2.28.0

bug#42960: Add New Package: ronn-ng

[Julien Lepiller]

Pushed as c02398edf43c393b858d57c7b9e4839514f85acb on master. Thank you!