From: Maxime Devos <maximedevos@telenet.be>
To: kiasoc5 <kiasoc5@disroot.org>, Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 57927@debbugs.gnu.org
Subject: [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps.
Date: Wed, 28 Sep 2022 23:14:03 +0200 [thread overview]
Message-ID: <0052b9b3-099e-260f-10d5-48e6e92e1a55@telenet.be> (raw)
In-Reply-To: <20220928043407.181d9060@aria>
[-- Attachment #1.1.1: Type: text/plain, Size: 821 bytes --]
On 28-09-2022 06:34, kiasoc5 via Guix-patches via wrote:
>>> * gnu/packages/pretty-print.scm (source-highlight):
>>> [arguments]: Use gexps, remove trailing #ts.
>>> [phases]: Add phase to make src-highlight-lesspipe.sh work.
>> These unrelated changes should be separated into at least two
>> patches next time: one to gexp and remove the #ts, the other to
>> make the functional change.
>> < to go
>> straight to master.
> 1. Does trailing #t change the hash?
Yes.
> 2. Why might Gexpification change the hash?
When the resulting staged code changes. This could happen if you were
to do, say, #$(this-package-input "boost") instead of (assoc-ref
%build-inputs "boost") for example, though AFAICT you didn't make any
G-exp-related changes that would change the hash.
Greetings,
Maxime.
[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]
next prev parent reply other threads:[~2022-09-28 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 6:57 [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps kiasoc5 via Guix-patches via
2022-09-27 9:11 ` bug#57927: " Mathieu Othacehe
2022-09-27 13:22 ` [bug#57927] " Tobias Geerinckx-Rice via Guix-patches via
2022-09-28 4:34 ` kiasoc5 via Guix-patches via
2022-09-28 21:14 ` Maxime Devos [this message]
2022-09-28 21:16 ` Maxime Devos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0052b9b3-099e-260f-10d5-48e6e92e1a55@telenet.be \
--to=maximedevos@telenet.be \
--cc=57927@debbugs.gnu.org \
--cc=kiasoc5@disroot.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).