bug#26812: [PATCH] gnu: Add emacs-evil-commentary.

bug#26812: [PATCH] gnu: Add emacs-evil-commentary.

[Arun Isaac]

* gnu/packages/emacs.scm (emacs-evil-commentary): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 47fe0cc84..859026659 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4622,3 +4622,26 @@ pressed simultaneously or a single key quickly pressed twice.")
     (description "@code{emacs-evil-surround} allows easy deletion, change and
 addition of surrounding pairs, such as parantheses and quotes, in evil mode.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-commentary
+  (package
+    (name "emacs-evil-commentary")
+    (version "2.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/linktohack/evil-commentary/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1jdya0i921nwskwrzdsj0vrr3m7gm49dy6f6pk9p5nxaarfxk230"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)))
+    (home-page "https://github.com/linktohack/evil-commentary")
+    (synopsis "Comment out code in evil mode")
+    (description "@code{emacs-evil-commentary} makes it easy to comment out
+lines of code in evil mode.")
+    (license license:gpl3+)))
-- 
2.12.2

bug#26812: [PATCH] gnu: Add emacs-evil-commentary.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 745 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

> * gnu/packages/emacs.scm (emacs-evil-commentary): New variable.

[...]

> +    (home-page "https://github.com/linktohack/evil-commentary")
> +    (synopsis "Comment out code in evil mode")
> +    (description "@code{emacs-evil-commentary} makes it easy to comment out
> +lines of code in evil mode.")

Could you expand on this description a little? Something like "adds
keybindings to comment out lines, selections or regions". Maybe also
mention the keybindings as in the first paragraph of the README.

Nit-pick of course, but I've come to really appreciate descriptions that
don't require me to visit the home page, dig around for READMEs or even
read the source code.. :P

LGTM either way.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#26812: [PATCH] gnu: Add emacs-evil-commentary.

[Arun Isaac]

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]


> Nit-pick of course, but I've come to really appreciate descriptions that
> don't require me to visit the home page, dig around for READMEs or even
> read the source code.. :P

I'm fine with nitpicking. It's important to maintain quality. :-)

Please find attached an updated patch. Let me know if it's fine.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-Add-emacs-evil-commentary.patch --]
[-- Type: text/x-patch, Size: 1729 bytes --]

From bc9172d11dd11b4e9df888e5ffb0d928ecc292cf Mon Sep 17 00:00:00 2001
From: Arun Isaac <arunisaac@systemreboot.net>
Date: Sun, 7 May 2017 15:18:02 +0530
Subject: [PATCH] gnu: Add emacs-evil-commentary.

* gnu/packages/emacs.scm (emacs-evil-commentary): New variable.
---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 47fe0cc84..368e8cab5 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4622,3 +4622,27 @@ pressed simultaneously or a single key quickly pressed twice.")
     (description "@code{emacs-evil-surround} allows easy deletion, change and
 addition of surrounding pairs, such as parantheses and quotes, in evil mode.")
     (license license:gpl3+)))
+
+(define-public emacs-evil-commentary
+  (package
+    (name "emacs-evil-commentary")
+    (version "2.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/linktohack/evil-commentary/archive/v"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1jdya0i921nwskwrzdsj0vrr3m7gm49dy6f6pk9p5nxaarfxk230"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-evil" ,emacs-evil)))
+    (home-page "https://github.com/linktohack/evil-commentary")
+    (synopsis "Comment out code in evil mode")
+    (description "@code{emacs-evil-commentary} adds keybindings to easily
+comment out lines of code in evil mode.  It provides @code{gcc} to comment out
+lines, and @code{gc} to comment out the target of a motion.")
+    (license license:gpl3+)))
-- 
2.12.2

bug#26812: [PATCH] gnu: Add emacs-evil-commentary.

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Arun Isaac <arunisaac@systemreboot.net> writes:

>> Nit-pick of course, but I've come to really appreciate descriptions that
>> don't require me to visit the home page, dig around for READMEs or even
>> read the source code.. :P
>
> I'm fine with nitpicking. It's important to maintain quality. :-)
>
> Please find attached an updated patch. Let me know if it's fine.

Looks great, thanks!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#26812: [PATCH] gnu: Add emacs-evil-commentary.

[Arun Isaac]

Pushed!