unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Martin Becze <mjbecze@riseup.net>
To: John Soo <jsoo1@asu.edu>
Cc: Guix-patches <guix-patches-bounces+mjbecze=riseup.net@gnu.org>,
	38640@debbugs.gnu.org
Subject: [bug#38640] [PATCH] Add ripgrep and many rust dependencies
Date: Mon, 16 Dec 2019 14:53:38 -0800	[thread overview]
Message-ID: <002582d46228db8739fc12c0404ad177@riseup.net> (raw)
In-Reply-To: <CAKf5CqU4MzyLgtDQQsQmENi8DV=oYcLzb-yJbhOU2P5F6ZoCYA@mail.gmail.com>

On 2019-12-16 19:08, John Soo wrote:
> Hi Guix,
> 
> I have missed using the rust tools I use outside of Guix. Ripgrep was
> the first one I could build thanks to the work on the rust build
> system.
> 
> Of course, it required adding over 200 dependencies.
> 
> Some of these have cyclic dependencies, as you all know. What I
> understand is that the rust community is OK with including cyclic
> dependencies as test dependencies.  I am actually seeing how useful
> that is. Consider the system tests in the guix repository. Certainly
> that would require including guix as a dependency to guix.
> 
> I also left the cargo inputs and dev inputs commented out just in case
> someone wants to put them back in the future and to give a sense of
> the topological order of the patches.
> 
> Having imported ripgrep some months ago, some of these dependencies
> will require updates, but I did not want to break the working version
> of ripgrep at the end of the line.  Otherwise I have fixed the other
> lint errors and I have been using ripgrep for several months.
> 
> - John

I'm trying to convince everyone to leave in the crago-inputs
dependencies and add a "#:skip-build? #t" to the build arguments for all
source pakages. That way we don't have to specify the transient
dependencies at the top level package. Either way yay ripgrep!

-Martin  

  parent reply	other threads:[~2019-12-16 22:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-16 19:08 [bug#38640] [PATCH] Add ripgrep and many rust dependencies John Soo
2019-12-16 21:04 ` Nicolò Balzarotti
2019-12-16 22:53 ` Martin Becze [this message]
2019-12-17 17:10   ` John Soo
2019-12-18 16:32     ` Martin Becze
2019-12-18 16:42       ` John Soo
2019-12-18 16:49         ` Martin Becze
2019-12-18 16:50           ` John Soo
2019-12-19  7:25         ` Efraim Flashner
2019-12-20 17:44           ` John Soo
2019-12-21  4:18             ` John Soo
2019-12-31  8:57               ` Efraim Flashner
2019-12-31 15:49                 ` John Soo
2020-01-02 18:20                   ` bug#38640: " Efraim Flashner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=002582d46228db8739fc12c0404ad177@riseup.net \
    --to=mjbecze@riseup.net \
    --cc=38640@debbugs.gnu.org \
    --cc=guix-patches-bounces+mjbecze=riseup.net@gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).