unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxime Devos <maximedevos@telenet.be>
To: Christopher Rodriguez <yewscion@gmail.com>, 56989@debbugs.gnu.org
Subject: [bug#56989] [PATCH v3] gnu: Add dbqn.
Date: Mon, 8 Aug 2022 11:19:34 +0200	[thread overview]
Message-ID: <00125176-9e1f-6d91-21d8-0d2fd9558aca@telenet.be> (raw)
In-Reply-To: <20220806022022.24054-1-yewscion@gmail.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 6054 bytes --]

On 06-08-2022 04:20, Christopher Rodriguez wrote:

> +(define-module (gnu packages bqn)

Copyright and license headers are missing. Also, usually we don't do 
per-package modules but rather thematic modules, though that's not a 
hard rule especially if there are technical problems with that.

> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix gexp)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix git-download)
> +  #:use-module (guix build-system copy)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix utils)
> +  #:use-module (guix deprecation)
I don't think you are using (guix deprecation) below?
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages libffi)
> +  #:use-module (gnu packages base)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages llvm)
> +  #:use-module (gnu packages java)
> +  #:use-module (gnu packages compression))
> +(define-public dbqn
> +  (let ((commit "0bbe096fc07d278b679a8479318f1722d096a03e")
> +        (revision "1"))
> +    (package
> +      (name "dbqn")
> +      (version (git-version "0.2.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url"https://github.com/dzaima/BQN")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1kxzxz2hrd1871281s4rsi569qk314aqfmng9pkqn8gv9nqhmph0"))))

I have looked at the 'v0.2.1' tag, and it points at the 0bbe096... 
commit, so you are actually packaging version 0.2.1, not some git commit 
after v0.2.1. As such, no need for (git-version ...), you can just write 
"0.2.1" there. Then 'revision' becomes unused and can be dropped, and 
'commit' is only used in a single place anymore so it can be inlined.

> +      (native-inputs (list `(,icedtea-8 "jdk") coreutils zip))
coreutils is an implicit (native-)input, likely no need to to mention it.

Also, the Makefile mentions that the executable to start things has 
#!/bin/bash -- to properly patch is when cross-compiling, you need 
'bash-minimal' or 'bash' in inputs, otherwise it will be patched for the 
wrong architecture.

Also, that script runs 'java' -- make sure it is patched too such that 
java will actually be found -- and to patch it, you need to have 
icedtea:out or openjdk:out in 'inputs'.

> +      (outputs '("out"))
That's the default, no need to set it.

> +       (list #:imported-modules `(,@%gnu-build-system-modules (guix build
> +                                                                    syscalls)
For formatting, (guix build syscalls) should be on a separate line.

> +      (synopsis "BQN implementation based on dzaima/APL")
> +      (description "BQN implementation based on dzaima/APL.")
The synopsis and description are identical, and this doesn't explain 
much to people who don't know what 'BQN' is. Can it be rewritten such 
that people not familiar with BQN can decide whether this ‘BQN’ is 
something that's useful for them? '(guix)Synopses and Descriptions' has 
more information.

> +                            (lambda* (:#key tests?
> +                                            #:allow-other-tags)
Why the : before #:key? Also, no need to break it in separate lines.

> +                          (add-after 'install 'reorder-jar-content
> +                            (lambda* (#:key outputs #:allow-other-keys)
> +                              (apply (assoc-ref ant:%standard-phases
> +                                                'reorder-jar-content)
> +                                     #:outputs (list outputs))))
'output's is a list of strings, now you are giving reorder-jar-content a 
list of lists of strings
However, looking at (guix build ant-build-system), it looks like it just 
wants a list of strings.

As such, maybe it should be:

(add-after 'install 'reorder-jar-content
   (assoc-ref ant:%standard-phases 'reorder-jar-content))

? (untested)  Possibly likewise for the other phases.

> (the implementation is even under single-license GPL!) [...]
You are writing license:expat in the 'license' field, not 
license:gplN/license:gplN+. Is it Expat or is it GPL?

> +      (synopsis "Official BQN sources in BQN")
If they are just sources, you can do (define bqn-bytecode-sources 
(origin ...))

> +      (home-page"https://github.com/mlochbaum/BQN.git")
> +      (license license:gpl3))))
The 'LICENSE' file says something different. I don't think that's the 
home page, maybe <https://mlochbaum.github.io/BQN/> instead?

> +                              (chmod "BQN" 493)
Hexadecimal would be clearer.
> +       "The expected implementation for the BQN language,
> +according to the official documentation of that specification.")
expected -> standard (what's 'expected' depends on the user, they might 
want a different implementation), unless it's not the standard 
implementation.

'documentation of that specification' -> 'the specification (pleonasm)

And maybe remove 'official', given the absence of 'official' in the 
descriptions of, say, guile, gcc, openjdk and java, this sounds 
marketing and unfair to me.

(singeli-bootstrap:)

> +  (let* ((tag "0")
> +         (revision "1")
> +         (commit "fd17b144483549dbd2bcf23e3a37a09219171a99")
> +         (hash "1rr4l7ijzcg25n2igi1mzya6qllh5wsrf3m5i429rlgwv1fwvfji")
> +         (version (git-version tag revision commit)))
I'm not seeing a '0' tag anywhere in the repository -- I dont see any 
tags at all tere.

> +    (inputs (list bqn-bytecode-sources libffi singeli-bootstrap))))
For cross-compilation, I would have expected sengili-bootstrap in 
native-inputs, not inputs, assuming that it is used as a compiler. Does 
cross-compilation (with --target) work?

Greetings,
Maxime.


[-- Attachment #1.1.2: OpenPGP public key --]
[-- Type: application/pgp-keys, Size: 929 bytes --]

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 236 bytes --]

  parent reply	other threads:[~2022-08-08  9:28 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  2:20 [bug#56989] [PATCH v1 1/5] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-05  2:20 ` [bug#56990] [PATCH v1 2/5] gnu: bqn: Add bqn-bytecode-sources Christopher Rodriguez
2022-08-05  2:20 ` [bug#56992] [PATCH v1 3/5] gnu: bqn: Add cbqn-bootstrap Christopher Rodriguez
2022-08-05  2:20 ` [bug#56991] [PATCH v1 4/5] gnu: bqn: Add singeli-bootstrap Christopher Rodriguez
2022-08-05  2:20 ` [bug#56993] [PATCH v1 5/5] gnu: bqn: Add cbqn Christopher Rodriguez
2022-08-05  5:46 ` [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-05  7:15   ` Liliana Marie Prikler
2022-08-05 15:12     ` Christopher Rodriguez
2022-08-05 15:37       ` ( via Guix-patches via
2022-08-05 15:50         ` Christopher Rodriguez
2022-08-05 15:50         ` Christopher Rodriguez
2022-08-05 22:33       ` Liliana Marie Prikler
2022-08-06  1:47         ` Christopher Rodriguez
2022-08-06  2:20 ` [bug#56989] [PATCH v3] gnu: Add dbqn Christopher Rodriguez
2022-08-07 16:28   ` Liliana Marie Prikler
2022-08-08  9:19   ` Maxime Devos [this message]
2022-08-08 13:54     ` Christopher Rodriguez
2022-08-08 21:09       ` Maxime Devos
2022-08-09  8:58       ` Maxime Devos
2022-08-09  9:02         ` Maxime Devos
2022-08-07 14:43 ` [bug#56989] [PATCH v2] gnu: bqn: Add bqn.scm and dbqn package Christopher Rodriguez
2022-08-08  9:20 ` [bug#56989] [PATCH v1 1/5] " Maxime Devos
2022-08-09  1:22 ` [bug#56989] [PATCH v4] gnu: Add dbqn Christopher Rodriguez
2022-08-10 17:27 ` [bug#56989] [PATCH v5 1/5] gnu: Add dbqn package Christopher Rodriguez
2022-08-10 17:27   ` [bug#56989] [PATCH v5 2/5] gnu: Add bqn-sources Christopher Rodriguez
2022-08-10 17:27   ` [bug#56989] [PATCH v5 3/5] gnu: Add cbqn-bootstrap Christopher Rodriguez
2022-08-10 17:27   ` [bug#56989] [PATCH v5 4/5] gnu: Add singeli-sources Christopher Rodriguez
2022-08-10 17:28   ` [bug#56989] [PATCH v5 5/5] gnu: Add cbqn Christopher Rodriguez
2022-08-31 21:10   ` bug#56989: bug#56993: [PATCH v1 5/5] gnu: bqn: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=00125176-9e1f-6d91-21d8-0d2fd9558aca@telenet.be \
    --to=maximedevos@telenet.be \
    --cc=56989@debbugs.gnu.org \
    --cc=yewscion@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).