From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joshua Branson Subject: Re: 05/06: gnu: rust: Don't build for "native" arch on ARM. Date: Tue, 17 Apr 2018 16:49:24 -0400 Message-ID: References: <20180416175951.28242.65069@vcs0.savannah.gnu.org> <20180416175952.9458420373@vcs0.savannah.gnu.org> <87bmeior2n.fsf@netris.org> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55468) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f8XWN-0002Hy-4m for guix-devel@gnu.org; Tue, 17 Apr 2018 16:48:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f8XWJ-0005WG-4k for guix-devel@gnu.org; Tue, 17 Apr 2018 16:48:11 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:32925) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1f8XWJ-0005SH-0I for guix-devel@gnu.org; Tue, 17 Apr 2018 16:48:07 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 532B322033 for ; Tue, 17 Apr 2018 16:48:06 -0400 (EDT) Received: from dobby (unknown [72.12.220.132]) by mail.messagingengine.com (Postfix) with ESMTPA id 022ACE498C for ; Tue, 17 Apr 2018 16:48:05 -0400 (EDT) In-Reply-To: <87bmeior2n.fsf@netris.org> (Mark H. Weaver's message of "Mon, 16 Apr 2018 16:05:04 -0400") List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org Mark H Weaver writes: > Hi Efraim and Danny, > > dannym@scratchpost.org (Danny Milosavljevic) writes: > >> dannym pushed a commit to branch master >> in repository guix. >> >> commit 67ca98ec7818f5b63fe041bfee4ef10826635685 >> Author: Efraim Flashner >> Date: Thu Mar 22 09:14:53 2018 +0200 >> >> gnu: rust: Don't build for "native" arch on ARM. >> >> * gnu/packages/rust.scm (rust-1.23)<#:phases>[dont-build-native]: New phase. >> --- >> gnu/packages/rust.scm | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm >> index 8c5abfc..0df649c 100644 >> --- a/gnu/packages/rust.scm >> +++ b/gnu/packages/rust.scm >> @@ -351,6 +351,12 @@ safety and thread safety guarantees.") >> (substitute-keyword-arguments (package-arguments rust-1.19) >> ((#:phases phases) >> `(modify-phases ,phases >> + (add-after 'unpack 'dont-build-native >> + (lambda _ >> + ;; XXX: Revisit this when we use gcc 6. >> + (substitute* "src/binaryen/CMakeLists.txt" >> + (("ADD_COMPILE_FLAG\\(\\\"-march=native\\\"\\)") "")) >> + #t)) >> (add-after 'patch-tests 'patch-cargo-tests >> (lambda _ >> (substitute* "src/tools/cargo/tests/build.rs" > > If it would be beneficial, you might consider using gcc-7 to compile > 'rust', by adding 'gcc-7' to native-inputs. We're already using gcc-7 > to compile a few other packages, including linux-libre on x86_64. Maybe this is a silly question, but I thought that gcc couldn't compile rust code? I thought LLVM was the only compiler that could compile rust? > > Mark