From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id gJs0FIJpDGZphQEAe85BDQ:P1 (envelope-from ) for ; Tue, 02 Apr 2024 22:24:34 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id gJs0FIJpDGZphQEAe85BDQ (envelope-from ) for ; Tue, 02 Apr 2024 22:24:34 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=futurile.net header.s=selector1 header.b=UriR8EWl; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1712089474; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=6auMjCzWGI28hJrSyweseuv3bkSXjb4UUBs474WFpSk=; b=hzfDAfn0kh+iSZBlXLmYwUPnlPaq1ysXIFIKiRReLryV8ry8/N8o8Hezh/CNPGqEQwkEM+ dFRRicR+5/d1oNBDY1tSWd0O30cfntCMNHRdWmgno2fMpWwk/O+T5DM4feG5HWTzSkD24n NcEtbkg6IuENfqpK8WHXjD9BC0S4FWFKpdgVu2qyuzlCgit744z6pK+9TvwrWeDroUP4bu x7ns4wvXL4g+vI+1T+gq5MHyrKdVFYcjv1XdsX4WsB2W9docwNot21b1i0GkRKQHsS2RQ3 s8ib6x4JSnFqe1N1LJOf2mpXd0dyy3uV2InytMoxlsiDavny/ZOXz65SYZOd0g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=futurile.net header.s=selector1 header.b=UriR8EWl; spf=pass (aspmx1.migadu.com: domain of "guix-devel-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-devel-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1712089474; a=rsa-sha256; cv=none; b=oqJmTI9g8TseYwndhvEUA9wAugawnYyK1lYONhy1nYiwsUuro5w+RXuPnhuCKAKhihz5gV 8vjPTRV++U/JedbwDLaukToV5qsYbEgrr1bgWibjW8dLDux6nQ16AEUINLQcZpHcCiwcjG /pkwVTTfrztUz3ZwzI+El32qgsQlwg2nGB50kuRz4TCQVRgQ4W6So1ZGTUu3mSAbGsSNnO pMJOXpwtxp4LPSk8NmRxLcsuKCgqgKzdqexwr5S38Bdlq+iWZhZUN2tHlusILUJshpSiqv SWuCxTq34m81BH9E2fAYS6NyXGMdlL2m9yFoJWL7WtSXyX6fXgTw3RftbgKqbQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3E3083FCEA for ; Tue, 2 Apr 2024 22:24:34 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrkfv-0004Us-7m; Tue, 02 Apr 2024 16:24:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrkfp-0004UU-AW for guix-devel@gnu.org; Tue, 02 Apr 2024 16:24:01 -0400 Received: from mailtransmit04.runbox.com ([2a0c:5a00:149::25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrkfm-00074Y-WE for guix-devel@gnu.org; Tue, 02 Apr 2024 16:24:00 -0400 Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit04.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1rrkfg-000fxj-RL; Tue, 02 Apr 2024 22:23:52 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=futurile.net; s=selector1; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date; bh=6auMjCzWGI28hJrSyweseuv3bkSXjb4UUBs474WFpSk=; b=UriR8EWloKYFbbR37i9evI9Nbt U0X4LeN17dFM6B/BMc9mk94J5oCkNwNmzMITPN3GrDTvbBgP1a6DznQm3BRo8HxbCgJveF+4PmDir DwlMscnQvUi44ds90d1bC8zFGXMFpYhyJg8Wh4u4GQMTwjzfLvDOTnOfj95MwXymSSJemNy2yKSzj pQhrzPCBezQtKSak0ThTStJmggAh0KNhzvC/fkIpqtrMhlEnX7/eRlqUvkGGqLokIZjSQ6yJaaKOV Ca8/1mw20283sIK85P26qJ8aradDHZpB0MihRhDnCh1Hp+RLPJG5CjpU9WpKTHdKs6+E64u54zlrU W+RsrveA==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1rrkfg-0008Nv-8B; Tue, 02 Apr 2024 22:23:52 +0200 Received: by submission02.runbox with esmtpsa [Authenticated ID (641962)] (TLS1.2:ECDHE_SECP256R1__RSA_SHA256__AES_256_GCM:256) (Exim 4.93) id 1rrkfU-000Y2R-6v; Tue, 02 Apr 2024 22:23:40 +0200 Date: Tue, 2 Apr 2024 21:23:39 +0100 From: Steve George To: Christina O'Donnell Cc: guix-devel Subject: Re: Coordinators for patch review session on Tuesday Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: permerror client-ip=2a0c:5a00:149::25; envelope-from=steve@futurile.net; helo=mailtransmit04.runbox.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, T_SPF_PERMERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: guix-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org Sender: guix-devel-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Spam-Score: -5.78 X-Migadu-Queue-Id: 3E3083FCEA X-Migadu-Scanner: mx13.migadu.com X-Migadu-Spam-Score: -5.78 X-TUID: FdYNk/cUXXB+ On 2 Apr, Christina O'Donnell wrote: > Hi Steve, > > I just wanted to say that I enjoyed the first one of these and I'm looking > forward to today's session. I did want to go to the last session, but I lost > track of time and missed it! > > I'm a new contributor who's only sent a few patches up, but these sessions > have been helpful for making contributing feel less intimidating. I haven't > quite felt comfortable enough to review any patches on my own, so I do like > the idea of pair-reviewing patches with someone who's a bit more > experienced. (...) Hi Christina - thanks for coming along today - I hope it was useful. There's good instructions on the Wiki on how to review patches: https://libreplanet.org/wiki?title=Group:Guix/PatchReviewSessions2024 I would love feedback on how to improve them! There's plenty of patches to review, I've been keeping a list of them for the patch review calls: https://debbugs.gnu.org/cgi-bin/pkgreport.cgi?tag=patch-review-hackers-list;users=guix And the wiki page references some other reports. Please pick some patches and have a go - if you want someone else to look at them feel free to ping here or on IRC! Thanks, Steve / Futurile