unofficial mirror of guix-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Saku Laesvuori <saku@laesvuori.fi>
To: Vagrant Cascadian <vagrant@reproducible-builds.org>
Cc: Felix Lechner <felix.lechner@lease-up.com>,
	 Maxim Cournoyer <maxim.cournoyer@gmail.com>,
	Suhail <suhail@bayesians.ca>,
	help-guix@gnu.org,  Julien Lepiller <julien@lepiller.eu>,
	Simon Tournier <zimon.toutoune@gmail.com>,
	guix-devel@gnu.org
Subject: Re: Turning off tests leads to a different store item
Date: Wed, 8 Nov 2023 21:20:03 +0200	[thread overview]
Message-ID: <sgcib5spy4wiuzh2qiwv3vbemdsuvwwhdt64k6it4t4utiouwj@uuyf3atk7xas> (raw)
In-Reply-To: <871qd0p0qn.fsf@contorta>

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

On Wed, Nov 08, 2023 at 10:18:40AM -0800, Vagrant Cascadian wrote:
> On 2023-11-08, Felix Lechner via wrote:
> > On Wed, Nov 08 2023, Maxim Cournoyer wrote:
> >> A source tree doesn't produce a derivation.  A derivation is the
> >> complete build recipe that captures the source and the package
> >> definition, that when built by the daemon produces a store item.
> >
> > Okay, thanks! Now I'm going to get it right:
> >
> > The store item that is produced should not change whether build-time
> > tests run or not.
> >
> > It does not make sense (and wastes resources) to rebuild a consuming
> > package because build-time tests were enabled or disabled in an input.
> 
> I do not really think people are misunderstanding you, more that your
> *should* does not align with reality in a way that guix can depend on;
> build-time tests *do* affect the build result in some cases.
> 
> [...]
> 
> The only way to ensure they do not change the build results is even more
> resource-intensive; systematically run the build without tests and then
> run the build with tests and compare the store items... assuming the
> build is reproducible in the first place, which is not yet 100% reliable
> either, unfortunately.

There is another way: simply preventing the tests from changing the
resulting store item. For example, the package could first be built
without tests and then that build tree could be copied to the build tree
of the build with tests enabled. The result of that build could then
just be copied from the testless build, ignoring any changes the test
suite has made to the build tree. I'm not confident enough in my
understanding of how Guix builds things to say for sure that this
specific method would work, but I am quite sure that the general idea is
implementable.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-11-08 19:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <65429087.0c0a0220.5908c.4d60SMTPIN_ADDED_BROKEN@mx.google.com>
     [not found] ` <87zfzpie51.fsf@gmail.com>
     [not found]   ` <871qd19cqn.fsf@lease-up.com>
     [not found]     ` <878r78gv6m.fsf@gmail.com>
     [not found]       ` <87ttpw897n.fsf@lease-up.com>
2023-11-08 18:18         ` Turning off tests leads to a different store item Vagrant Cascadian
2023-11-08 19:20           ` Saku Laesvuori [this message]
2023-11-08 22:21             ` Simon Tournier
2023-11-09  3:17               ` Maxim Cournoyer
2023-11-09  7:37                 ` Simon Tournier
2023-11-09 15:04                   ` Maxim Cournoyer
2023-11-16  9:31                     ` Simon Tournier
2023-11-18  4:38                       ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sgcib5spy4wiuzh2qiwv3vbemdsuvwwhdt64k6it4t4utiouwj@uuyf3atk7xas \
    --to=saku@laesvuori.fi \
    --cc=felix.lechner@lease-up.com \
    --cc=guix-devel@gnu.org \
    --cc=help-guix@gnu.org \
    --cc=julien@lepiller.eu \
    --cc=maxim.cournoyer@gmail.com \
    --cc=suhail@bayesians.ca \
    --cc=vagrant@reproducible-builds.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).