From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <guix-devel-bounces+larch=yhetil.org@gnu.org>
Received: from mp0 ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by ms0.migadu.com with LMTPS
	id RPQHCW/RbWF+iwAAgWs5BA
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Mon, 18 Oct 2021 21:56:31 +0200
Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))
	by mp0 with LMTPS
	id GAUlBG/RbWFhDAAA1q6Kng
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	for <larch@yhetil.org>; Mon, 18 Oct 2021 19:56:31 +0000
Received: from lists.gnu.org (lists.gnu.org [209.51.188.17])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by aspmx1.migadu.com (Postfix) with ESMTPS id D4FD4367E2
	for <larch@yhetil.org>; Mon, 18 Oct 2021 21:56:30 +0200 (CEST)
Received: from localhost ([::1]:37540 helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <guix-devel-bounces+larch=yhetil.org@gnu.org>)
	id 1mcYkH-0001jE-IE
	for larch@yhetil.org; Mon, 18 Oct 2021 15:56:29 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:56446)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rprior@protonmail.com>)
 id 1mcYk3-0001iW-VX
 for guix-devel@gnu.org; Mon, 18 Oct 2021 15:56:16 -0400
Received: from mail-4322.protonmail.ch ([185.70.43.22]:27333)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <rprior@protonmail.com>)
 id 1mcYk0-0005oX-2j
 for guix-devel@gnu.org; Mon, 18 Oct 2021 15:56:15 -0400
Date: Mon, 18 Oct 2021 19:56:00 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;
 s=protonmail; t=1634586960;
 bh=EkF5aWyWCPWhKVkg9Rs9EmafBtYC5zcBzPiOOUsIxo4=;
 h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From;
 b=DRpJIyYcUjO3txsuW3RVrll9FKaKy1MTbATuH6mO3ar8tUJFesCC+1ZzgkKQqBXLV
 CxlGRmSbqdyjM/sENipTQb7m2MhcCMNtdyLfOdreGqj2QBxk6gicNg2NqysWnF4/aS
 bbAv3zsl6cdUn9JKzvHob6G3Ap9U464XRM/yY1KM=
To: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludovic.courtes@inria.fr>
From: Ryan Prior <rprior@protonmail.com>
Cc: Liliana Marie Prikler <liliana.prikler@gmail.com>, guix-devel@gnu.org
Subject: Re: Tricking peer review
Message-ID: <nGryWLpTkg6CypUliNjgBxXbrpSLCjWKpxT3V_t_lBsIf8y2JThZqlQP0P8XEfvyG_fGuUpePy_sO8sZXn1lfzcWgb7PIFTxkeoILaHHfcA=@protonmail.com>
In-Reply-To: <87h7dedbms.fsf@inria.fr>
References: <874k9if7am.fsf@inria.fr>
 <daa70f61feb91fd0e358c110885ce4b2fc55bd61.camel@gmail.com>
 <VAvsM8o3G8NsMwxf60R5TjHWhT0BYCZfqmybzP80u0acH_kGnqF2v7CK4y-DQAe28R5zSYhs1MqblSj67SuXNhVo64KJCngG-1_gwGyUMpc=@protonmail.com>
 <87h7dedbms.fsf@inria.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Received-SPF: pass client-ip=185.70.43.22; envelope-from=rprior@protonmail.com;
 helo=mail-4322.protonmail.ch
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-BeenThere: guix-devel@gnu.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Development of GNU Guix and the GNU System distribution."
 <guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
 <mailto:guix-devel-request@gnu.org?subject=subscribe>
Reply-To: Ryan Prior <rprior@protonmail.com>
Errors-To: guix-devel-bounces+larch=yhetil.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+larch=yhetil.org@gnu.org>
X-Migadu-Flow: FLOW_IN
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org;
	s=key1; t=1634586990;
	h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date:
	 message-id:message-id:to:to:cc:cc:mime-version:mime-version:
	 content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references:list-id:list-help:
	 list-unsubscribe:list-subscribe:list-post:dkim-signature;
	bh=EkF5aWyWCPWhKVkg9Rs9EmafBtYC5zcBzPiOOUsIxo4=;
	b=L8ikVCDM6hnYosYJqqans7o/kDvNm7SIZTq2dd9CbeW8YXaWDhazjzwntY3XOAGPhVk1gu
	hc6xWCoYGqQoGR7cHDNS9SdpIDEfF4bC5ZP9vwUSlU27Bu1bCU1ysrIQx50s9XZ9dQYNYs
	iyjyXLhL5tThRT7N58PFOqJbWjLz9RRac5TXibdK4J2Gr/BFGhHfKXVlCeCk4khpPClRCV
	rcW2OBLnNoPm9+7nctNr7oGmgTMLd7FJup86+bcpjVCQ4esQgAxC/fgRybeJfPmc8XS/IJ
	u1cOoS/7U/3SX5kryiLuzQ40pWFvHfawPGdaWyT7TlV2Oa/nqGhveR71ST/dag==
ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634586990; a=rsa-sha256; cv=none;
	b=aLnaBhz/m0jkUgwroaDaNPRMwAJzGU9cklhH1dTmXRtnHslh2likrpzzK5c9E1gpZHhW6G
	Sn4iiUgacVO0YjbZ8fS0LZvS1giG8gwS4h5YqVxaG3H3RSC23kgPyrRfXjFz0xfrEMUGPv
	V7j6YdZbwMVlFC24cu7YbZgDDerXOYVkks5kvMM/mTUdUlLNlX6CYqi298lZ0mu4GMt5oJ
	AZJsOCUEhkYsSzO47Kzg4kQ1zHHoJypcz6ec0zUCeTZK33raJ7CE7hM3jbdX6JKSlPnhIj
	y0QeU57LK2iT5/bycF6AURiVEvITBPJXhRyd1YspRdQpOEEeR0bKHmeUbIk1Lw==
ARC-Authentication-Results: i=1;
	aspmx1.migadu.com;
	dkim=pass header.d=protonmail.com header.s=protonmail header.b=DRpJIyYc;
	dmarc=pass (policy=quarantine) header.from=protonmail.com;
	spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org
X-Migadu-Spam-Score: -2.53
Authentication-Results: aspmx1.migadu.com;
	dkim=pass header.d=protonmail.com header.s=protonmail header.b=DRpJIyYc;
	dmarc=pass (policy=quarantine) header.from=protonmail.com;
	spf=pass (aspmx1.migadu.com: domain of guix-devel-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-devel-bounces@gnu.org
X-Migadu-Queue-Id: D4FD4367E2
X-Spam-Score: -2.53
X-Migadu-Scanner: scn1.migadu.com
X-TUID: zPwmxy43EZUi

On Monday, October 18th, 2021 at 7:40 AM, Ludovic Court=C3=A8s <ludovic.cou=
rtes@inria.fr> wrote:

> Hi Ryan,
> How would we define =E2=80=9Cbad=E2=80=9D though?

A definition isn't necessary, this can be an "I know it when I see it" thin=
g. If we have an oops or discover an issue, and say oh darn that lives in t=
he repo forever now, we'd be able to leave a note to all who try in the fut=
ure to visit impacted commits that all was not well.

Some of this is already captured by our CVE scanning feature, but other thi=
ngs (like your hypothetical "somebody snuck a bad `sed` in!") would benefit=
 from yet more explanation. We don't need a perfect and complete definition=
 of "bad" to agree that any commit where `sed` is actually `grep` (or malwa=
re) is a bad commit & merits a warning. This should not interfere with peop=
le who want to keep using their pinned version of Guix & aren't impacted by=
 the bad package, which remains useful as you note.