From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add vcflib.
Date: Tue, 26 Apr 2016 16:42:33 +0200
Message-ID: <idjzisg77om.fsf@bimsb-sys02.mdc-berlin.net>
References: <878u1aa62m.fsf@gnu.org>
	<idjr3e0a13n.fsf@bimsb-sys02.mdc-berlin.net>
	<874mauhxwb.fsf@gnu.org>
	<idjmvol993f.fsf@bimsb-sys02.mdc-berlin.net>
	<87vb36yri0.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60883)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1av4CK-00018U-Lq
	for guix-devel@gnu.org; Tue, 26 Apr 2016 10:42:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1av4CH-0001XL-6y
	for guix-devel@gnu.org; Tue, 26 Apr 2016 10:42:44 -0400
In-Reply-To: <87vb36yri0.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

> Ricardo Wurmus writes:
>
>> Roel Janssen <roel@gnu.org> writes:
>>
>>> Ricardo Wurmus writes:
>>>
>>>> Roel Janssen <roel@gnu.org> writes:
>>>>
>>>>> From f0cb8c476e902e3351988f7c278b3682837c8cce Mon Sep 17 00:00:00 2=
001
>>>>> From: Roel Janssen <roel@gnu.org>
>>>>> Date: Tue, 22 Mar 2016 15:47:06 +0100
>>>>> Subject: [PATCH 5/8] gnu: Add filevercmp.
>>>>
>>>>> * gnu/packages/bioinformatics.scm (filevercmp): New variable.

[...]

>> I see that my comment was ambiguous.  I meant the argument to
>> =E2=80=9C(file-name ...)=E2=80=9D.  Instead of using =E2=80=9Cfileverc=
mp-src.tar.gz=E2=80=9D I think it
>> would be better to include the generated version number by doing
>> something like this:
>>
>>     (file-name (string-append name "-" version ".tar.gz"))
>
> Oh, of course.  I attached an updated patch.

Pushed as 6b49a37.  Thanks!

~~ Ricardo