From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
To: Ben Woodcroft <b.woodcroft@uq.edu.au>
Cc: "guix-devel@gnu.org" <guix-devel@gnu.org>
Subject: Re: [PATCH] Add python2-seqmagick.
Date: Fri, 25 Sep 2015 16:09:39 +0200 [thread overview]
Message-ID: <idjy4fu4ml8.fsf@bimsb-sys02.mdc-berlin.net> (raw)
In-Reply-To: <55FD2C91.9080203@uq.edu.au>
Ben Woodcroft <b.woodcroft@uq.edu.au> writes:
>>> + ("python-biopython" ,python2-biopython)))
>> And this looks like it should be a propagated input instead. Have you
>> tried running seqmagick after installing it with this package recipe? I
>> found that Python executables often require either propagated inputs or
>> wrapping in PYTHONPATH to work without runtime errors.
>
> I did, although not well enough to pick up the error you point out.
> Actually I'm a bit confused as to the difference between the input types
> even after reading the manual. Is this a fair summary?
I’m sorry to have confused you here. “biopython” should *not* be a
propagated input here, because “seqmagick” provides an executable, not a
library. I was not aware of the fact that the executables are
automatically wrapped here (although the PYTHONPATH is a little too
broad as you also noted).
> Anyway, it seems as if the package would have worked because a wrapper
> is generated with PYTHONPATH including inputs, propagated-inputs and
> native-inputs. But this seems a bit strange - why would native inputs be
> in the runtime wrapper?
Good question. I think it’s because the wrapping phase just wraps the
scripts in “$out/bin” with whatever the PYTHONPATH variable contains.
It doesn’t construct a minimally sufficient PYTHONPATH. Maybe that’s
worth changing in the python-build-system?
>>> + (synopsis
>>> + "Tools for converting and modifying sequence files from the command-line")
>> The synopsis is a bit long. You could shave off two words like this:
>>
>> “Command-line tools for converting and modifying sequence files”
>>
>> but that’s not really much better. I’m open to suggestions.
> "Tools for converting and modifying sequence files"
That’s okay.
>>> + (description
>>> + "Bioinformaticians often have to convert sequence files between formats
>>> +and do little manipulations on them, and it's not worth writing scripts for
>>> +that. Seqmagick is a utility to expose the file format conversion in
>>> +BioPython in a convenient way. Instead of having a big mess of scripts, there
>>> +is one that takes arguments.")
>>> + (license license:gpl3)))
>>> +
>> I’m not sure if it’s really “GPLv3 only” or “GPLv3 or later” as there
>> are no license headers anywhere. Maybe others could comment what’s the
>> proper declaration here.
> From the readme:
> >|seqmagick| is free software under the GPL v3.
>
> Is that not straightforward enough?
I’m still not sure, but the explicit mention of “v3” is enough for me to
not write “gpl3+” here.
I’ll push your latest patch with minor modifications (undoing the
“propagated-inputs” confusion I caused and moving the synopsis on one
line).
Thanks again!
~~ Ricardo
next prev parent reply other threads:[~2015-09-25 14:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 11:47 [PATCH] Add python2-seqmagick Ben Woodcroft
2015-09-17 15:51 ` Ricardo Wurmus
2015-09-19 9:36 ` Ben Woodcroft
2015-09-21 7:34 ` Pjotr Prins
2015-09-21 16:13 ` Ludovic Courtès
2015-09-21 22:36 ` Ben Woodcroft
2015-09-24 5:08 ` Pjotr Prins
2015-09-24 7:36 ` Ludovic Courtès
2015-09-24 8:37 ` R and R modules (and a Ruby twist) Pjotr Prins
2015-09-24 9:40 ` Ricardo Wurmus
2015-09-24 15:16 ` Pjotr Prins
2015-09-25 9:14 ` Ricardo Wurmus
2015-09-25 14:09 ` Ricardo Wurmus [this message]
2015-09-25 22:14 ` [PATCH] Add python2-seqmagick Ben Woodcroft
2015-09-28 9:54 ` Ricardo Wurmus
2015-09-21 22:41 ` Cyril Roelandt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=idjy4fu4ml8.fsf@bimsb-sys02.mdc-berlin.net \
--to=ricardo.wurmus@mdc-berlin.de \
--cc=b.woodcroft@uq.edu.au \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).