From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH 07/10] gnu: Add python-rauth.
Date: Fri, 4 Dec 2015 10:53:42 +0100
Message-ID: <idjy4da8rq1.fsf@bimsb-sys02.mdc-berlin.net>
References: <1449153811-32039-1-git-send-email-efraim@flashner.co.il>
	<1449153811-32039-8-git-send-email-efraim@flashner.co.il>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a4n3u-0006I1-Kf
	for guix-devel@gnu.org; Fri, 04 Dec 2015 04:53:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a4n3p-00043i-KP
	for guix-devel@gnu.org; Fri, 04 Dec 2015 04:53:58 -0500
Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:53847)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1a4n3p-00043Y-E4
	for guix-devel@gnu.org; Fri, 04 Dec 2015 04:53:53 -0500
In-Reply-To: <1449153811-32039-8-git-send-email-efraim@flashner.co.il>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
To: Efraim Flashner <efraim@flashner.co.il>
Cc: guix-devel@gnu.org


Efraim Flashner <efraim@flashner.co.il> writes:

> * gnu/packages/python.scm (python-rauth, python2-rauth): New variables.
> ---
>  gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 21aa8fa..5c71aac 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6064,6 +6064,39 @@ automatically detect a wide range of file encodi=
ngs.")
>  (define-public python2-chardet
>    (package-with-python2 python-chardet))
> =20
> +(define-public python-rauth
> +  (package
> +    (name "python-rauth")
> +    (version "0.7.2")
> +      (source
> +        (origin
> +          (method url-fetch)
> +          (uri (pypi-uri "rauth" version))
> +          (sha256
> +            (base32
> +             "00pq7zw429hhza9c0qzxiqp77m653jv09z92nralnmzwdf6pzicf")))=
)
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:test-target "check"))
> +    (native-inputs
> +     `(("python-setuptools" ,python-setuptools)))
> +    (inputs
> +     `(("python-requests" ,python-requests)))

I think this should be a propagated input.

> +    (home-page "https://github.com/litl/rauth")
> +    (synopsis "Python library for OAuth 1.0/a, 2.0, and Ofly")
> +    (description
> +     "Rauth is a Python library for OAuth 1.0/a, 2.0, and Ofly.  It al=
so
> +provides service wrappers for convenient connection initialization and
> +authenticated session objects providing things like keep-alive.")
> +    (license license:expat)))

Otherwise OK.

> +(define-public python2-rauth
> +  (let ((rauth (package-with-python2 python-rauth)))
> +    (package (inherit rauth)
> +      (native-inputs
> +       `(("python2-unittest2", python2-unittest2)
> +         ,@(package-native-inputs rauth))))))
> +

Lookin=E2=80=99 good!

~~ Ricardo