From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH 06/10] gnu: Add python-swiftclient. Date: Fri, 11 Dec 2015 15:22:31 +0100 Message-ID: References: <1449153811-32039-1-git-send-email-efraim@flashner.co.il> <1449153811-32039-7-git-send-email-efraim@flashner.co.il> <20151207212732.31b2d51e@debian-netbook> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Oap-0008Tm-JJ for guix-devel@gnu.org; Fri, 11 Dec 2015 09:22:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a7Oam-00038r-D9 for guix-devel@gnu.org; Fri, 11 Dec 2015 09:22:43 -0500 Received: from venus.bbbm.mdc-berlin.de ([141.80.25.30]:47094) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a7Oam-00038d-0f for guix-devel@gnu.org; Fri, 11 Dec 2015 09:22:40 -0500 In-Reply-To: <20151207212732.31b2d51e@debian-netbook> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Efraim Flashner Cc: guix-devel@gnu.org > From 9207e8e3ae7cc78e6377cd811ce30454fce42081 Mon Sep 17 00:00:00 2001 > From: Efraim Flashner > Date: Mon, 23 Nov 2015 20:27:37 +0200 > Subject: [PATCH 06/10] gnu: Add python-swiftclient. > * gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient): > New variables. > --- > gnu/packages/openstack.scm | 53 ++++++++++++++++++++++++++++++++++++++= ++++++++ > 1 file changed, 53 insertions(+) > diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm > index 43f957b..d0f65f0 100644 > --- a/gnu/packages/openstack.scm > +++ b/gnu/packages/openstack.scm > @@ -750,3 +750,56 @@ LDAP.") > ,@(alist-delete > "python-oauthlib" > (package-native-inputs keystoneclient))))))) > + > +(define-public python-swiftclient > + (package > + (name "python-swiftclient") > + (version "2.6.0") > + (source > + (origin > + (method url-fetch) > + (uri (pypi-uri "python-swiftclient" version)) > + (sha256 > + (base32 > + "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p")))) The alignment of =E2=80=9C(base32=E2=80=9D is too far to the right, I thi= nk. (Are you using Emacs to automatically align expressions?) > + (build-system python-build-system) > + (native-inputs > + `(("python-pbr", python-pbr) > + ("python-setuptools" ,python-setuptools) > + ;; some packages are needed for the tests > + ("python-coverage" ,python-coverage) > + ("python-discover" ,python-discover) > + ("python-hacking" ,python-hacking) > + ("python-mock" ,python-mock) > + ("python-oslosphinx" ,python-oslosphinx) > + ("python-keystoneclient" ,python-keystoneclient) > + ("python-sphinx" ,python-sphinx) Sphix is probably for generating documentation, so I=E2=80=99d move this = above the comment because it could be misunderstood. > + ("python-testrepository" ,python-testrepository) > + ("python-testtools" ,python-testtools))) > + (propagated-inputs > + `(("python-requests" ,python-requests) > + ("python-six" ,python-six))) > + (home-page "http://www.openstack.org/") > + (synopsis "OpenStack Object Storage API Client Library") > + (description > + "OpenStack Object Storage (code-named Swift) creates redundant, sca= lable > +object storage using clusters of standardized servers to store petabyt= es of > +accessible data. It is not a file system or real-time data storage sy= stem, but > +rather a long-term storage system for a more permanent type of static = data that > +can be retrieved, leveraged, and then updated if necessary. Primary e= xamples of > +data that best fit this type of storage model are virtual machine imag= es, photo > +storage, email storage and backup archiving. Having no central \"brain= \" or ^___ two spaces, please :) =20 > +master point of control provides greater scalability, redundancy and p= ermanence.") (Is it just me or are these lines really just a bit little longer than usual?) > + (license asl2.0))) > + > +(define-public python2-swiftclient > + (let ((swiftclient (package-with-python2 python-swiftclient))) > + (package (inherit swiftclient) > + (propagated-inputs > + `(("python2-futures" ,python2-futures) > + ,@(package-inputs swiftclient))) I think this should be =E2=80=9Cpackage-propagated-inputs=E2=80=9D instea= d of =E2=80=9Cpackage-inputs=E2=80=9D. > + (native-inputs > + `(("python2-keystoneclient" ,python2-keystoneclient) > + ,@(alist-delete > + "python-keystoneclient" > + (package-native-inputs swiftclient))))))) > --=20 > 2.6.2 Otherwise okay. ~~ Ricardo