From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: r-devtools: Update to 1.10.0. Date: Wed, 30 Mar 2016 11:15:01 +0200 Message-ID: References: <87wpolv6cz.fsf@gnu.org> <87vb45v4n5.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:40085) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alCDY-0002oy-T5 for guix-devel@gnu.org; Wed, 30 Mar 2016 05:15:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alCDV-0008Q7-J9 for guix-devel@gnu.org; Wed, 30 Mar 2016 05:15:12 -0400 In-Reply-To: <87vb45v4n5.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Roel Janssen Cc: guix-devel@gnu.org Roel Janssen writes: > Hello Ricardo, > > Thank you for your superfast review. > > Ricardo Wurmus writes: > >>> In this newer version, a new dependency was introduced (r-withr), whi= ch >>> I also added a package recipe for. >> >> Could you please split this into two separate patches? One adding >> r-withr, the other updating r-devtools and adding r-withr. > > Done. > >>> From 30c0938b1d1239fc1a1c894d6706c4f322395a9e Mon Sep 17 00:00:00 200= 1 >>> From: Roel Janssen >>> Date: Tue, 29 Mar 2016 14:00:57 +0200 >>> Subject: [PATCH] gnu: r-devtools: Update to 1.10.0. >> >>> * gnu/packages/statistics.scm (r-devtools): Update to 1.10.0. >>> * gnu/packages/statistics.scm (r-withr): New variable. >> >> In addition to splitting these changes, please also mention that you >> added r-withr to the propagated-inputs of r-devtools. > > I hope the syntax for this is correct in my new patch. > >>> +(define-public r-withr >>> + (package >>> + (name "r-withr") >>> + (version "1.0.1") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (cran-uri "withr" version)) >>> + (sha256 >>> + (base32 >>> + "0zbj3rd7dc0ycknmay7y7rm1qvnh9n05jw93gjggz46j2zfmy93= y")))) >>> + (build-system r-build-system) >>> + (home-page "https://github.com/jimhester/withr") >>> + (synopsis "Run code with temporarily modified global state") >>> + (description >>> + "A set of functions to run code 'with' safely and temporarily m= odified >>> +global state. Many of these functions were originally a part of the= 'devtools' >>> +package, this provides a simple package with limited dependencies to= provide >>> +access to these functions.") >>> + (license license:gpl2+))) >> >> Please try to turn the first sentence fragment into an actual sentence= , >> even if it is just =E2=80=9CThis package provides [a] set of functions= ...=E2=80=9D. >> >> Aside from that I don=E2=80=99t understand the first sentence. Is =E2= =80=9Cwith=E2=80=9D a >> function or a keyword? If so, it should be wrapped in =E2=80=9C@code{= }=E2=80=9D. But >> even then I have difficulties parsing the sentence. >> >> The second sentence seems to be a combination of two sentences glued >> together by a comma. This should probably be a semicolon. >> >> So how about this instead? >> >> =E2=80=9CThis package provides a set of functions to run R code i= n an >> environment in which global state has been temporarily modified. >> Many of these functions were originally a part of the 'devtools' >> package.=E2=80=9D >> >> Thanks! > > Your proposed description reads fine. Thank you for this! I made one > small change: 'devtools' to r-devtools, because that's the Guix package > name. Thank you! They both look good to me. I=E2=80=99ll push them to the rep= ository in a moment. ~~ Ricardo