From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add vcflib. Date: Tue, 26 Apr 2016 16:47:53 +0200 Message-ID: References: <878u1aa62m.fsf@gnu.org> <877ffqhz0c.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:34040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1av4HU-0007Xx-1z for guix-devel@gnu.org; Tue, 26 Apr 2016 10:48:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1av4HQ-0002dR-RG for guix-devel@gnu.org; Tue, 26 Apr 2016 10:48:03 -0400 In-Reply-To: <877ffqhz0c.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org Roel Janssen writes: > Ricardo Wurmus writes: > >> Roel Janssen writes: >> >>> From edcf3132dca6c3e86439710892870285377adbb2 Mon Sep 17 00:00:00 200= 1 >>> From: Roel Janssen >>> Date: Tue, 22 Mar 2016 15:07:47 +0100 >>> Subject: [PATCH 3/8] gnu: Add multichoose. >> >>> * gnu/packages/bioinformatics.scm (multichoose): New variable. >>> --- >>> gnu/packages/bioinformatics.scm | 35 +++++++++++++++++++++++++++++++= ++++ >>> 1 file changed, 35 insertions(+) >> >>> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinform= atics.scm >>> index fa7ba24..9465d56 100644 >>> --- a/gnu/packages/bioinformatics.scm >>> +++ b/gnu/packages/bioinformatics.scm >>> @@ -4861,3 +4861,38 @@ algorithm.") >>> ;; this program is a submodule, is licensed MIT, which is the = same as >>> ;; the Expat license. >>> (license (list license:gpl2 license:expat))))) >>> + >>> +(define-public multichoose >>> + (package >>> + (name "multichoose") >>> + (version "1.0.3") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append "https://github.com/ekg/multichoose/archiv= e/v" >>> + version ".tar.gz")) >>> + (file-name (string-append name "-" version ".tar.gz")) >>> + (sha256 >>> + (base32 "0xy86vvr3qrs4l81qis7ia1q2hnqv0xcb4a1n60smxbhqqis5w3l= ")))) >>> + (build-system gnu-build-system) >>> + (native-inputs >>> + `(("python" ,python-2) >>> + ("node" ,node))) >>> + (arguments >>> + `(#:tests? #f ; There are no tests to run. >>> + #:phases >>> + (modify-phases %standard-phases >>> + (delete 'configure) ; There is no configure phase. >>> + (replace 'install >>> + (lambda* (#:key outputs #:allow-other-keys) >>> + (let ((bin (string-append (assoc-ref outputs "out") "/b= in"))) >>> + (install-file "multichoose" bin) >>> + (install-file "multipermute" bin))))))) >> >> Nitpick: normally, we place the arguments right below the >> =E2=80=9Cbuild-system=E2=80=9D. The =E2=80=9Cnative-inputs=E2=80=9D t= hen follow after =E2=80=9Carguments=E2=80=9D. > > Ok. I fixed this in the new patch. > >>> + (home-page "https://github.com/ekg/multichoose") >>> + (synopsis "Library for efficient loopless multiset combination g= eneration >>> +algorithm") >> >> This synopsis is a bit long. Maybe drop =E2=80=9Cefficient=E2=80=9D? = (Most projects >> include =E2=80=9Cefficient=E2=80=9D or =E2=80=9Cfast=E2=80=9D in their= descriptions, so it isn=E2=80=99t very >> useful in a synopsis.) > > I dropped efficient. A bit sad it doesn't keep the synopsis on a singl= e > line. I cannot think of a shorter way to describe this library. > >>> + (description "A library implements an efficient loopless multise= t >>> +combination generation algorithm which is (approximately) described = in >>> +\"Loopless algorithms for generating permutations, combinations, and= other >>> +combinatorial configurations.\" G Ehrlich - Journal of the ACM (JACM= ), >>> +1973. (Algorithm 7.)") >> >> =E2=80=9CA library=E2=80=9D? How about =E2=80=9CThis package provides= a library implementing...=E2=80=9D > > Yes, that's better. That reminds me to double-check descriptions for > complete sentences. Thanks for catching this. > > > I attached a new patch. The patch looks good. I tried to apply this to master but failed. Could you please try to rebase it onto master? ~~ Ricardo