From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add samtools Date: Mon, 15 Dec 2014 12:36:10 +0100 Message-ID: References: <878uie6pd9.fsf@gnu.org> <87k31wysbs.fsf@netris.org> <87y4qcj728.fsf@mango.localdomain> <8761dfmtq5.fsf@gnu.org> <87a92rse9s.fsf@netris.org> <87zjarqy5n.fsf@netris.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Twu-0007KH-95 for guix-devel@gnu.org; Mon, 15 Dec 2014 06:36:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y0Two-0005h6-Dz for guix-devel@gnu.org; Mon, 15 Dec 2014 06:36:24 -0500 Received: from pegasus.bbbm.mdc-berlin.de ([141.80.25.20]:34954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y0Two-0005gq-1K for guix-devel@gnu.org; Mon, 15 Dec 2014 06:36:18 -0500 In-Reply-To: <87zjarqy5n.fsf@netris.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Mark H Weaver Cc: guix-devel@gnu.org --=-=-= Content-Type: text/plain >>>> Can we disable the test suite for certain architectures? Or would they >>>> have to be disabled completely? >> >> Since it fails the same way on mips64el, I suggest this instead: >> >> #:tests? (string=? (or (%current-system) (%current-target-system)) >> "x86_64-linux") > > Oops, we forgot to mention that there should be a comma before that > first open paren, like this: > > #:tests? ,(string=? (or (%current-system) (%current-target-system)) > "x86_64-linux") Attached is a patch that disables the tests on all systems but x86_64-linux. I'm unsure about the indentation, though. Should the compared string really be aligned with the arguments of `(or' (as shown above), or rather aligned with `(or', the argument to `(string=?' (as in the attached patch)? -- rekado --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename="0001-gnu-samtools-disable-tests-for-non-64-bit-systems.patch" >From c9846248c28f2c22660c156d4275326fe8afac80 Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Mon, 15 Dec 2014 12:23:01 +0100 Subject: [PATCH] gnu: samtools: disable tests for non-64-bit systems * gnu/packages/bioinformatics.scm (samtools): disable tests for all non-64-bit systems because of an upstream bug in the test data. --- gnu/packages/bioinformatics.scm | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformatics.scm index bcc5d43..1f323eb 100644 --- a/gnu/packages/bioinformatics.scm +++ b/gnu/packages/bioinformatics.scm @@ -111,7 +111,14 @@ BED, GFF/GTF, VCF.") "1y5p2hs4gif891b4ik20275a8xf3qrr1zh9wpysp4g8m0g1jckf2")))) (build-system gnu-build-system) (arguments - '(#:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out"))) + `(;; There are 87 test failures when building on non-64-bit architectures + ;; due to invalid test data. This has since been fixed upstream (see + ;; ), but as there has + ;; not been a new release we disable the tests for all non-64-bit + ;; systems. + #:tests? ,(string=? (or (%current-system) (%current-target-system)) + "x86_64-linux") + #:make-flags (list (string-append "prefix=" (assoc-ref %outputs "out"))) #:phases (alist-cons-after 'unpack -- 1.9.3 --=-=-=--