From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] gnu: Add inklingreader Date: Tue, 10 Nov 2015 16:37:23 +0100 Message-ID: References: <874mguym1e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:57159) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwAzI-0003RD-Uo for guix-devel@gnu.org; Tue, 10 Nov 2015 10:37:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwAzD-0003rl-VV for guix-devel@gnu.org; Tue, 10 Nov 2015 10:37:36 -0500 In-Reply-To: <874mguym1e.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org To: Roel Janssen Cc: guix-devel@gnu.org Hi Roel, thanks for the patch! I wonder if the inklingreader could be added to an existing module. Maybe =E2=80=98graphics.scm=E2=80=99? > From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Tue, 10 Nov 2015 15:01:33 +0100 > Subject: [PATCH] gnu: Add inklingreader Nitpick: end the summary line with a period =E2=80=98.=E2=80=99. > * gnu-system.am: Add the package to GNU_SYSTEM_MODULES. > * gnu/packages/inklingreader.scm: The package description. Normally, we write it like this: > * gnu/packages/inklingreader.scm: New file. > * gnu-system.am (GNU_SYSTEM_MODULES): Add it. If adding to an existing module it would be something like this: > * gnu/packages/graphics.scm (inklingreader): New variable. [...] > +(define-public inklingreader > + (package > + (name "inklingreader") > + (version "0.8") > + (source (origin > + (method url-fetch) > + (uri (string-append > + "ftp://alpha.gnu.org/gnu/inklingreader/inklingread= er-" > + version ".tar.gz")) You should be able to use =E2=80=9Cmirror://gnu/=E2=80=9D here. I don=E2= =80=99t know the exact URL, though (and I haven=E2=80=99t tried yet). > + (sha256 > + (base32 > + "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"= )))) > + (build-system gnu-build-system) > + (arguments `(#:configure-flags '("--enable-silent-rules"))) What does this do? (I=E2=80=99m just curious.) > + (inputs > + `(("glib" ,glib) > + ("cairo" ,cairo) > + ("librsvg" ,librsvg) > + ("gtk+" ,gtk+) > + ("libusb" ,libusb) > + > + ;; Needed to build the package. > + ("texinfo" ,texinfo))) Inputs that are only needed at build time should be added to =E2=80=98native-inputs=E2=80=99 instead. > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + Please do not put an empty line here. > + (home-page "http://savannah.gnu.org/projects/inklingreader/") > + (synopsis "Wacom Inkling sketch format conversion and manipulation= ") > + (description > + "GNU InklingReader is a free software package to support the Waco= m Inkling > +device, including data conversion to various free formats, basic editi= ng > +features, and an Inkscape plugin.") Since all software in Guix is free software you should not mention this here again. I wonder about the Inkscape plugin: does it work out of the box with our inkscape package? > + (license license:gpl3+))) A very nice first contribution! Thank you again. (I=E2=80=99ll let others comment on this.) ~~ Ricardo