Re: [PATCH] gnu: Add inklingreader

[Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>]

Hi Roel,

thanks for the patch!

I wonder if the inklingreader could be added to an existing module.
Maybe ‘graphics.scm’?

> From 7cd292fdb46637858e4eaedd3570b607b5087720 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 10 Nov 2015 15:01:33 +0100
> Subject: [PATCH] gnu: Add inklingreader

Nitpick: end the summary line with a period ‘.’.

> * gnu-system.am: Add the package to GNU_SYSTEM_MODULES.
> * gnu/packages/inklingreader.scm: The package description.

Normally, we write it like this:

> * gnu/packages/inklingreader.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.

If adding to an existing module it would be something like this:

> * gnu/packages/graphics.scm (inklingreader): New variable.

[...]

> +(define-public inklingreader
> +  (package
> +    (name "inklingreader")
> +    (version "0.8")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "ftp://alpha.gnu.org/gnu/inklingreader/inklingreader-"
> +                    version ".tar.gz"))

You should be able to use “mirror://gnu/” here.  I don’t know the exact
URL, though (and I haven’t tried yet).

> +              (sha256
> +               (base32
> +                "0ikg95mgwfqh0bq4dzvkfmdiycacqvv27g91hl6adwk5y3gzl96g"))))
> +    (build-system gnu-build-system)
> +    (arguments `(#:configure-flags '("--enable-silent-rules")))

What does this do?  (I’m just curious.)

> +    (inputs
> +     `(("glib" ,glib)
> +       ("cairo" ,cairo)
> +       ("librsvg" ,librsvg)
> +       ("gtk+" ,gtk+)
> +       ("libusb" ,libusb)
> +
> +       ;; Needed to build the package.
> +       ("texinfo" ,texinfo)))

Inputs that are only needed at build time should be added to
‘native-inputs’ instead.

> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)))
> +

Please do not put an empty line here.

> +    (home-page "http://savannah.gnu.org/projects/inklingreader/")
> +    (synopsis "Wacom Inkling sketch format conversion and manipulation")
> +    (description
> +     "GNU InklingReader is a free software package to support the Wacom Inkling
> +device, including data conversion to various free formats, basic editing
> +features, and an Inkscape plugin.")

Since all software in Guix is free software you should not mention this
here again.

I wonder about the Inkscape plugin: does it work out of the box with our
inkscape package?

> +    (license license:gpl3+)))

A very nice first contribution!  Thank you again.
(I’ll let others comment on this.)

~~ Ricardo