From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ricardo Wurmus Subject: Re: [PATCH] Add vcflib. Date: Wed, 20 Apr 2016 14:49:53 +0200 Message-ID: References: <878u1aa62m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:56523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asra2-0008F1-NJ for guix-devel@gnu.org; Wed, 20 Apr 2016 08:50:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asrZz-0003EN-CV for guix-devel@gnu.org; Wed, 20 Apr 2016 08:50:06 -0400 In-Reply-To: <878u1aa62m.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Roel Janssen Cc: guix-devel@gnu.org Roel Janssen writes: > From e75aa388931c92657336c8a15f88b6a0273f5e02 Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Tue, 22 Mar 2016 15:01:37 +0100 > Subject: [PATCH 2/8] gnu: Add smithwaterman. > * gnu/packages/bioinformatics.scm (smithwaterman): New variable. > --- > gnu/packages/bioinformatics.scm | 31 +++++++++++++++++++++++++++++++ > 1 file changed, 31 insertions(+) > diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformat= ics.scm > index 6792be9..fa7ba24 100644 > --- a/gnu/packages/bioinformatics.scm > +++ b/gnu/packages/bioinformatics.scm > @@ -4830,3 +4830,34 @@ group or two ChIP groups run under different con= ditions.") > (description "This is a C++ wrapper around the Tabix project which = abstracts > some of the details of opening and jumping in tabix-indexed files.") > (license license:expat))) > + > +(define-public smithwaterman > + (let ((commit "203218b47d45ac56ef234716f1bd4c741b289be1")) As there have been new commits since you posted this patch could you add a comment that explains why it should be this particular commit? Is it because this is the version of the submodule of vcflib? > + (package > + (name "smithwaterman") > + (version (string-append "0-1." (string-take commit 7))) > + (source (origin > + (method url-fetch) > + (uri (string-append "https://github.com/ekg/smithwaterman/arch= ive/" > + commit ".tar.gz")) > + (file-name (string-append name "-" version "-checkout.tar.gz")= ) > + (sha256 > + (base32 "1lkxy4xkjn96l70jdbsrlm687jhisgw4il0xr2dm33qwcclzzm3b= ")))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f ; There are no tests to run. > + #:phases > + (modify-phases %standard-phases > + (delete 'configure) ; There is no configure phase. > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let ((bin (string-append (assoc-ref outputs "out") "/b= in"))) > + (install-file "smithwaterman" bin))))))) > + (home-page "https://github.com/ekg/smithwaterman") > + (synopsis "Implementation of the Smith-Waterman algorithm") > + (description "This package provides an implementation of the Smi= th-Waterman > +algorithm.") > + ;; libdisorder is licensed GPLv2. The parent project (vcflib), = of which > + ;; this program is a submodule, is licensed MIT, which is the sa= me as > + ;; the Expat license. > + (license (list license:gpl2 license:expat))))) As far as I can see the license is GPLv2+ as it doesn=E2=80=99t specifica= lly restricts users to version 2. The license of the parent project doesn=E2=80=99t matter in this case, so =E2=80=9C(license license:gpl2+)=E2=80=9D would seem to be enough. ~~ Ricardo