From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Subject: Re: [PATCH] Add vcflib.
Date: Wed, 20 Apr 2016 14:56:03 +0200
Message-ID: <idjshyga17g.fsf@bimsb-sys02.mdc-berlin.net>
References: <878u1aa62m.fsf@gnu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58556)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1asrg2-00016H-PX
	for guix-devel@gnu.org; Wed, 20 Apr 2016 08:56:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Ricardo.Wurmus@mdc-berlin.de>) id 1asrfy-00050H-Mk
	for guix-devel@gnu.org; Wed, 20 Apr 2016 08:56:18 -0400
In-Reply-To: <878u1aa62m.fsf@gnu.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Roel Janssen <roel@gnu.org>
Cc: guix-devel@gnu.org


Roel Janssen <roel@gnu.org> writes:

> From ec8d80b1be2d4271b6a1583a1c1a6264d37ccbeb Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Tue, 22 Mar 2016 15:10:53 +0100
> Subject: [PATCH 4/8] gnu: Add fsom.

> * gnu/packages/bioinformatics.scm (fsom): New variable.
> ---
>  gnu/packages/bioinformatics.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

> diff --git a/gnu/packages/bioinformatics.scm b/gnu/packages/bioinformat=
ics.scm
> index 9465d56..0abccbc 100644
> --- a/gnu/packages/bioinformatics.scm
> +++ b/gnu/packages/bioinformatics.scm
> @@ -4896,3 +4896,30 @@ combination generation algorithm which is (appro=
ximately) described in
>  combinatorial configurations.\" G Ehrlich - Journal of the ACM (JACM),
>  1973. (Algorithm 7.)")
>      (license license:expat)))
> +
> +(define-public fsom
> +  (let ((commit "a6ef318fbd347c53189384aef7f670c0e6ce89a3"))
> +    (package
> +      (name "fsom")
> +      (version (string-append "0-1." (string-take commit 7)))
> +      (source (origin
> +        (method url-fetch)
> +        (uri (string-append "https://github.com/ekg/fsom/archive/"
> +                            commit ".tar.gz"))
> +        (file-name (string-append name "-" version "-checkout.tar.gz")=
)
> +        (sha256
> +         (base32 "0q6b57ppxfvsm5cqmmbfmjpn5qvx2zi5pamvp3yh8gpmmz8cfbl3=
"))))
> +      (build-system gnu-build-system)
> +      (arguments
> +       `(#:tests? #f ; There are no tests to run.
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure) ; There is no configure phase.
> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((bin (string-append (assoc-ref outputs "out") "/b=
in")))
> +                 (install-file "fsom" bin)))))))
> +      (home-page "https://github.com/ekg/fsom")
> +      (synopsis "Program for managing SOM (Self-Organizing Maps)
> neural networks")

This is a bit long.  I=E2=80=99d drop the abbreviation and its expansion.=
  Is
this a program or a library?

> +      (description "Program for managing SOM (Self-Organizing Maps)
> neural networks.")

Could you please turn this into a full sentence?

> +      (license license:gpl3))))

Looks right.  =E2=80=9Cfsom.c=E2=80=9D says =E2=80=9CLicense: GNU GPL v.3=
=E2=80=9D.

~~ Ricardo